Issue information

Issue ID
#6483
Status
Fixed
Severity
Fair
Started
Hercules Elf Bot
Aug 17, 2012 15:40
Last Post
Hercules Elf Bot
Dec 9, 2012 22:17
Confirmation
Yes (2)
No (0)

Hercules Elf Bot - Aug 17, 2012 15:40

Originally posted by [b]Vali[/b]
The OnTouch of the NPC [b]yuno_in01,35,179,4 script Pub Master#kh 46,5,5,{[/b] in the kyel_hyre_quest.txt is over the warp portal in [b]yuno_in01 32 182[/b] not allowing the player to leave the pub.

Current list of warps not working:
[list]
[*]yuno_in01 32 182
[*]man_in01 275 41
[/list]
Vali~

This post has been edited by Vali on Sep 4, 2012 10:15

Hercules Elf Bot - Aug 17, 2012 18:53

Originally posted by [b]Joseph[/b]
Shouldn't it the exit be yuno_in01 40,176?

Hercules Elf Bot - Aug 17, 2012 19:26

Originally posted by [b]Vali[/b]
That is not the point, the point that that you cant use the portal in [b]yuno_in01 32 182[/b][b]because that NPC[/b]

Hercules Elf Bot - Aug 17, 2012 21:05

Originally posted by [b]Ind[/b]
if i recall this isn't the first bug report about that, its' because ontouch stuff can't stack (or it gets broken x__X) i'm not sure what can be done, i'll open for discussion and move it to the core section

Hercules Elf Bot - Sep 4, 2012 10:15

Originally posted by [b]Vali[/b]
Updated the first post with the warps not working.

Hercules Elf Bot - Dec 9, 2012 15:47

Originally posted by [b]ozzey[/b]
How about the progress? /ic

Hercules Elf Bot - Dec 9, 2012 22:16

Originally posted by [b]mkbu95[/b]
He does now Vali. I gave him a raise, he's being very kind to the players /slur
Just update to [rev=17013].

Let me know if you feel any performance drop (playing localhost is one thing, server full with players is another).

Now with technicals, when it finds a NPC with OnTouch it performs another lookup to check warps with OnTouch on that map.
If found, they're then checked if they're close to player location and thus teleport the player to the specified location.
I went from O(n³) to O(n)-i, I guess it is much better now, even though it isn't 100% precise (it fixes both cases you presented, but I didn't test other possibilities).
You'll notice that you still talk to the NPC but you are warped after done talking or if you click directly to the warp, the NPC interaction will start and then is terminated after the warp.

This post has been edited by mkbu95 on Dec 9, 2012 22:18