EDP + Cross Impact

Originally posted by [b]VodkaMartini[/b]
confirmed on Cross Ripped Slasher, Magnum Break, Meteor Assault and Phantom Menace Skill. (r16666)

Attachment shows Magnum Break + EDP. w/o EDP damage = ~< 2k

Originally posted by [b]mofo[/b]
it's actually worse now because it raises ATK prior to boosting final damage by 400%. I'l try to get screenshots later. i made sure i had renewal.h set to renewal edp.

Originally posted by [b]Poseid0n[/b]
I confirm this bug. EDP do too much damage. It one shoot all players.

Do you can, please, fix it ?

Originally posted by [b]zamorasantos[/b]
yes its a bug

Originally posted by [b]kyeme[/b]
Yeah too much damage .. i disabled Renewal EDP on my server

Originally posted by [b]Tepoo[/b]
Tested on official Server. Cross Impact doesnt increase the dmg when edp is activated.

Originally posted by [b]RyokoMVP[/b]
but here edp give 400% final atk lol...i already posting about this before...but they dont care...

Originally posted by [b]Euphy[/b]
Is anyone working on this? This is a major issue on Renewal servers...

Originally posted by [b]kyeme[/b]
Thank you for confirming this.

Originally posted by [b]GM Takumirai[/b]
I dont know if this is the correct fix http://rathena.org/board/topic/69340-reduce-damage-normal-attack-use-edp/page__p__135694#entry135694

Originally posted by [b]malufett[/b]
[quote]Is anyone working on this? This is a major issue on Renewal servers...[/quote]
ok let me do it..I'll do a remedy even though renewal atk is not yet fully implemented..

Originally posted by [b]Angezerus[/b]
I don't mean to push anyone, but why does nobody start that renewal atk implementation? It's a problem since 3-4 months, I already posted formulas and links about the problem, but noone does anything. This should be the first thing... There's no point in fixing skills all the time if the base attack is wrong. This edp thingie is starting to really piss me off. There's about 10 to 20 reports about this. Please do something, or revert to the old 400% atk. Anything would be better!

But theres a problem with the skill as well:
Currently we increase the weapon atk and base atk as well (as intended), but in the meantime we increase the final attack by 400% (as it was done in the old formula). THIS is the problem wit the skill.... This is a duplicate bonus. Pz make the 400% bonus only pre re.
Of course the renewal formula needs renewal attack, but as you see it's an error in the skill as well not only the missing re atk...

Here's the source:

Renewal bonus part:
[CODE]
#ifdef RENEWAL_EDP
// renewal EDP increases your weapon atk by watk x Skill Level - 1
if( sc->data[SC_EDP] && sc->data[SC_EDP]->val1 > 1 )
watk = watk * (sc->data[SC_EDP]->val1 - 1);
[/CODE]

This applies to renewal as well, making the bonus extremely OP
[CODE]
case SC_EDP: // [Celest]
val2 = val1 + 2; //Chance to Poison enemies.
val3 = 50*(val1+1); //Damage increase (+50 +50*lv%) <<<< SHOULD BE ONLY PRE RE
[/CODE]

Originally posted by [b]malufett[/b]
this should be the fixed [rev='16770']..
however due to the current atk formula damage is still quite huge...but not that big as before...

I don't know If I should flag all reports as fixed...anyway bug me if its ok to change all to fixed...

Originally posted by [b]Angezerus[/b]
Thanks a lot :3

Originally posted by [b]kyeme[/b]
Thanks for d fixed . May I ask something?
My normal attack is = 60k and my Cross Impact = 109K is this normal? or there was something wrong about bDefRatioAtkRace (Pierce Defense) ? Im using Super Latest Revision. Here's my Screenshot

Screenshot 1: Sura with Angelus and Revitalize Alive [b]Total Def = 433[/b] + 5 and Cranial Shield. And [b]Venon Impression[/b]
[attachment=3487:1.JPG]
Screenshot 2: Equipment of GX = [b]Ice Pick [/b]with Turtle General Card
[attachment=3486:2.JPG]
Screenshot 3: [b]Normal Attack of GX = 60k[/b]
[attachment=3488:3.JPG]
Screenshot 4: [b]Cross Impact of GX = 109k each[/b]
[attachment=3489:4.JPG]

Originally posted by [b]malufett[/b]
@kyeme
its normal in our current formula..but its not normal as we can see..
anyway this is how it makes the damage still huge..
are current formula or the PRE flows
[quote]Base Damage->Skill Modifiers->[b]Damage Reduction[/b]->Masteries->Elemental->Card Bonuses[/quote]

therefor the '[color=#282828][font=helvetica, arial, sans-serif][size=3]bDefRatioAtkRace' bonus is amplified(suppose to be wrong) where it should be added as fixed damage..[/size][/font][/color]

[color=#282828][font=helvetica, arial, sans-serif][size=3][/size][/font][/color]

Originally posted by [b]donkeyg[/b]
any solution on this?

Originally posted by [b]donkeyg[/b]
this was happened in my server. 150 max level. and no god item at all but they still able to cross impact 99999999999 dmg on every MVP.... and i don think even if i got MG/ mjolnir can deal such a over damage
[attachment=4475:screenPassion-RO011.jpg]
[attachment=4476:screenPassion-RO008.jpg]
[attachment=4477:screenPassion-RO009.jpg]

Originally posted by [b]donkeyg[/b]
bump!

Originally posted by [b]GM Takumirai[/b]
any further solution

Originally posted by [b]donkeyg[/b]
Please do some action on this EDP and CROSS IMPACT.

Originally posted by [b]donkeyg[/b]
hey... why no respond from rathena development.. i suffer about this problem so long

Originally posted by [b]GM Takumirai[/b]
@donkey suggest to patch the manage skill damage v.2 by Lilith
- im hoping that patch will be put in our svn so that we can easily manage the skills if we see an imbalance to the server since some skills are not yet fix totally , while waiting we can manage the skill damage by using the patch by Lilith ..

Originally posted by [b]donkeyg[/b]
[quote name='GM Takumirai' timestamp='1353682308' post='15847']
@donkey suggest to patch the manage skill damage v.2 by Lilith- im hoping that patch will be put in our svn so that we can easily manage the skills if we see an imbalance to the server since some skills are not yet fix totally , while waiting we can manage the skill damage by using the patch by Lilith ..
[/quote]
where can i find the patch by lilith's 1? ^^

Originally posted by [b]GM Takumirai[/b]
http://rathena.org/board/topic/62238-manage-skill-damage-20/

Originally posted by [b]donkeyg[/b]
[quote name='GM Takumirai' timestamp='1353767384' post='15878']
[url="http://rathena.org/board/topic/62238-manage-skill-damage-20/"]http://rathena.org/b...kill-damage-20/[/url]
[/quote]

not really know how to use it.. just copy and paste? haha! btw, why kro is so slow to fix this skill?

Originally posted by [b]Euphy[/b]
Please keep unrelated discussion out of the bug tracker. That's what the support forums are for. ._.

Originally posted by [b]GM Takumirai[/b]
as Euphy said we must not discuss unrelated issue in here, anyway answer to your question is that its not kRO that it make it unfixable, we have developers now starting the fix of this issue.. so wait for them and support them for there time to fix it..

Originally posted by [b]Angezerus[/b]
Since this is more of a renewal attack issue, there is no need to modify the skills. Their formula is okay. The only problem is the missing eAtk/ wAtk separation and the missing renewal pierceing calculation.

Originally posted by [b]donkeyg[/b]
[quote name='GM Takumirai' timestamp='1353908951' post='15909']
as Euphy said we must not discuss unrelated issue in here, anyway answer to your question is that its not kRO that it make it unfixable, we have developers now starting the fix of this issue.. so wait for them and support them for there time to fix it..
[/quote]
Glad to heard that! hope the rathena Team will fix it as fast as possible ^^

Originally posted by [b]arun89[/b]
still waiting for a solution to this... patiently waiting ^^

Originally posted by [b]donkeyg[/b]
Bumppppp this thread and still havent been fix since august 20?

Originally posted by [b]Angezerus[/b]
[quote name='donkeyg' timestamp='1354251454' post='16031']
Bumppppp this thread and still havent been fix since august 20?
[/quote]

Some are not fixed since May. Be patient pz. As many ppl mentioned: these issues are related to Renewal Atk. There's no point in teporally nerfing the skill, because attack is the one that needs to be fixed. Only then can the skill formula be altered. Till then use pre renewal edp settings if neccessary.

Originally posted by [b]powerboots[/b]
or you could use the same formula as maximum_overthrust which only boost 200% on physical attacks (make it 400% on edp)

Originally posted by [b]Angezerus[/b]
[quote name='powerboots' timestamp='1354324560' post='16061']
or you could use the same formula as maximum_overthrust which only boost 200% on physical attacks (make it 400% on edp)
[/quote]

The problem is that EDP increases eAtk by 4 and wAtk by 5 times, but eAtk is not implemented, so once again, this needs Renewal Attack. Using other skill's formulas would make it even worse and only delay the main problem

Originally posted by [b]donkeyg[/b]
O.o .. but im still prefer waiting for the rathena team's solution xD

Originally posted by [b]powerboots[/b]
here's a fix i made my own

battle.c line 3000
[quote] if (sc->data[SC_EDP]) {
switch (skill_num) {
case AS_SPLASHER:
case AS_VENOMKNIFE:
case AS_GRIMTOOTH:
break;
[/quote]
grimtooth shouldn't be there. as we know grimtooth doesnt increase damage on edp skill

battle.c line 3015
[quote]ATK_RATE(50); // only modifier is halved but still benefit with the damage bonus[/quote]
this part is totally wrong, atk_rate(50) means it\ll boost attack by 50%. the real damage suppose to be half which means
[quote]ATK_RATE(-50); // only modifier is halved but still benefit with the damage bonus[/quote]

as for some people who wants final damage added +400%, insert this script at line 2041
[quote] if (sc->data[SC_EDP])
skillratio += sc->data[SC_EDP]->val2;[/quote]

some of it might be wrong, so if anyone can check & confirm this?

anyway.. GC_CROSSRIPPERSLASHER should be added somewhere, which reduce it's attack (either does not boost or half modifier)

Originally posted by [b]Golem1988[/b]
[quote name='powerboots' timestamp='1354586566' post='16154']
here's a fix i made my ownbattle.c line 3000[quote] if (sc->data[SC_EDP]) { switch (skill_num) { case AS_SPLASHER: case AS_VENOMKNIFE: case AS_GRIMTOOTH: break;[/quote]

[/quote]

nice try man, but this code disables grimtooth on edp

Originally posted by [b]powerboots[/b]
[quote name='Golem1988' timestamp='1354684447' post='16162']
[quote name='powerboots' timestamp='1354586566' post='16154']here's a fix i made my ownbattle.c line 3000[quote] if (sc->data[SC_EDP]) { switch (skill_num) { case AS_SPLASHER: case AS_VENOMKNIFE: case AS_GRIMTOOTH: break;[/quote][/quote] nice try man, but this code disables grimtooth on edp
[/quote]

well.. thanks for telling it out (sorry i'm still quite new to this stuffs so there are lots of parts where i don't understand at all.)
the only solution did i placed is that i added grimtooth to the half damage modifier because grimtooth had no delay and is crazy high damage
as for other attacks modifier, i've learn it out of coincidence (when i nerf thanatos, and boost maxoverthrust)

Originally posted by [b]Golem1988[/b]
[quote]ok let me do it..I'll do a remedy even though renewal atk is not yet fully implemented..[/quote] <c> Malufett
Okay... this is the quote from 10th of september. How many time has passed? Lemme tell you: 4 months = No result. This question was posted even earlyer.
As I see the point were to tell people "we are working on it, relax" and let all the things as they were?
I don't really believe that atk formulas are so hard to write if you really do it.
Bump, wanna hear about some changes or wanna hear what problems developers met doing this thing real. I mean doing normal atk formula real.
Bump, bump, bump. This formula ruines all tre emulator btw, people are leaving servers becaue of horrible formula, so I request some changelog from developement side. Thanks.
I still believe rA isn't dead...

Originally posted by [b]arun89[/b]
still no solution? i might have gotten the 'avoid spamming' reply, but nevertheless, bump again. i am not spamming, just urging for a quick solution to this matter.

Originally posted by [b]donkeyg[/b]
+1 for u arun89