Talking to NPC

Originally posted by [b]malufett[/b]
and I think we need to create another script command for this
[quote](you can Change Equip except Refiner NPC)[/quote]

Originally posted by [b]Ind[/b]
[quote name='malufett' timestamp='1345625746' post='13620']
and I think we need to create another script command for this[quote](you can Change Equip except Refiner NPC)[/quote]
[/quote]
thats a rather dangerous thing to do -- it'd open exploits in many poorly scripted npcs.

Originally posted by [b]malufett[/b]
so what shall we do? to hinder characters to change equipment/use skills/ and etc in a specific npc?? by not affecting general npc..

Originally posted by [b]Kenpachi[/b]
in AEGIS there is a script command to block the players ability to change equip... I'd say let's do it the official way.

Originally posted by [b]malufett[/b]
[quote]in AEGIS there is a script command to block the players ability to change equip... I'd say let's do it the official way.[/quote]
+1

Originally posted by [b]Lunar[/b]
I think we have to list all npc which could be vulnerable to this behavior, like card remover, [s]or armor enchanter[/s] (player have to take only one copy of armor)

Originally posted by [b]Leeg[/b]
I'd like to point out that in iRO you can't use self-skills or items, but you can change your equipment.

If you try to, a message is shown in the general message tab:

'any work in progress (NPC dialog, manufacturing...) quit and try again',

Originally posted by [b]malufett[/b]
[quote]I'd like to point out that in iRO you can't use self-skills or items, but you can change your equipment.[/quote]
as I checked kRO only non-self skill target cannot be used..but let me check if there is a error message when doing restricted moves...

Originally posted by [b]mkbu95[/b]
[code]*enable_items;
*disable_items;

These commands enable item usage while an NPC is running. When enable_items is
run, items can be used during scripts until disable_items is called.
To avoid possible exploits, when enable_items is invoked, it will only enable
item usage while running that script in particular. Note that if a different
script also calls enable_items, it will override the last call (so you may
want to call this command at the start of your script without assuming the
effect is still in effect).[/code]
?

Originally posted by [b]Angezerus[/b]
[quote name='Ind' timestamp='1345668289' post='13658']
[quote name='malufett' timestamp='1345625746' post='13620']and I think we need to create another script command for this[quote](you can Change Equip except Refiner NPC)[/quote] [/quote]thats a rather dangerous thing to do -- it'd open exploits in many poorly scripted npcs.
[/quote]
As long as the criteria check is in the same "frame" as the "action", there shouldn't be any problem, and afaik every official npc checks in the exact moment when it does something with an item. Or am I wrong?

Originally posted by [b]Brian[/b]
I think leave item/skill usage disabled and let users enable item use if they want, using 'enable_items' and 'disable_items'.

Any news in kRO?
[quote name="Hercules Elf Bot" timestamp="1345745814"]
Originally posted by [b]Leeg[/b]
I'd like to point out that in iRO you can't use self-skills or items, but you can change your equipment.

If you try to, a message is shown in the general message tab:

'any work in progress (NPC dialog, manufacturing...) quit and try again',[/quote]

This behavior are now on pRO. Bifrost episode.
[url="http://www.youtube.com/watch?v=iMO_4BoGYIM&feature=youtu.be"]http://www.youtube.com/watch?v=iMO_4BoGYIM&feature=youtu.be[/url]

I confirm in iRO Sakray.

[quote]
Any news in kRO?[/quote]
same ways...

:meow:

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][color=rgb(51,51,51)][font='lucida grande', tahoma, verdana, arial]If you are allowed to unequipping/equipping while talking to NPC, maybe what we should do is when there is written in the script/npc like[b]"successrefitem, failedrefitem, successremovecards"[/b], then.. equipping and unequipping should be automatically disabled when talking to that NPC. [/font][/color][/font][/color]
[color=rgb(51,51,51)][font=helvetica, arial, sans-serif][size=3][font='lucida grande', tahoma, verdana, arial]I[/font][/size][/font][/color][color=rgb(51,51,51)][font=helvetica, arial, sans-serif][size=3][font='lucida grande', tahoma, verdana, arial][size=2] [size=4]would suggest this if this is possible. :)[/size][/size][/font][/size][/font][/color]

[quote name="kyeme" timestamp="1360400919"]
[color=#282828][font=helvetica, arial, sans-serif][color=#333333][font=tahoma, verdana, arial]If you are allowed to unequipping/equipping while talking to NPC, maybe what we should do is when there is written in the script/npc like[b]"successrefitem, failedrefitem, successremovecards"[/b], then.. equipping and unequipping should be automatically disabled when talking to that NPC. [/font][/color][/font][/color]
[color=#333333][font=helvetica, arial, sans-serif][size=3][font=tahoma, verdana, arial]I[/font][/size][/font][/color][color=#333333][font=helvetica, arial, sans-serif][size=3][font=tahoma, verdana, arial][size=2] [size=4]would suggest this if this is possible. :)[/size][/size][/font][/size][/font][/color][/quote]
There are commands in the official scripts that toggle this functionality -- that hasn't been the problem. Something like this will totally break custom scripts on a [i]lot[/i] of servers, potentially creating exploits everywhere. But I suppose it has to be done sometime. ._.

If somebody codes the source for this, I can add the commands to our scripts.

moving this to scripts

please identify all npc that needs disabling of equipping/unquipping of equipment and use this command.
[code=auto:0] *enable_items; *disable_items; [/code]
afterwards return it here so that we can enable by default 'enable_items'

Thank you..
:meow:

I'll make a full script patch if you post a full core patch. XD[code=auto:0]cashitem\advholgren.sc 27 local\dewata\dewata_weapon.sc 360 local\dewata\dewata_weapon.sc 423 local\malangdo\mal_jerun.sc 48 local\malangdo\mal_jerun.sc 574 local\malangdo\mal_yong.sc 25 local\malangdo\mal_yong.sc 1912 quest\2004_hat.sc 829 quest\2005_hat.sc 1528 quest\2005_hat.sc 2288 quest\god\god_mjol.sc 1955 quest\god\god_mjol.sc 2310 quest\tutorial\para_suvquest.sc 3382 siglude\alberta_refine.sc 231 siglude\einbroch_refine.sc 232 siglude\lighthalzen_refine.sc 231 siglude\morocc_refine.sc 231 siglude\new_smelting.sc 27 siglude\new_smelting.sc 442 siglude\new_smelting.sc 857 siglude\payon_refine.sc 231 siglude\prontera_refine.sc 231 siglude\yuno_refine.sc 231 [/code]

[attachment=103:r17160.patch]

Thanks...Fixed @ [url="https://github.com/HerculesWS/Hercules/commit/ad792f41994ce54dc9e45fbdaaf591f38fccecee"]https://github.com/HerculesWS/Hercules/commit/ad792f41994ce54dc9e45fbdaaf591f38fccecee[/url]

:meow:

[quote name="malufett" timestamp="1361903042"]
Thanks...Fixed @ [url="https://github.com/HerculesWS/Hercules/commit/ad792f41994ce54dc9e45fbdaaf591f38fccecee"][url="https://github.com/HerculesWS/Hercules/commit/ad792f41994ce54dc9e45fbdaaf591f38fccecee"]https://github.com/HerculesWS/Hercules/commit/ad792f41994ce54dc9e45fbdaaf591f38fccecee[/url][/url]

:meow:[/quote]
[s]Commit failed? [/s] Nevermind.

On pre-renewal you can: use usable items and self skills while talking to NPC.