Homunculus hp not being updated properly?
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6587
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Aug 29, 2012 22:35
Last Post
Hercules Elf Bot
Sep 9, 2012 6:04
Confirmation
Hercules Elf Bot - Aug 29, 2012 22:35
Originally posted by [b]mkbu95[/b]
I noticed that there are two functions not using all parameters in homunculus.c:
[code]void merc_damage(struct homun_data *hd,struct block_list *src,int hp,int sp)
{
clif_hominfo(hd->master,hd,0);
}[/code]
[code]void merc_hom_heal(struct homun_data *hd,int hp,int sp)
{
clif_hominfo(hd->master,hd,0);
}[/code]
Also, > I think < that they're not being used because clif_hominfo use the hom struct that was updated on status_heal or status_damage.
However I'd prefer to use the values from status_heal -> merc_hom_heal / status_damage -> clif_hominfo rather than the actual way. Is it safer, to retrieve the info from a struct instead of a integer parameter?
Well, Idk
[img]http://i.imgur.com/VaepU.jpg[/img]
I noticed that there are two functions not using all parameters in homunculus.c:
[code]void merc_damage(struct homun_data *hd,struct block_list *src,int hp,int sp)
{
clif_hominfo(hd->master,hd,0);
}[/code]
[code]void merc_hom_heal(struct homun_data *hd,int hp,int sp)
{
clif_hominfo(hd->master,hd,0);
}[/code]
Also, > I think < that they're not being used because clif_hominfo use the hom struct that was updated on status_heal or status_damage.
However I'd prefer to use the values from status_heal -> merc_hom_heal / status_damage -> clif_hominfo rather than the actual way. Is it safer, to retrieve the info from a struct instead of a integer parameter?
Well, Idk
[img]http://i.imgur.com/VaepU.jpg[/img]
This post has been edited by mkbu95 on Aug 29, 2012 22:38
Hercules Elf Bot - Sep 7, 2012 21:47
Originally posted by [b]mkbu95[/b]
Can I bump this? [img]http://superseeds.org/images/smilies/suggest.gif[/img]
Can I bump this? [img]http://superseeds.org/images/smilies/suggest.gif[/img]
Hercules Elf Bot - Sep 7, 2012 23:43
Originally posted by [b]Ind[/b]
there is no real difference in both cases but these un-used params should go.
there is no real difference in both cases but these un-used params should go.
Hercules Elf Bot - Sep 8, 2012 17:58
Originally posted by [b]Ind[/b]
Fixed in [rev=16760]
Fixed in [rev=16760]