El Dicastes missing checks

Originally posted by [b]DeePee[/b]
When talking to Guard Captain Avalanche without having started the Sapha's Visit Quest, the script can basically mess up pretty badly. All this NPC checks for is whether you have the Ring of Wisdom equipped and whether you are at a further stage in the quest. It does not check whether you have started it or anything.

So if someone who visits Manuk without having started the Sapha's Visit Quest and talks to Guard Captain Avalanche, he basically gets this set:

[code]
changequest 7183,7184;
set ep13_3_invite,4;[/code]

Furthermore, when talking to the Hound#ep13_3_06 or Sapha from Manuk once, ep13_3_invite gets set to 3. However, you need to talk to one of them a second time. If you do NOT do this, quest 7182 does not get updated to 7183 and thus it cannot find 7183 when it needs to update. This results in 7184 not being set when talking to Guard Captain Avalanche and that again results in not being able to get the Light of El Dicastes.

Basically we ended up with a player having ep13_3_invite set to 4 while having these errors: [quote][02:49:19][Error]: quest_change: Character 1075530 doesn't have quest 7182.
[02:49:28][Error]: quest_change: Character 1075530 doesn't have quest 7182.
[02:50:34][Error]: quest_change: Character 1075530 doesn't have quest 7183.
[/quote]

That means ep13_3_invite must have already been set before he talked to Guard Aello#ep13_3_03 where Quest ID 7182 is set.

That does not seem right to me. It seems that there are more similar occurences around the script. I haven't dug that much deeper in the script but there are definitely some things that are not going right there.

At the very least Guard Captain Avalanche should probably have a check similar to...

[code]if (ep13_3_invite == 3 && checkquest(7183) > 0) {[/code]

...before updating the quest and the variable. That should solve the issue with people talking to that NPC before needing to and the issue with people only talking to Hound#ep13_3_06 or Sapha From Manuk once instead of twice or more.