Issue information

Issue ID
#6684
Status
Invalid
Severity
None
Started
Hercules Elf Bot
Sep 13, 2012 4:58
Last Post
Hercules Elf Bot
Sep 13, 2012 13:48
Confirmation
Yes (0)
No (3)

Hercules Elf Bot - Sep 13, 2012 4:58

Originally posted by [b]Rage[/b]
i got compile warnings in login.c when i applied harmony.. im using Centos 64bit

here's the error, im using r16775

[codebox]
login.c: In function âparse_loginâ:
login.c:1490: error: too few arguments to function âmmo_authâ
login.c:1531: error: too few arguments to function âmmo_authâ
make[1]: *** [obj_sql/login.o] Error 1
make[1]: Leaving directory `/eathena/src/login'
make: *** [login_sql] Error 2
[/codebox]

@EDIT: i fixed it.. but i remove some r16775 update by greenbox, and i left this codes:

[code]unsigned int byte;[/code]

[codebox]
sscanf(buf, "%x", &byte);
nnode->hash[i / 2] = (uint8)(byte & 0xFF);
[/codebox]

my question is, are those codes that i remove affect my server? like map server crash or what?

This post has been edited by Rage on Sep 13, 2012 5:12

Hercules Elf Bot - Sep 13, 2012 12:41

Originally posted by [b]Napster[/b]
Find

[CODE]
case 0x254:
case 0x255:
case 0x256:
{
int result = harm_funcs->login_process_auth(fd, RFIFOP(fd, 0), RFIFOREST(fd), sd->userid, sd->passwd, &sd->version);
RFIFOSKIP(fd, RFIFOREST(fd));
harm_funcs->login_get_mac_address(fd, sd->mac_address);
if( login_config.use_md5_passwds )
MD5_String(sd->passwd, sd->passwd);
if (result > 0) {
login_auth_failed(sd, result);
} else if (result == 0) {
return 0;
} else {
result = mmo_auth(sd);
if (result == -1)
login_auth_ok(sd);
else
login_auth_failed(sd, result);
}
}
break;
[/CODE]

Replace

[CODE]
case 0x254:
case 0x255:
case 0x256:
{
int result = harm_funcs->login_process_auth(fd, RFIFOP(fd, 0), RFIFOREST(fd), sd->userid, sd->passwd, &sd->version);
RFIFOSKIP(fd, RFIFOREST(fd));
harm_funcs->login_get_mac_address(fd, sd->mac_address);
if( login_config.use_md5_passwds )
MD5_String(sd->passwd, sd->passwd);
if (result > 0) {
login_auth_failed(sd, result);
} else if (result == 0) {
return 0;
} else {
result = mmo_auth(sd, false); <--- fix this line
if (result == -1)
login_auth_ok(sd);
else
login_auth_failed(sd, result);
}
}
break;
[/CODE]

This post has been edited by Napster on Sep 13, 2012 12:42

Hercules Elf Bot - Sep 13, 2012 13:48

Originally posted by [b]GreenBox[/b]
Napster is correct, but you need to contact harmony support.