RK Nosiege Rune

Originally posted by [b]Beret[/b]
Is expected to fix ?

Originally posted by [b]MarkZD[/b]
The piece below is incomplete.
[s]I think it's enough:
Open src/map/pc.c
[b]Find:[/b]
[CODE]
if( sd->sc.count && (
sd->sc.data[SC_BERSERK] || sd->sc.data[SC__BLOODYLUST] ||
(sd->sc.data[SC_GRAVITATION] && sd->sc.data[SC_GRAVITATION]->val3 == BCT_SELF) ||
sd->sc.data[SC_TRICKDEAD] ||
sd->sc.data[SC_HIDING] ||
sd->sc.data[SC__SHADOWFORM] ||
sd->sc.data[SC__MANHOLE] ||
sd->sc.data[SC_KAGEHUMI] ||
(sd->sc.data[SC_NOCHAT] && sd->sc.data[SC_NOCHAT]->val1&MANNER_NOITEM)
))
return 0;
// Store information for later use before it is lost (via pc_delitem) [Paradox924X]
nameid = sd->inventory_data[n]->nameid;
[/CODE]
[b]Replace with:[/b]
[CODE]
// Store information for later use before it is lost (via pc_delitem) [Paradox924X]
nameid = sd->inventory_data[n]->nameid;

if( sd->sc.count && (
sd->sc.data[SC_BERSERK] || sd->sc.data[SC__BLOODYLUST] ||
(sd->sc.data[SC_GRAVITATION] && sd->sc.data[SC_GRAVITATION]->val3 == BCT_SELF) ||
sd->sc.data[SC_TRICKDEAD] ||
sd->sc.data[SC_HIDING] ||
sd->sc.data[SC__SHADOWFORM] ||
sd->sc.data[SC__MANHOLE] ||
sd->sc.data[SC_KAGEHUMI] ||
sd->sc.data[SC_WHITEIMPRISON] || // Fix to the list
(sd->sc.data[SC_NOCHAT] && sd->sc.data[SC_NOCHAT]->val1&MANNER_NOITEM && nameid != 12725) //You can use Nosiege under some status
))
return 0;
[/CODE][/s]

Originally posted by [b]Beret[/b]
up.

Originally posted by [b]Beret[/b]
still not to use when frozen, stun and deep sleep MarkZD.

Originally posted by [b]MarkZD[/b]
[quote name='Beret' timestamp='1353606110' post='15812']
still not to use when frozen, stun and deep sleep MarkZD.
[/quote]
You're right, my fix is incomplete.

Originally posted by [b]Lighta[/b]
should be fixed in [rev=16959]

Originally posted by [b]MarkZD[/b]
[quote name='Lighta' timestamp='1353747212' post='15869']
should be fixed in [rev=16959]
[/quote]

I tried a similar fix this morning, after I post the message above, and it didn't work as well as yours.

For some reason it doesn't reach clif_parse_useitem when the user is under Deep Sleep and Stone curse.

Originally posted by [b]Lighta[/b]
Did you removed the option check in clif_parse_UseItem ? and the status and option before asking to do the skill ? (need to remove directly option or it will be delayed to 20ms)
Maybe we can discuss more on irc or pm to not flood the issue

Originally posted by [b]MarkZD[/b]
Also, in the way you changed it's possible to use the Rune under Berserk, manhole, hiding etc which possibly need more info, as the rune may not work in this way.

Originally posted by [b]MarkZD[/b]
[quote name='Lighta' timestamp='1353764305' post='15875']
Did you removed the option check in clif_parse_UseItem ? and the status and option before asking to do the skill ? (need to remove directly option or it will be delayed to 20ms)Maybe we can discuss more on irc or pm to not flood the issue
[/quote]

Yep, I deleted both files I changed and updated with yours to test.

I'm on irc.

Originally posted by [b]Beret[/b]
Still no fix lighta, if the Rune is in the range, and the rune kinght is frozen to use the Rune even crashing it is defrosted.

Originally posted by [b]MarkZD[/b]
[quote name='Beret' timestamp='1353861954' post='15898']
Still no fix lighta, if the Rune is in the range, and the rune kinght is frozen to use the Rune even crashing it is defrosted.
[/quote]
We(lighta and me) know, the item is taking out the effects even when it's under the cooldown, it'll be fixed soon.



About using it under [u]Deep Sleep, Sleep and Stone curse[/u], apparently it's a client behavior. (At least it didn't work on some 2010.
I burlated the options so the client can use it under Deep Sleep while I tested it, but it doesn't seem it should be the way to go).

rAthena still doesn't work with 08/2012+ clients, which are the one that get this feature in sakray, so I don't have a very good way to test if it's supposed to work only in those clients.

This is what I found while I tested, maybe someone who has more knowledge of changeoption can argument about it, as it seems the setting that is blocking the client from using runes when under the status mentioned in [u]this[/u] post.

Originally posted by [b]Lighta[/b]
Followup in [rev=16969]

Originally posted by [b]Beret[/b]
Seems to work now lighta.

Originally posted by [b]Rytech[/b]
All runes should be usable while in those kind of status's according to a tester's results. I wonder if their usable while in Berserk as well.

1. any rune can be used while you are on silence status, cursed circle, root, oblivion curse, ETC.

2. any rune Skill can be use in middle of the aftercast dealy of other skills, but if you use a rune in middle of the cast time of other skill the rune could be consumed and do nothing.

Source: http://forums.irowiki.org/showpost.php?p=781229&postcount=73

Originally posted by [b]MarkZD[/b]
[quote name='Rytech' timestamp='1353962907' post='15911']
1. any rune can be used while you are on silence status, cursed circle, root, oblivion curse, ETC.
[/quote]
It's this way now.
http://trac.rathena.org/changeset/16969

I've sent another patch to lighta wich will fix status being removed when refresh is used, just need to wait his answer.


[quote name='Rytech' timestamp='1353962907' post='15911']
[b]but if you use a rune in middle of the cast time of other skill the rune could be consumed and do nothing.[/b]
Source: [url="http://forums.irowiki.org/showpost.php?p=781229&postcount=73"]http://forums.irowik...29&postcount=73[/url]
[/quote]
Currently it's just not used/consumed, if you try to use it while you're casting.
Is it still this way?
So all item skill are this way or just runes?
We need confirmation on official.

Originally posted by [b]MarkZD[/b]
Fixed at: [url="http://trac.rathena.org/changeset/16979/rathena"]r16979[/url].

Originally posted by [b]xaxixi[/b]
i can't use refresh in stone or sleep.

Originally posted by [b]MarkZD[/b]
[quote name='xaxixi' timestamp='1354384139' post='16100']
i can't use refresh in stone or sleep.
[/quote]

Unfortunately, it's a client behavior which blocks you from using item when you're in these states.