Leftovers from txt removal
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6768
Status
Fixed
Severity
Low
Started
Hercules Elf Bot
Oct 8, 2012 2:18
Last Post
Hercules Elf Bot
Nov 8, 2012 23:37
Confirmation
Hercules Elf Bot - Oct 8, 2012 2:18
Originally posted by [b]mkbu95[/b]
I found some more leftovers.
src/char/int_elemental.c
[code]line 93: #ifndef TXT_SQL_CONVERT
line 164: #endif //TXT_SQL_CONVERT[/code]
src/char/int_guild.h
[code]line 37 to 39
//For the TXT->SQL converter.
int inter_guild_tosql(struct guild *g,int flag);
int inter_guildcastle_tosql(struct guild_castle *gc);[/code]
src/char/int_party.h
[code]line 25 and 26
//Required for the TXT->SQL converter
int inter_party_tosql(struct party *p, int flag, int index);[/code]
src/common/Makefile.in
src/map/Makefile.in
[code]txt is still a target[/code]
@off
And Ind, I know you must be very busy so I will post here everything I pm'd you here.
[IMG]http://i.imgur.com/8yIMM.gif[/IMG]
I found some more leftovers.
src/char/int_elemental.c
[code]line 93: #ifndef TXT_SQL_CONVERT
line 164: #endif //TXT_SQL_CONVERT[/code]
src/char/int_guild.h
[code]line 37 to 39
//For the TXT->SQL converter.
int inter_guild_tosql(struct guild *g,int flag);
int inter_guildcastle_tosql(struct guild_castle *gc);[/code]
src/char/int_party.h
[code]line 25 and 26
//Required for the TXT->SQL converter
int inter_party_tosql(struct party *p, int flag, int index);[/code]
src/common/Makefile.in
src/map/Makefile.in
[code]txt is still a target[/code]
@off
And Ind, I know you must be very busy so I will post here everything I pm'd you here.
[IMG]http://i.imgur.com/8yIMM.gif[/IMG]
Hercules Elf Bot - Oct 8, 2012 4:04
Originally posted by [b]GreenBox[/b]
And remove lock.c?
And remove lock.c?
Hercules Elf Bot - Oct 9, 2012 16:34
Originally posted by [b]Spre[/b]
shouldn't we leave the txt=>sql convert code? Those who switch to rA from eA or have a revision before txt was removed they would need to convert their txt crap to sql yes?
shouldn't we leave the txt=>sql convert code? Those who switch to rA from eA or have a revision before txt was removed they would need to convert their txt crap to sql yes?
Hercules Elf Bot - Oct 9, 2012 16:49
Originally posted by [b]Vach[/b]
I agree with Spre.... considering I'm doing this right now.
I agree with Spre.... considering I'm doing this right now.
Hercules Elf Bot - Oct 15, 2012 19:48
Originally posted by [b]Spre[/b]
after thinking, we can just have a standalone not associated with rathena that converts said txt to sql and then remove the convertor code to clean up the rathena code and have a non text structure.
It would be nice if all DBs were sql driven also and no txt support.
after thinking, we can just have a standalone not associated with rathena that converts said txt to sql and then remove the convertor code to clean up the rathena code and have a non text structure.
It would be nice if all DBs were sql driven also and no txt support.
Hercules Elf Bot - Oct 16, 2012 1:06
Originally posted by [b]mkbu95[/b]
@Vach
I understand, but a lot of the conversion code has been already removed, so I don't think you could get any use with the actual left code.
+1 to Spre suggestion.
@Vach
I understand, but a lot of the conversion code has been already removed, so I don't think you could get any use with the actual left code.
+1 to Spre suggestion.