Issue information

Issue ID
#6800
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Oct 18, 2012 15:18
Last Post
Hercules Elf Bot
Nov 24, 2012 20:45
Confirmation
Yes (2)
No (0)

Hercules Elf Bot - Oct 18, 2012 15:18

Originally posted by [b]AnnieRuru[/b]
seems like I always post this every year lol
anyways 4 of them


1. boss_monster missing explanation


2.
[quote]*waitingroom "<chatroom name>",<limit>{,<event label>,<trigger>,<required zeny>,<min lvl>,<max lvl>};
....
...
// The NPC will have a box above its head, it will say "Disco - Waiting Room"
// and will have 8 waiting slots. Clicking this will enter the chat room, where
// the player will be able to wait until 7 players accumulate. Once this happens,
// it will cause the NPC "Bouncer" run the label "OnStart".

waitingroom "Disco - Waiting Room",8,"Bouncer::OnStart",[color=#ff0000]8[/color];[/quote]
please try this script, tested with double client
[code]prontera,157,186,5 script djfsdkfjd 100,{
end;
OnInit:
waitingroom "test", 3, strnpcinfo(0)+"::Onaa", 2;
end;
Onaa:
announce getwaitingroomstate( 0, strnpcinfo(0) )+" players and trigger this", 0;
end;
}[/code]this waitingroom can hold 2 players( + npc ), and once 2 players inside, will trigger Onaa label
if set both <trigger> and <limit> is the same, Onaa label will never trigger
so the <trigger> should be 1 number less than <limit>
that highlighted red should be 7, not 8


3.
http://rathena.org/board/topic/72526-soundeffect-script/page__hl__soundeffect
missing documentation - soundeffect only support 23 characters
and while at it, can you guys fix *soundeffect in script.c and @sound in atcommand.c to limit at 23 char ?


4.
[quote]*sprintf(<format>[,param[,param[,...]]]) [Mirei]

C style sprintf. The resulting string is returned same as in PHP. All C format
specifiers are supported except %n. More info: sprintf @ www.cplusplus.com.
The number of params is only limited by eA's script engine.

See thread: [url="http://www.eathena.ws/board/index.php?showtopic=190410"]http://www.eathena.w...howtopic=190410[/url]

Example:
.@format$ = 'The %s contains %d monkeys';
dispbottom(sprintf(.@format$, "zoo", 5)); //prints "The zoo contains 5 monkeys"
dispbottom(sprintf(.@format$, "barrel", 82)); //prints "The barrel contains 82 monkeys"[/quote]please click on the topic link

This post has been edited by AnnieRuru on Oct 18, 2012 15:22

Hercules Elf Bot - Oct 18, 2012 16:51

Originally posted by [b]Akkarin[/b]
Updating report status while i test these out.

*prods Annie to make them as separate reports next time*

The sprintf link you posted is something i don't have access to on the old boards. I also don't see why it would be required - that example using dispbottom can be output using the normal methods just as easily.

I'll fix up the others.

Hercules Elf Bot - Oct 18, 2012 20:03

Originally posted by [b]AnnieRuru[/b]
4.
yes that's the point, because the link is already broken xD


*ouch*
I always did like this every year in eathena forum
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=373
ok I'll separate them next time

This post has been edited by AnnieRuru on Oct 18, 2012 20:07

Hercules Elf Bot - Nov 6, 2012 20:07

Originally posted by [b]Akkarin[/b]
Partial fix in [rev=16864] for points 3 and 4.

Hercules Elf Bot - Nov 7, 2012 0:33

Originally posted by [b]frenzmu06[/b]
@off from issues 1-4 but since saw the sound effect documentation maybe just some tip :D >add a documentation about the max chars a map_name can hold (forgot exactly how much it can but i think it reads only 11 and wont read the map when map name exceeds) affects map_cache, maps_athena.conf idk if it affects scripts
can u take a look bout this mr. Akkarin :)

Hercules Elf Bot - Nov 24, 2012 20:44

Originally posted by [b]Euphy[/b]
Fixed the rest in [rev=16963], thanks for reporting this!