1. Hercules bug tracker archive
  2. Hercules Bug Archives
  3. Core
  4. Merge killmonster & killmonster2

Merge killmonster & killmonster2

Issue information

Issue ID
#6854
Status
Invalid
Severity
None
Started
Hercules Elf Bot
Nov 5, 2012 6:19
Last Post
Hercules Elf Bot
Nov 5, 2012 18:04
Confirmation
N/A

Hercules Elf Bot - Nov 5, 2012 6:19

Originally posted by [b]mkbu95[/b]
I made a simple diff to merge those commands.
[attachment=4312:killmonster(2)_merge.patch]
If you find it useful...

Hercules Elf Bot - Nov 5, 2012 13:36

Originally posted by [b]Angezerus[/b]
This should be in the forum-release topic, not in the bug tracker. (no offense :))

Btw, killmonster kills monster with drop, but killmonster2 kills monsters without drop. So what's the point of merging em?

This post has been edited by Angezerus on Nov 5, 2012 13:37

Hercules Elf Bot - Nov 5, 2012 14:31

Originally posted by [b]mkbu95[/b]
Where should I post then? /hmm

I know that one drops item and the other one doesn't, but that is just a line of code to change.
It's practical to have just one function for both commands, IMO.

Hercules Elf Bot - Nov 5, 2012 14:34

Originally posted by [b]malufett[/b]
[quote]Where should I post then?[/quote]
in [b]rAthena Development->Source Discussion[/b] I guest..:)

:meow:

Hercules Elf Bot - Nov 5, 2012 17:21

Originally posted by [b]mkbu95[/b]
Thanks. Close this please, if you may.