quest_shop - custom npc
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6856
Status
Fixed
Severity
Low
Started
Hercules Elf Bot
Nov 5, 2012 13:10
Last Post
Hercules Elf Bot
Nov 5, 2012 23:15
Confirmation
Hercules Elf Bot - Nov 5, 2012 13:10
Originally posted by [b]AnnieRuru[/b]
http://trac.rathena.org/changeset/16858/rathena
[acronym="Roll On Floor Laughing"]ROFL[/acronym] .... I spotted another atcommand .... xD
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=1472
change
[code]atcommand "@changelook 3 "+@qe3;
atcommand "@changelook 1 "+@qe4;
atcommand "@changelook 2 "+@qe5;[/code]
into
[code]changelook 3, @qe3;
changelook 4, @qe4;
changelook 5, @qe5;[/code]
[quote name='script_commands.txt']*setlook <look type>,<look value>;
*changelook <look type>,<look value>;
'setlook' will alter the look data for the invoking character. It is used
mainly for changing the palette used on hair and clothes: you specify which look
type you want to change, then the palette you want to use. Make sure you specify
a palette number that exists/is usable by the client you use.
[b]'changelook' works the same, but is only client side (it doesn't save the look value).[/b][/quote]*setlook and *changelook script command behave differently
setlook is use for stylist npc
changelook is use for headgear preview npc and item database script ( just like *changebase )
http://trac.rathena.org/changeset/16858/rathena
[acronym="Roll On Floor Laughing"]ROFL[/acronym] .... I spotted another atcommand .... xD
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=1472
change
[code]atcommand "@changelook 3 "+@qe3;
atcommand "@changelook 1 "+@qe4;
atcommand "@changelook 2 "+@qe5;[/code]
into
[code]changelook 3, @qe3;
changelook 4, @qe4;
changelook 5, @qe5;[/code]
[quote name='script_commands.txt']*setlook <look type>,<look value>;
*changelook <look type>,<look value>;
'setlook' will alter the look data for the invoking character. It is used
mainly for changing the palette used on hair and clothes: you specify which look
type you want to change, then the palette you want to use. Make sure you specify
a palette number that exists/is usable by the client you use.
[b]'changelook' works the same, but is only client side (it doesn't save the look value).[/b][/quote]*setlook and *changelook script command behave differently
setlook is use for stylist npc
changelook is use for headgear preview npc and item database script ( just like *changebase )
This post has been edited by AnnieRuru on Nov 5, 2012 13:12
Hercules Elf Bot - Nov 5, 2012 14:46
Originally posted by [b]EvilPuncker[/b]
lol I was just about to post it
lol I was just about to post it
Hercules Elf Bot - Nov 5, 2012 18:56
Originally posted by [b]Joseph[/b]
Fixed in [rev=16862].
Fixed in [rev=16862].
Hercules Elf Bot - Nov 5, 2012 20:50
Originally posted by [b]Brian[/b]
Thanks AnnieRuru. The last remaining [wiki='atcommand'] are:
[svn=trunk/npc/custom/etc/floating_rates.txt] (no equivalent script command exists)
[code]atcommand "@reloadmobdb";[/code]
[svn=trunk/npc/custom/etc/monster_arena.txt]
[code]atcommand strcharinfo(0) + "@option 64 0 64";[/code]
[svn=trunk/npc/custom/etc/shifty_assassin.txt] (can be replaced with [wiki='percentheal'] -100,0; )
[code]atcommand strcharinfo(0) + "@kill "+@name$;[/code]
The more I looked at this script, the more I wanted to rewrite it.
Thanks AnnieRuru. The last remaining [wiki='atcommand'] are:
[svn=trunk/npc/custom/etc/floating_rates.txt] (no equivalent script command exists)
[code]atcommand "@reloadmobdb";[/code]
[svn=trunk/npc/custom/etc/monster_arena.txt]
[code]atcommand strcharinfo(0) + "@option 64 0 64";[/code]
[svn=trunk/npc/custom/etc/shifty_assassin.txt] (can be replaced with [wiki='percentheal'] -100,0; )
[code]atcommand strcharinfo(0) + "@kill "+@name$;[/code]
The more I looked at this script, the more I wanted to rewrite it.
This post has been edited by Brian on Nov 5, 2012 20:51
Hercules Elf Bot - Nov 5, 2012 23:15
Originally posted by [b]AnnieRuru[/b]
well, not sure if I can post something on a bug report that already fix
1.
atcommand @reloadmobdb is intended to be working that way
because atcommand will create log at log.atcommandlog
a gm can search inside atcommandlog to see [b]when was the last time the server reload the rates[/b]
I also used it to check inside log.atcommandlog to see the script broken on live server or not
so this one is working as intended
unless you guys suggest to do something about it
2.
our script command version setoption can only set the 1st parameter
but the atcommand version can also change 2nd and 3rd parameter
so ... atcommand to use @option is the only way to simulate permanent ....
wait ... 0x40 for 3rd parameter is the same as *pcblockmove
... rofl ... you're right...
it can be replace with pcblockmove + gm hide (setoption 0x40)
however I remember [url=http://www.eathena.ws/board/index.php?showtopic=169365]Information's party vs party script[/url] ( which is bugged and outdated )
his script used atcommand "@option 6 0 64"; to let player choose to become a spectator
6 = petrify but still can move + 64 = gm hide
so there's no way other players can interrupt the match
I don't think with setoption alone can simulate this effect
[url=http://rathena.org/board/tracker/issue-6841-function-sc-start2-has-a-problem/page__gopid__15276#entry15276]even malufett also use atcommand there[/url]
unless you guys added setoption2 and setoption3
3.
that script is way too .......
.........
... no comment xD
btw I think its better to close this one and move this discussion into
SVN development - script discussion
well, not sure if I can post something on a bug report that already fix
1.
atcommand @reloadmobdb is intended to be working that way
because atcommand will create log at log.atcommandlog
a gm can search inside atcommandlog to see [b]when was the last time the server reload the rates[/b]
I also used it to check inside log.atcommandlog to see the script broken on live server or not
so this one is working as intended
unless you guys suggest to do something about it
2.
our script command version setoption can only set the 1st parameter
but the atcommand version can also change 2nd and 3rd parameter
so ... atcommand to use @option is the only way to simulate permanent ....
wait ... 0x40 for 3rd parameter is the same as *pcblockmove
... rofl ... you're right...
it can be replace with pcblockmove + gm hide (setoption 0x40)
however I remember [url=http://www.eathena.ws/board/index.php?showtopic=169365]Information's party vs party script[/url] ( which is bugged and outdated )
his script used atcommand "@option 6 0 64"; to let player choose to become a spectator
6 = petrify but still can move + 64 = gm hide
so there's no way other players can interrupt the match
I don't think with setoption alone can simulate this effect
[url=http://rathena.org/board/tracker/issue-6841-function-sc-start2-has-a-problem/page__gopid__15276#entry15276]even malufett also use atcommand there[/url]
unless you guys added setoption2 and setoption3
3.
that script is way too .......
.........
... no comment xD
btw I think its better to close this one and move this discussion into
SVN development - script discussion
This post has been edited by AnnieRuru on Nov 5, 2012 23:36