Issue information

Issue ID
#687
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Dec 24, 2007 19:58
Last Post
Hercules Elf Bot
Feb 21, 2012 8:54
Confirmation
N/A

Hercules Elf Bot - Dec 24, 2007 19:58

Originally posted by [b]Brainstorm[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=687

Someone please fix this, this is horribly broken:
CODE
                    set .@redem_s,JobLevel+getskilllv(54);
                    set .@red_suc,rand(1,100);
                    if (.@redem_s < 31)
                        if (.@red_suc > 20 && .@red_suc < 41) set .@success,1;
                    else if (.@redem_s < 41)
                        if (.@red_suc > 10 && .@red_suc < 41) set .@success,1;
                    else
                        if (.@red_suc > 10 && .@red_suc < 51) set .@success,1;

                    if (.@success) {

OBVIOUSLY it will work for low job lv characters, but past job50 it will be a endless crusade to obtain the skill. (try doing with a job70 high priest)

A simple fix would just be doing this:
CODE
                    if (.@redem_s < 31) {
                        if (.@red_suc > 20 && .@red_suc < 41) set .@success,1; }
                    else if (.@redem_s < 41) {
                        if (.@red_suc > 10 && .@red_suc < 41) set .@success,1; }
                    else {
                        if (.@red_suc > 10 && .@red_suc < 51) set .@success,1; }


This post has been edited by Brainstorm: Dec 24 2007, 12:00 PM