After 16914 - Hercules bug tracker archive

Issue information

Issue ID

#6890

Status

Fixed

Severity

None

Started

Hercules Elf Bot

Nov 13, 2012 4:25

Last Post

Hercules Elf Bot

Nov 14, 2012 3:48

Confirmation

N/A

Hercules Elf Bot - Nov 13, 2012 4:25

Originally posted by [b]mofo[/b]
If you have zeny logging enabled in log_athena.conf, map server crashes when people sell items to an npc. I forgot to try trading zeny if it crashes the server too. I disabled zeny logging and it seems like it's working fine now. I'll update this bug report if anything else comes up.

Right now:
I'm using revision 16923 with zeny logging disabled and it hasn't crashed. Will continue monitoring and try to provide updates.

Hercules Elf Bot - Nov 13, 2012 5:09

Originally posted by [b]MarkZD[/b]
Apparently it's because of this condition in pc_getzeny.

[CODE]
if(!sd) tsd = sd;
[/CODE]

Which should be:
[CODE]
if(!tsd) tsd = sd;
[/CODE]

Hercules Elf Bot - Nov 13, 2012 5:11

Originally posted by [b]MarkZD[/b]
[quote name='MarkZD' timestamp='1352783384' post='15626']
Apparently it's because of this condition in pc_getzeny.[CODE]if(!sd) tsd = sd;[/CODE]Which should be:[CODE]if(!tsd) tsd = sd;[/CODE]
[/quote]

Someone move this to Core, please.

Hercules Elf Bot - Nov 13, 2012 5:49

Originally posted by [b]exneval[/b]
Confirmed the crash

This post has been edited by exneval on Nov 13, 2012 6:49

Hercules Elf Bot - Nov 13, 2012 16:22

Originally posted by [b]mofo[/b]
i don't know if i should make another topic, but this one is regarding the same revision. here's a scenario:

player A deals player B let's say 100m zeny.
deal pushes through (server console says something about obtaining negative zeny.)
player B gets 100m
player A character selects, and relogs to find he still has the 100m.

result: zeny duplicated

Hercules Elf Bot - Nov 14, 2012 3:35

Originally posted by [b]Mysterious[/b]
It should be fixed in [url="http://trac.rathena.org/changeset/16924/rathena"]16924[/url].