Warning in r16924
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6896
Status
Fixed
Severity
Low
Started
Hercules Elf Bot
Nov 14, 2012 4:00
Last Post
Hercules Elf Bot
Nov 15, 2012 5:35
Confirmation
Hercules Elf Bot - Nov 14, 2012 4:00
Originally posted by [b]kyeme[/b]
warning C4033: 'pc_paycash' must return a value
warning C4033: 'pc_getcash' must return a value
warning C4715: 'pc_paycash' : not all control paths return a value
warning C4715: 'pc_getcash' : not all control paths return a value
warning C4033: 'pc_paycash' must return a value
warning C4033: 'pc_getcash' must return a value
warning C4715: 'pc_paycash' : not all control paths return a value
warning C4715: 'pc_getcash' : not all control paths return a value
Hercules Elf Bot - Nov 14, 2012 4:11
Originally posted by [b]exneval[/b]
manual update?
you should double check again
manual update?
you should double check again
This post has been edited by exneval on Nov 14, 2012 4:15
Hercules Elf Bot - Nov 14, 2012 5:34
Originally posted by [b]kyeme[/b]
Hmm but when i reverted to [b]16923[/b] no warnings.
Hmm but when i reverted to [b]16923[/b] no warnings.
Hercules Elf Bot - Nov 14, 2012 6:37
Originally posted by [b]malufett[/b]
[url="http://trac.rathena.org/changeset/16924/rathena#file4"]http://trac.rathena.org/changeset/16924/rathena#file4[/url]
check this Lighta put a return value for each functions..
[url="http://trac.rathena.org/changeset/16924/rathena#file4"]http://trac.rathena.org/changeset/16924/rathena#file4[/url]
check this Lighta put a return value for each functions..
Hercules Elf Bot - Nov 14, 2012 8:01
Originally posted by [b]Ryuuzaki[/b]
@kyeme had the same problem, following fixed it for me (the compiler functions properly, as well as the functions ingame)
The null was set to void instead of standart one.
Look for:
nullpo_retv(sd);
Change to:
nullpo_ret(sd);
@kyeme had the same problem, following fixed it for me (the compiler functions properly, as well as the functions ingame)
The null was set to void instead of standart one.
Look for:
nullpo_retv(sd);
Change to:
nullpo_ret(sd);
This post has been edited by Ryuuzaki on Nov 14, 2012 12:57
Hercules Elf Bot - Nov 14, 2012 13:45
Originally posted by [b]Lighta[/b]
yeah sorry I just tought of nullpo after,, you'll need some nullpo_retr(-1,sd) instead cause the nullpo_ret(sd) will return 0 wich will be understand like a good result for the command.
(well doesn't matter that much but the real fix should be -1 or so.)
thx for the report
yeah sorry I just tought of nullpo after,, you'll need some nullpo_retr(-1,sd) instead cause the nullpo_ret(sd) will return 0 wich will be understand like a good result for the command.
(well doesn't matter that much but the real fix should be -1 or so.)
thx for the report
Hercules Elf Bot - Nov 15, 2012 5:06
Originally posted by [b]kyeme[/b]
Fixed in [url="http://trac.rathena.org/changeset/16927/rathena"]r16927[/url] thanks to all!
Fixed in [url="http://trac.rathena.org/changeset/16927/rathena"]r16927[/url] thanks to all!
This post has been edited by kyeme on Nov 15, 2012 5:09
Hercules Elf Bot - Nov 15, 2012 5:35
Originally posted by [b]Cookie[/b]
Marking fixed per Ind's commit [rev=16927].
Marking fixed per Ind's commit [rev=16927].