Hairstyle - Character creation denied

Originally posted by [b]Majinken[/b]
I think this happens because the commit to fix the invalid hairstyle exploit doesn't use the max hairstyle value, but uses a hardcoded value that has to be changed if you want to use higher number hairstyles (which I believe was 18, so only 0~17 can be used on character creation.)

Originally posted by [b]Euphy[/b]
Blame: [rev=16930/trunk/src/char/char.c]

Originally posted by [b]Napster[/b]
changed to

[CODE]
if (hair_style > 27 || hair_color > 8)
[/CODE]

Originally posted by [b]Brian[/b]
Adding this for reference: ([url="http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3060"]bugreport:3060[/url]) and ([url="http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=150"]bugreport:150[/url])
-- why hairstyle/color battle configs are not used in char-server

Originally posted by [b]mkbu95[/b]
Well sorry because i tested on client I use 2012-04-10 and it's only goes from 0 to 17 despite client.conf configuration.
This has something to do with the new char creation process.

I have to know or if someone can confirm that on old char creation you can go up to battle config settings.

Originally posted by [b]cataclysmro[/b]
Im using 2012-04-10 it goes more than 17. so I have the Character Creation Denied Bug.

Originally posted by [b]kyeme[/b]
Im using 2010 - 07 - 30 and i got this msg.

Originally posted by [b]Brian[/b]
[quote name='mkbu95' timestamp='1354110975' post='15960']I have to know or if someone can confirm that on old char creation you can go up to battle config settings.[/quote]

In [rev=14604/trunk/src/char/char.c], the hair color/style checks were moved from the char creation process to pc.c [b]pc_authok()[/b].

I vote to revert [rev=16930/trunk/src/char/char.c] and mark [bug=6916] as Working As Intended. The map-server has access to the hair color/style battle configs (the char-server does not read battle configs), that's why the checks were moved to pc_authok.

Originally posted by [b]MarkZD[/b]
Brian, it'd still not fix the account in the case the char is just created and doesn't login.

It'd make the account inaccessible in that case.
A check should be put on the char displaying process, so it'd not happen anymore.

It's not so hard to do, we just need to choose if we'll transfer hair_style/hair_color to another .conf file as inter.conf or share.conf, or we'll just read if from battle/client.conf as an exception to the current design.

Originally posted by [b]Brian[/b]
[quote name='MarkZD' timestamp='1354126817' post='15966']It'd make the account inaccessible in that case.[/quote]
Oh now I see what you mean.
If they manage to create a new char with a hair color/style out of range, they will crash at the Char Select screen because their client doesn't have the haircolor/style ... and the check in pc_authok() that will fix it isn't until they connect to the map-server

Well, that's what they get for forging make_new_char packets! =p

Edit: doesn't the client have a limited range that you can scroll through with the Left, Right, Up arrows at the Create Character screen? Is that range hard-coded in the client, or based on information it receives from the char-server?

Originally posted by [b]MarkZD[/b]
[quote name='Brian' timestamp='1354127423' post='15967']
Edit: doesn't the client have a limited range that you can scroll through with the Left, Right, Up arrows at the Create Character screen? Is that range hard-coded in the client, or based on information it receives from the char-server?
[/quote]
It's hard coded in the client.

Also it can be burlated by a packet editor by some bad intentioned user, which might use it to crash the other.

Originally posted by [b]Brian[/b]
At the Char Select screen it will have the out-of-range hair, but once they connect to the map-server pc_authok() will check/fix it, so it won't affect other users right?

Originally posted by [b]MarkZD[/b]
[quote name='Brian' timestamp='1354132137' post='15971']
At the Char Select screen it will have the out-of-range hair, but once they connect to the map-server pc_authok() will check/fix it, so it won't affect other users right?
[/quote]

I meant in the case the user gets into another account.

Originally posted by [b]mkbu95[/b]
Yes, we can revert it.

There's no need for it afterwards. The only one affected by this color bug it's the player because other players can't see him with the distorted coloring. On logout-login it will be fix it like Brian said.
As by the style, at least on 2012-04-10, if you surpass the limit it will show as one of the styles which I don't recall the number and other players will see you with the default one.

Screenshot with removed "fix" and bugged hair style and hair color:
[IMG]http://i.imgur.com/Z65BX.png[/IMG]

Only tested in 2012-04-10, would be good if someone test it on Sakexe or even older RagexeRE, but since this pc_authok fix is there since some time nothing should be wrong.

Originally posted by [b]MarkZD[/b]
Fix it with the revert change.

Let's discuss about the charserver on the forum:
http://rathena.org/board/topic/74923-should-charserver-make-hair-checks/

Originally posted by [b]MarkZD[/b]
Reverted at: [url="http://trac.rathena.org/changeset/16980/rathena"]16980[/url]