Cart Termination

Originally posted by [b]malufett[/b]
due to
http://trac.rathena.org/changeset/17004/rathena

at certain point it may lost data precision..
but lets us wait for more confirmation on this..

Originally posted by [b]kyeme[/b]
Ohh isee, thanks Sir!

Originally posted by [b]MarkZD[/b]
[quote name='malufett' timestamp='1355055210' post='16268']
due to [url="http://trac.rathena.org/changeset/17004/rathena"]http://trac.rathena....t/17004/rathena[/url] at certain point it may lost data precision..but lets us wait for more confirmation on this..
[/quote]

I would to like to know where temporary int64 multiplication would lose more data than int32, since it's easy to overflow int32, it doesn't make sense, if it loss data on 64, it'd lose yet more data over 32.
100000 * 100000/1000 = 10b/1000, it'd overflow int32, but it would not on int 64 as, 10b fits in it, so after dividing by 1000, it'd become 1000000(1kk) so it uses just int32 bit.
http://upaste.me/c9a31810f222bb35

It can't lose data unless it surpass the int32 limit after the final formula, but in that case it'd lose data even if it was int32 without 64 temp var, because it'd overflow becoming negative damage.

Also, based on status and on this damage, it's very low to talk about data loss, it didn't even pass the int32 register.
Guessing high it would get 10k * 1k multiplication.

I'd like to know ur guess on irc, try going there. ;D

I tried revisions 17012 ... 17004, 17003, 16980 and .16981, on pre/re
All produced the same damage with cart termination.

[u]Could you tell your equipments, cart weight and status, kyeme?[/u]

Originally posted by [b]kyeme[/b]
[quote name='MarkZD' timestamp='1355080728' post='16278']
[quote name='malufett' timestamp='1355055210' post='16268']due to [url="http://trac.rathena.org/changeset/17004/rathena"]http://trac.rathena....t/17004/rathena[/url] at certain point it may lost data precision..but lets us wait for more confirmation on this.. [/quote]I would to like to know where temporary int64 multiplication would lose more data than int32, since it's easy to overflow int32, it doesn't make sense, if it loss data on 64, it'd lose yet more data over 32.100000 * 100000/1000 = 10b/1000, it'd overflow int32, but it would not on int 64 as, 10b fits in it, so after dividing by 1000, it'd become 1000000(1kk) so it uses just int32 bit.[url="http://upaste.me/c9a31810f222bb35"]http://upaste.me/c9a31810f222bb35[/url]It can't lose data unless it surpass the int32 limit after the final formula, but in that case it'd lose data even if it was int32 without 64 temp var, because it'd overflow becoming negative damage.Also, based on status and on this damage, it's very low to talk about data loss, it didn't even pass the int32 register.Guessing high it would get 10k * 1k multiplication.I'd like to know ur guess on irc, try going there. ;DI tried revisions 17012 ... 17004, 17003, 16980 and .16981, on pre/reAll produced the same damage with cart termination.[u]Could you tell your equipments, cart weight and status, kyeme?[/u]
[/quote]

Here's the screenshot of my test character
[attachment=4884:1.JPG]

Originally posted by [b]kyeme[/b]
Any news?

Any confirmation? Thanks :)

We sort of reverted 17004, do you still reproduce the issue?

Still reproduce in 17004 -17000
And Ive tried 16900 its working fine :)

after an hour of testing I've been able to reduce the range of possibilities o-o, its above 17000, wasnt able to pinpoint the exact revision yet

above 17005

I wasnt able to reproduce this issue, I've reverted back to 16900 and then updatd back to our latest commit, I realized a difference in RENEWAL mode (after some 17xxx revision it started to be fixed instead of random (e.g. before it was 230-200 after that revision it would be always 202), but in PRE-RE (RENEWAL DISABLED) i didnt notice any difference in damage whatsoever

[size=4][color=rgb(51,51,51)][font=helvetica, arial, sans-serif][font='lucida grande', tahoma, verdana, arial]Thank you for noticing this issue :) /thx I[/font][/font][/color][color=rgb(51,51,51)][font=helvetica, arial, sans-serif][font='lucida grande', tahoma, verdana, arial]f it's okay with you, I will make a video about this.[/font][/font][/color][/size]

alright, looking forward to watching it

PRE-RENEWAL, Same Equip and Buffs and Cart Weight @ Latest SVN and r16900 :)
[url="http://www.youtube.com/watch?feature=player_detailpage&v=YPELpjHA70k"]http://www.youtube.com/watch?feature=player_detailpage&v=YPELpjHA70k[/url]

i failed again, i am not sure what im missing mmm which renewal options you have disabled, all of them?

Yes sir. All Renewal Mechanics.

Well I tested under same settings maybe its something with the weapon calculation, whats the name of the weapon you used? (i can't read the name, i could see there was a andre card in it and that it was refined to +10)

Haha, its +10 Hurricane Fury [1] Sir. :P

WhiteSmith~ No Weapon, No Buffs, STR: 99, Cart Weight: 8,000
Latest rAthena: 336 ~ 349 damage

WhiteSmith~ No Weapon, No Buffs, STR: 99, Cart Weight: 8,000
r16900: 700 ~ 724 damage

I did some test, my screenshot is as follows:

So, let's break it down

I was using a twohand axe with custom card (ignore target's def), another custom gear, that's why my crit is 0.
nothing else.

You can see my atk is 338+582 (current rA, there is no diffs between stat Atk and weapon Atk, calculation wise speaking

so, it's 920 in total. And, I have weapon research LV10.

1. you can see it from the snap, my normal attack is 940. it fits.
2. using Cart termination with 0 weight in cart.[code=auto:0]case WS_CARTTERMINATION: i = 10 * (16 - skill_lv); if (i < 1) i = 1; //Preserve damage ratio when max cart weight is changed. if(sd && sd->cart_weight) skillratio += sd->cart_weight/i * 80000/battle_config.max_cart_weight - 100;[/code]
when weight =0, skill dmg equals to normal attack.

I'm not sure if this is intended, dmg with weight under certain value, is lower than 0 weight- -
moving on, with 8000 weight.
in the code ,weight should * 10, the skillratio = 100+80k/60-100 = 1333

the final dmg should be 920*1333%+20=12263+20=12283, it fits.

these lines are the same in rv 16900 & the latest.

So, my only guess is your battle_config.max_cart_weight changed somehow.

testing, all #define RENEWAL/RENEWAL_ASPD/ETCstuff disabled.
No Weapon, No buffs, STR 99 Cart Weight 8000, target : naked all-stat 99 lvl 99 sage.
16900: 3163 ~ 3180
Latest Hercules: 3176 ~ 3200
[hr]
Couldn't reproduce, again.

I dont know why :(
In rAthena many ppl can reproduced this problem. :( [url="http://rathena.org/board/tracker/issue-6991-cart-termination/"]http://rathena.org/board/tracker/issue-6991-cart-termination/[/url]

[quote name="Ind" timestamp="1360263881"]
testing, all #define RENEWAL/RENEWAL_ASPD/ETCstuff disabled.
No Weapon, No buffs, STR 99 Cart Weight 8000, target : naked all-stat 99 lvl 99 sage.
16900: 3163 ~ 3180
Latest Hercules: 3176 ~ 3200
[hr]
Couldn't reproduce, again.[/quote]
Ohh! [size=4][color=rgb(51,51,51)][font='lucida grande', tahoma, verdana, arial, sans-serif]same with what you have tested. [/font][/color][/size]
[size=4][color=rgb(51,51,51)][font='lucida grande', tahoma, verdana, arial, sans-serif]Champ: [/font][/color][/size]Naked no bufs vit 99
Whitesmith: Naked no bufs str 99 [size=3][background=rgb(247,247,247)]Cart Weight 8000[/background][/size]

16900: Same damage
Latest: Same damage

[b]But [size=4][color=rgb(51,51,51)][font='lucida grande', tahoma, verdana, arial, sans-serif]When the target have equipments there is a difference in damage[/font][/color][/size][/b]
Any idea? Defense problem?

hmm O_O what sort of equipment?

@kylez
No problem withi Monster.. Can you test on PVP?
r16900: Same damage @ Orc Zombie
Latest Hercules: Same damage @ Orc Zombie

@Ind
Target Equipment: +10 Feather Beret, +10 Wool Scarf, +10 Buckler, +10 Divine Cloth

I think I know why..
I always use def-bypass gears to get exact values. Easy for me to neglect that we didn't adopt NEW def formula until r17062.

So, basically every skill causes different dmgs after the major fix...

We simply focus on the skill and forget the context has changed significantly...

Already fixed this issue in @rAthena. [url="http://rathena.org/board/tracker/issue-6991-cart-termination/?st=40"]http://rathena.org/board/tracker/issue-6991-cart-termination/?st=40[/url] Waiting for merge/apply :P

ya waiting for this to be merge :) so i can download a new hercules trunk

Bump T_T

[url="http://herc.ws/board/user/514-playtester/"]Playtester[/url] have idea about this.

Bumpness~ :)

I didnt quite understand this o.o I'll ask malufett to try

T_T help~

after making a test with the given equips and condition..
I can't reproduce...

:meow:

[quote name="malufett" timestamp="1371471432"]
after making a test with the given equips and condition..
I can't reproduce...

:meow:[/quote]
The damage is not lower?

[quote name="kyeme" timestamp="1371472686"][quote name="malufett" timestamp="1371471432"]

after making a test with the given equips and condition..
I can't reproduce...

:meow:[/quote]The damage is not lower?[/quote]
yes..same with your screenies the damage is the same/relative...

:meow:

T_T can you check the changes from rAthena?
1st Fix: [url="http://trac.rathena.org/changeset/17216/rathena"]http://trac.rathena.org/changeset/17216/rathena[/url]
Final Fix: [url="http://trac.rathena.org/changeset/17222/rathena"]http://trac.rathena.org/changeset/17222/rathena[/url]

[quote name="kyeme" timestamp="1371478933"]
T_T can you check the changes from rAthena?
1st Fix: [url="http://trac.rathena.org/changeset/17216/rathena"]http://trac.rathena.org/changeset/17216/rathena[/url]
Final Fix: [url="http://trac.rathena.org/changeset/17222/rathena"]http://trac.rathena.org/changeset/17222/rathena[/url][/quote]
still won't work for you?

:meow:

Working fine @rathena.

Dont know why cant reproduce this bug T_T

Bump~

I already updated the formula..kindly update and try again..salamat..

:meow:

Still the same T_T

ok found out what the problem is..I'll commit it tomorrow(I'm so sleepy and tired :lol: )..I promise..hehehehe..:D
so consider it now to be fixed...

:meow:

Yehey! Thank you :)

Fixed @ ce5085a000ee7babb05b9e6a86410e13a75d7606

:meow:

Thank you, its working fine now :)

After this [url="https://github.com/HerculesWS/Hercules/commit/c1401ff17207e9c2aac551066f0bd90928dd90bb"]commit[/url], the CT damage [color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]was weakened again. T_T[/size][/font][/color]

Confirmed, the reductions are being applied twice on every hit (added debug messages to confirm).

hehehe..my bad...this should be final : [url="https://github.com/HerculesWS/Hercules/commit/8f1bd982faf74fdb61126e97c75905976201cca5"]https://github.com/HerculesWS/Hercules/commit/8f1bd982faf74fdb61126e97c75905976201cca5[/url]

:meow:

[quote name="malufett" timestamp="1372691100"]
hehehe..my bad...this should be final : [url="https://github.com/HerculesWS/Hercules/commit/8f1bd982faf74fdb61126e97c75905976201cca5"]https://github.com/HerculesWS/Hercules/commit/8f1bd982faf74fdb61126e97c75905976201cca5[/url]

:meow:[/quote]
THANK YOU!! :)