HP/SP DRAIN OVERFLOW
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6995
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Dec 9, 2012 21:50
Last Post
Hercules Elf Bot
Dec 12, 2012 3:25
Confirmation
Hercules Elf Bot - Dec 9, 2012 21:50
Originally posted by [b]KyleZ[/b]
[color=rgb(40,40,40)][background=rgb(255,255,255)]revision[/background][/color]: r17004
First of all, pls allow me to quote the update message of r17004:
[left][background=rgb(255,255,255)]Added safer multiplication in battle formulas to prevent int32 from overflowing when High damage is dealt. [/background][/left]
It was quite thorough, I have to say. But I guess it didn't cover the HP/SP drain part. And my test proved so.
Instant death occurs whenever damage output exceeds 2^31/100(INT_MAX/100,roughly 20 mil.)
right. I was using a custom gear script: bonus2 bHpDrainRate,1000,100.
This is my first post here. Look forward to your reply. thx to you all.
[color=rgb(40,40,40)][background=rgb(255,255,255)]revision[/background][/color]: r17004
First of all, pls allow me to quote the update message of r17004:
[left][background=rgb(255,255,255)]Added safer multiplication in battle formulas to prevent int32 from overflowing when High damage is dealt. [/background][/left]
It was quite thorough, I have to say. But I guess it didn't cover the HP/SP drain part. And my test proved so.
Instant death occurs whenever damage output exceeds 2^31/100(INT_MAX/100,roughly 20 mil.)
right. I was using a custom gear script: bonus2 bHpDrainRate,1000,100.
This is my first post here. Look forward to your reply. thx to you all.
This post has been edited by KyleZ on Dec 9, 2012 22:14
Hercules Elf Bot - Dec 9, 2012 22:38
Originally posted by [b]MarkZD[/b]
[quote]Added safer multiplication in [b]battle formulas[/b] to prevent int32 from overflowing when High damage is dealt.[/quote]
Yep, I just implemented it in battle.c as I mentioned here:
http://rathena.org/board/topic/75131-no-damage-bug-overflow-behavior/
I talked to lighta, even before creating the topic so I told I'd take look around status and etc later.
It'll be add, just calm down. ;D
[quote]Added safer multiplication in [b]battle formulas[/b] to prevent int32 from overflowing when High damage is dealt.[/quote]
Yep, I just implemented it in battle.c as I mentioned here:
http://rathena.org/board/topic/75131-no-damage-bug-overflow-behavior/
I talked to lighta, even before creating the topic so I told I'd take look around status and etc later.
It'll be add, just calm down. ;D
This post has been edited by MarkZD on Dec 9, 2012 22:45
Hercules Elf Bot - Dec 9, 2012 22:57
Originally posted by [b]KyleZ[/b]
Glad to know it's in progress.
I guess I just caught it in an awkward moment,
It's 7AM here in Beijing, well I guess you guys are working pretty late. I appreciate your quick reply.
Glad to know it's in progress.
I guess I just caught it in an awkward moment,
It's 7AM here in Beijing, well I guess you guys are working pretty late. I appreciate your quick reply.
Hercules Elf Bot - Dec 12, 2012 0:24
Originally posted by [b]MarkZD[/b]
Should be fixed at: [url="http://trac.rathena.org/changeset/17017/rathena"]17017[/url]
Should be fixed at: [url="http://trac.rathena.org/changeset/17017/rathena"]17017[/url]
Hercules Elf Bot - Dec 12, 2012 2:59
Originally posted by [b]Akinari[/b]
All players ended up with next to no HP and SP after this revision.
All players ended up with next to no HP and SP after this revision.
Hercules Elf Bot - Dec 12, 2012 3:25
Originally posted by [b]MarkZD[/b]
[quote name='Akinari' timestamp='1355281150' post='16334']
All players ended up with next to no HP and SP after this revision.
[/quote]
Thank you, fixed: [url="http://trac.rathena.org/changeset/17018/rathena"]17018[/url]
[quote name='Akinari' timestamp='1355281150' post='16334']
All players ended up with next to no HP and SP after this revision.
[/quote]
Thank you, fixed: [url="http://trac.rathena.org/changeset/17018/rathena"]17018[/url]