Issue information

Issue ID
#6997
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Dec 10, 2012 19:10
Last Post
Hercules Elf Bot
Dec 16, 2012 15:13
Confirmation
Yes (3)
No (0)

Hercules Elf Bot - Dec 10, 2012 19:10

Originally posted by [b]AnnieRuru[/b]
http://rathena.org/board/topic/75440-novice-ground-script-re/
ok ... another one


take mage quest for example
after completing the quest
[code] else if(checkquest(7124,HUNTING) != -1 && checkquest(7124,HUNTING) != 2) {
mes "[Mage Guide]";
mes "The quest is that you have to hunt Lunatics and bring 5 clovers.";
close2;
}[/code]this part is being repeated
because I have debugged it with (checkquest(7124,HUNTING) and (checkquest(7124))
(checkquest(7124,HUNTING) return 0
(checkquest(7124)) return 2

it seems like our script engine, after done the quest, the HUNTING is automatically set into 0

I think to fix this script properly, this part should be change into
[code]else if( (checkquest(7124) == 1 ) {[/code]means the quest is taken ...


the same thing under case 3:
[codebox] if(checkquest(7124,HUNTING) != -1 && checkquest(7124,HUNTING) != 2) {
mes "[Mage Guide]";
mes "The quest is that you have to hunt Lunatics and bring 5 clovers.";
close;
}
else if(checkquest(7124) == 2) {
mes "[Mage Guide]";
mes "You have already completed the quest.";
mes "Once you enter the main world, you can get various exciting quests there!";
next;
mes "[Mage Guide]";
mes "This should be enough for your training.";
close;
}[/codebox]I changed into
[codebox] if(checkquest(7124) == 2) {
mes "[Mage Guide]";
mes "You have already completed the quest.";
mes "Once you enter the main world, you can get various exciting quests there!";
next;
mes "[Mage Guide]";
mes "This should be enough for your training.";
close;
}
else if(checkquest(7124) == 1) {
mes "[Mage Guide]";
mes "The quest is that you have to hunt Lunatics and bring 5 clovers.";
close;
}[/codebox]

not very sure about this method, you guys go settle this correctly

This post has been edited by AnnieRuru on Dec 10, 2012 19:15

Hercules Elf Bot - Dec 16, 2012 15:13

Originally posted by [b]Joseph[/b]
Thanks Annie!
Fixed in [rev=17025].