Issue information

Issue ID
#7016
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Dec 17, 2012 23:28
Last Post
Mysterious
Jun 7, 2013 19:20
Confirmation
N/A

Hercules Elf Bot - Dec 17, 2012 23:28

Originally posted by [b]Peopleperson49[/b]
I don't think the the skill_db is behaving properly. I know this is based on a customization which is not supproted as a bug, but I believe that modifying this file should make the skill affect all enemies within a 3 square radius around the target enemy. I'm not a 100% on this but I will give an example. I edited mammonite to do splash damage instead of a single target damage (as shown below) following the discription within the document. I also did a search of the src files for anything that might conflict this and found nothing.

Peopleperson49

As described in the document.
[CODE]
// 06 nk (skill damage properties):
// 0x01 - No damage skill
// 0x02 - Has splash area
// 0x04 - Damage should be split among targets
// 0x08 - Skill ignores caster's % damage cards (misc type always ignores)
// 0x10 - Skill ignores elemental adjustments
// 0x20 - Skill ignores target's defense (misc type always ignores)
// 0x40 - Skill ignores target's flee (magic type always ignores)
// 0x80 - Skill ignores target's def cards
// 07 splash/effect range (-1 for screen-wide)
[/CODE]

Default version:
[CODE]
42,-1,6,1,-1,0,0,10,1,no,0,0,0,weapon,0, MC_MAMMONITE,Mammonite
[/CODE]

My modified version:
[CODE]
42,-1,6,1,-1,0x2,3,10,1,no,0,0,0,weapon,1, MC_MAMMONITE,Mammonite
[/CODE]

Hercules Elf Bot - Dec 18, 2012 10:11

Originally posted by [b]malufett[/b]
actually
[CODE]0x02 - Has splash area[/CODE]
need a src modification..
and
[CODE]0x04 - Damage should be split among targets[/CODE]
is associated with 0x02 without it this will not work..

this is suppose to be in Documentation..or let us see what other dev decision if need to resolve this or fix its docu...
but for me stay as is and fix docu..since not only this option needs a src mod when changed...:)


:meow:

Hercules Elf Bot - Dec 18, 2012 11:48

Originally posted by [b]Peopleperson49[/b]
Thanks for the input. It seems like it would be more work to fix the src files, but I doubt it would not be in the documation in the first place if it wasn't intended to behave in that manor. Removing that takes away flexability from users and will lead to more source requests in the future when they are not necessary.

Peopleperson49

This post has been edited by Peopleperson49 on Dec 18, 2012 11:50

Hercules Elf Bot - Dec 18, 2012 14:30

Originally posted by [b]malufett[/b]
well..that could make the source complicated or let us say added functions where in the first place its not needed..
imagine all skills will be set as compatible as ground skills, self target skill, enemy target skills, splash and etc..well in the first place this db are set for other options/modifications other than official behaviors...I hope get my point..:)

:meow:

Ind - Jan 28, 2013 19:15

I agree with malufett this is a documentation issue. Moving.

Mysterious - Jun 7, 2013 19:20

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/3e413d7af0c3cccf2b069fd0263af3eae87f28b8"]3e413d7[/url] - since it was just the document issue.

This post has been edited by Mysterious on Jun 7, 2013 19:20