It should re-check status change and/or scripts upon unequip

Issue information

Issue ID

#7084

Status

Confirmed

Severity

None

Started

KyleZ

Feb 18, 2013 18:36

Last Post

Ind

Feb 20, 2013 0:11

Confirmation

N/A

KyleZ - Feb 18, 2013 18:36

Similar to recent rA fixed bug: [url="http://rathena.org/board/tracker/issue-7174-item-combo-not-working-properly/"]http://rathena.org/board/tracker/issue-7174-item-combo-not-working-properly/[/url]

Say you have Eddga Card in your boots, and another custom gear that also grants endure.

Equip script: { sc_start4 SC_ENDURE,60000,10,0,0,1; }
unequip script: { sc_end SC_ENDURE; }

When you unequip this custom gear, endure status disappears even though Eddga boots are still on.

if you can think of any other related issues, please fix them together :P

kyeme - Feb 18, 2013 18:46

Same old issue (fixed) [url="http://rathena.org/board/tracker/issue-6883-sc-intravision-2/?gopid=15563#entry15563"]http://rathena.org/board/tracker/issue-6883-sc-intravision-2/?gopid=15563#entry15563[/url] :)

Ind - Feb 19, 2013 0:56

this is complicateeed o__o /hmm a universal way to save this would be to mark a status change with its origin e.g. sc_endure came from item id <any id> so when doing something like sc_end it'll check if the sc_end origin is the same as the status it wants to delete o__o~ but even so we can get problems hmmmmm i gotta sleep on the idea

malufett - Feb 19, 2013 11:00

[quote]
this is complicateeed o__o /hmm a universal way to save this would be to mark a status change with its origin e.g. sc_endure came from item id <any id> so when doing something like sc_end it'll check if the sc_end origin is the same as the status it wants to delete o__o~ but even so we can get problems hmmmmm i gotta sleep on the idea[/quote]

what if something like...when unequiped re-run the script for those items left...

:meow:

Ind - Feb 20, 2013 0:11

[quote name="malufett" timestamp="1361271638"]

[quote]
this is complicateeed o__o /hmm a universal way to save this would be to mark a status change with its origin e.g. sc_endure came from item id <any id> so when doing something like sc_end it'll check if the sc_end origin is the same as the status it wants to delete o__o~ but even so we can get problems hmmmmm i gotta sleep on the idea[/quote]what if something like...when unequiped re-run the script for those items left...

:meow:

[/quote]it'd create a sort of exploit i think...by rerunning the on_equip stuff you'd be restarting bonuses while not really re-equipping the item
e.g.
a item that reduces your sp by 500 when you equip it would reduce your sp again when unequipping anything