Potato - Feb 24, 2013 1:29
stopped working at the current revision. not really sure if its just me can anyone verify?
Tested on
Eden Officer Warper
and a Custom Npc that uses warp and close2
Kafra works fine though
Ind - Feb 24, 2013 1:48
I'm not yet aware of the reason behind this change, but if you need a quick workaround till its discovered in script.c find[code=auto:0]
BUILDIN_FUNC(close2)
{
TBL_PC* sd;
sd = script_rid2sd(st);
if( sd == NULL )
return 0;
st->state = STOP;
clif_scriptclose(sd, st->oid);
return 0;
}[/code]and change to[code=auto:0]
BUILDIN_FUNC(close2)
{
TBL_PC* sd;
sd = script_rid2sd(st);
if( sd == NULL )
return 0;
st->state = END;
clif_scriptclose(sd, st->oid);
return 0;
}[/code]
Ind - Feb 24, 2013 4:13
Temporarily fixed in [url="https://github.com/HerculesWS/Hercules/commit/d4582e286fa64f469112ff76ecae672ce7c57aa5"]https://github.com/HerculesWS/Hercules/commit/d4582e286fa64f469112ff76ecae672ce7c57aa5[/url]
malufett - Feb 24, 2013 11:24
ok I'll remake it...:)
:meow:
malufett - Feb 24, 2013 12:07
Fixed @ [url="https://github.com/HerculesWS/Hercules/commit/137cc4396d651798a95641d529955845a25a56e1"]https://github.com/HerculesWS/Hercules/commit/137cc4396d651798a95641d529955845a25a56e1[/url]
:meow:
exneval - Feb 27, 2013 17:39
After this update, custom npc script like healer/breeder, make you stuck 4ever
Ind - Feb 27, 2013 20:01
[quote name="exneval" timestamp="1361986747"]
After this update, custom npc script like healer/breeder, make you stuck 4ever[/quote]this is a script bug not a core bug, the npc is using 'close' instead of 'end'
This post has been edited by
Ind
on Feb 27, 2013 20:01
exneval - Feb 28, 2013 0:23
so what the doc says is not true
[quote]
This command will create a 'close' button in the message window for the invoking
character. [color=#ff0000]If no window is currently on screen, the script execution will end[/color]. This is one
of the ways to end a speech from an NPC. Once the button is clicked, the NPC
script execution will end, and the message box will disappear.[/quote]
malufett - Feb 28, 2013 8:11
actually we are going to change that too..
cause also in official they use end to terminate the script and close to only show the close button...
:meow: