Issue information

Issue ID
#7133
Status
Fixed
Severity
None
Started
Zopokx
Mar 21, 2013 0:56
Last Post
Zopokx
Mar 29, 2013 18:14
Confirmation
N/A

Zopokx - Mar 21, 2013 0:56

With a new and fresh clone of the git repository, using 20130418 client, I can't see the cart that I have just rented with the Kafra, neither access to the cart storage (ALT+W or the button on the Info window), though the script command ( checkcart() ) say that I have already one and Vending skill can be used.
It is just me?

This issue is gonna drive me mad. I have tried with several server configurations without any success. It is a bug?

Mysterious - Mar 21, 2013 3:55

I hope you mean a 2012-04-18 client... :P.

Is there anything fishy in the Map server? Anything being spat out? Im not sure if it's the source's fault or client :S Because I know when I had this client, I didn't have this problem, so it could[i][b] possibly[/b][/i] be the source. Don't quote me on this since I'm not a source expert :<

Ind - Mar 21, 2013 5:26

I use the same client as you and it works for me, might be something on your end o_o` im not sure what...though

Zopokx - Mar 21, 2013 10:18

[quote name="Mysterious" timestamp="1363838144"]
I hope you mean a 2012-04-18 client... :P.

Is there anything fishy in the Map server? Anything being spat out? Im not sure if it's the source's fault or client :S Because I know when I had this client, I didn't have this problem, so it could[i][b] possibly[/b][/i] be the source. Don't quote me on this since I'm not a source expert :<[/quote]

Oh yeah, of course, I meant a 2012 client :P


No errors, no warnings (neither compilation or server execution)... nothing.

Frost - Mar 21, 2013 12:08

i think the problem is in the client itself, try to make a [b]GRF[/b]. if the problem still exists, you must diff fresh client again. or try to use other client dates, or patch your kRO upto latest.

Zopokx - Mar 21, 2013 12:28

[quote name="Frost" timestamp="1363867739"]
i think the problem is in the client itself, try to make a [b]GRF[/b]. if the problem still exists, you must diff fresh client again. or try to use other client dates, or patch your kRO upto latest.[/quote]


It's funny, because some days ago I could see the cart. I remember because I was checking something related with 'cell_novending'.

I have also just tried with the Judas client release, without any modification (only clientinfo.xml, as it is logic) and the issue persists...

Could this be related to have kRO updated? (with an update failure, I mean)
I will keep on trying to discard options.

Zopokx - Mar 21, 2013 13:24

Well, just tested with a fresh rAthena (r17204) and both the Judas's clean client and mine's works perfectly.

It has to be Hercules emulator, but I don't know why this issue only seems to be happening to me...

Ind - Mar 21, 2013 23:48

it might then be a specific setting that you used on hercules that might be broken (and affected the display), not the feature itself (as i said i use the same client and it works), rathena has nothing different regarding the carts compared to hercules (i wrote the new cart code rathena uses, its the same used on hercules)

This post has been edited by Ind on Mar 21, 2013 23:49

kyeme - Mar 22, 2013 11:07

Hi Zopok, what is your job? Hmm im super novice and icant see my cart O_O wa

Zopokx - Mar 22, 2013 14:03

[quote name="kyeme" timestamp="1363950461"]
Hi Zopok, what is your job? Hmm im super novice and icant see my cart O_O wa[/quote]


I have tried only with merchant, alchemist, creator and bs. It doesn't matter what job you are, I think it is a cart itself bug.

AFAIK, if you already have a cart, it will be displayed correctly, The problem comes when you try to get a new cart. No cart and no cart storage (Alt+W). By the other way, if you already have a cart, you can't take it off.

That was my experience. On the advice of Ind, I tried with a 'no configurated' fresh emulator (only IPs and ports) and didn't work either. This is very frustrating.

Zopokx - Mar 22, 2013 14:28

Could this: [url="http://herc.ws/board/topic/289-2013-ragexe-area/#entry1767"]http://herc.ws/board/topic/289-2013-ragexe-area/#entry1767[/url] be related to this issue?

kyeme - Mar 22, 2013 16:06

[s]In @cart carts irs working fine but in setcart commands (for Super Novice) cart is not working :blink:[/s]
my Script problem, sorry

This post has been edited by kyeme on Mar 25, 2013 23:15

Zopokx - Mar 22, 2013 21:01

Some news about this:

- In past revision 5b1fee9ef5 ([url="https://github.com/HerculesWS/Hercules/commit/5b1fee9ef54dbfc27fef5f6125a678fa88eba1be"]https://github.com/HerculesWS/Hercules/commit/5b1fee9ef54dbfc27fef5f6125a678fa88eba1be[/url]) it worked correctly.
- In rev. 7032044f54 it stops working. (I couldn't test previous one, 3b89a135dc, because when trying to connect is always saying 'Server Closed' xDD) Neither 'setcart' nor '@cart'.

This post has been edited by Zopokx on Mar 28, 2013 17:05

malufett - Mar 23, 2013 15:35

are you using windows? same here..I confirmed...
and my IDE goes weird in script.c NEW_CARTS is not define but when I look at atcommand it is defined...

it seems that the console input is not compatible/stable in windows environment..so bad..:(

:meow:

This post has been edited by malufett on Mar 23, 2013 15:45

Zopokx - Mar 23, 2013 17:40

Thankyou, malufett. I was thinking that I was crazy xD

BTW, I'm using Windows 7 (clientside) and a Squeeze Debian as server.

This post has been edited by Zopokx on Mar 23, 2013 17:42

benzanaz - Mar 25, 2013 16:07

+1 agree confrigm by me (ragexere 20111025)

Ind - Mar 26, 2013 2:19

[quote name="malufett" timestamp="1364052907"]
it seems that the console input is not compatible/stable in windows environment..so bad.. :([/quote]what made you think its console input?

malufett - Mar 28, 2013 16:32

[quote]
what made you think its console input?[/quote]
when I remove/revert it it works fine...and I don't know how this happen... :D

here is the root cause even if '#define PACKETVER 20120418'
[img]http://i49.tinypic.com/2egfy8o.jpg[/img]

at atcommands.c view NEW_CARTS is defined while in script.c its undefined...

:meow:

This post has been edited by malufett on Mar 29, 2013 14:03

Ind - Mar 29, 2013 17:05

[quote name="malufett" timestamp="1364488334"]

[quote]
what made you think its console input?[/quote]when I remove/revert it it works fine...and I don't know how this happen... :D

here is the root cause even if '#define PACKETVER 20120418'
[img]http://i49.tinypic.com/2egfy8o.jpg[/img]

at atcommands.c view NEW_CARTS is defined while in script.c its undefined...

:meow:

[/quote]oooh i think i know why .-. may be the #include order (in the console_input stuff i think i might have made it include it before mmo.h so in some files that inherit core/console stuff the const.h was parsed before mmo.h having the constants go insane)...does it fixes if in src/common/core.h you add #include "../common/mmo.h" before the #include "../config/core.h"?

Ind - Mar 29, 2013 17:15

yup confirmed, this is the issue +__+ will commit the fix, thank you all specially malufett <3

Ind - Mar 29, 2013 17:19

[url="https://github.com/HerculesWS/Hercules/commit/6ee3d513e882a76aa044f68bc52f2fd8010d8b84"]https://github.com/HerculesWS/Hercules/commit/6ee3d513e882a76aa044f68bc52f2fd8010d8b84[/url]

malufett - Mar 29, 2013 18:03

wow...it works perfectly...
I manage to follow the file directives to fixed whats missing but I failed..hahaha

:meow:

Zopokx - Mar 29, 2013 18:14

WoW, thank you guys for your effort! :D