Zopokx - Apr 1, 2013 1:59
If you use @refresh when you have your BuyingStore open, it will be immediately closed, unlike it happens with a regular vending shop.
I haven't tested it with @autotrade.
Ind - Apr 1, 2013 20:50
Fixed in [url="https://github.com/HerculesWS/Hercules/commit/6990db954cf46c51e9f522865a03d5d3b64cb46a"]https://github.com/HerculesWS/Hercules/commit/6990db954cf46c51e9f522865a03d5d3b64cb46a[/url]
Thank you again
Ind - Apr 1, 2013 21:26
actually, not fixed yet. found a bug in the bug o__o XDD paradox
Zopokx - Apr 1, 2013 21:30
[quote name="Ind" timestamp="1364851576"]
actually, not fixed yet. found a bug in the bug o__o XDD paradox[/quote]
xDDD I'm laughing so hard right now because of you.
BTW, I hope this new bug^2 won't be too much difficult to fix :)
Ind - Apr 1, 2013 21:50
The problem is that creating it would crash the client (the client is poorly coded at this I guess, trying to tell it to output the window again makes it crash), I tried to get around the issue in many ways e.g. by telling the client the character buying store closed, and then trying to send it to create a new one with same items as the previous -- it would still crash. Had to revert in [url="https://github.com/HerculesWS/Hercules/commit/a3d41f93a26078d4a2586efae168e079f59fac6e"]https://github.com/HerculesWS/Hercules/commit/a3d41f93a26078d4a2586efae168e079f59fac6e[/url]
Zopokx - Apr 1, 2013 22:06
No problem if this is fault of the damn client (I dream with an open sourced new one :P)
But it is neccesary to know this issue, mainly because possible usage of @refreshall.
Ind - Apr 1, 2013 22:36
huum fair point o-o didn't think about @refreshall -- whats the point of that anyway? -- uhm depending on its use we could add a check on refreshall not to refresh people with buyingstores
Zopokx - Apr 1, 2013 23:01
Maybe in a event, a GM decide to use @refreshall and every buyingstore in game stops suddenly. (In fact, that was my concern about in the beginning...)
As I said before, I didn't tested with @autotrade (BuyingStore works with @at, isn't it?).
Ind - Apr 1, 2013 23:54
it will close the ones with autotrade too i think
Zopokx - May 22, 2013 18:44
This issue's state should be changed, shouldn't it?