Issue information

Issue ID
#7149
Status
Fixed
Severity
None
Started
mkbu95
Apr 5, 2013 22:56
Last Post
Ind
Apr 6, 2013 23:57
Confirmation
N/A

mkbu95 - Apr 5, 2013 22:56

Hello all !

Planning on coming back mid April :)

But let's cut to it:

There is an error (I don't know what exactly) on atcommand.c while compiling with clang (tested version 1.x and on version 3.2):[code=auto:0] bj_sql/atcommand.o: In function `atcommand_channel': atcommand.c:8042: undefined reference to `atcmd_channel_help' clang: error: linker command failed with exit code 1 (use -v to see invocation[/code]The line in my files is:[code=auto:0]atcmd_channel_help(fd,command,( raChSys.allow_user_channel_creation || pc_has_permission(sd, PC_PERM_CHANNEL_ADMIN) ));[/code]---
And the problem on Channel System.
Also I found this reply in rathena by some guy, and another confirming it:
[url="http://rathena.org/board/topic/80999-r17228-channel-system-replacement-for-main/?p=192015"]http://rathena.org/board/topic/80999-r17228-channel-system-replacement-for-main/?p=192015[/url]
and
[url="http://rathena.org/board/topic/80999-r17228-channel-system-replacement-for-main/?p=192016"]http://rathena.org/board/topic/80999-r17228-channel-system-replacement-for-main/?p=192016[/url][code=auto:0] for( user = dbi_first(iter); dbi_exists(iter); user = dbi_next(iter) ) { if( user->fd == sd->fd ) continue; WFIFOHEAD(user->fd,msg_len + 12); memcpy(WFIFOP(user->fd,0), WFIFOP(sd->fd,0), msg_len + 12); WFIFOSET(user->fd, msg_len + 12); }[/code]Giving a fast look can't user->fd log out, warp or something in the meantime or just when he logs out the channel system don't remove him.

That's it :-D
cya

Ind - Apr 6, 2013 1:25

the wfifo error was fixed in
[url="https://github.com/HerculesWS/Hercules/commit/daccb6e3ec7f7301cb67e2aafa4ff8ecc7393af0"]https://github.com/HerculesWS/Hercules/commit/daccb6e3ec7f7301cb67e2aafa4ff8ecc7393af0[/url]

Ind - Apr 6, 2013 23:57

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/16dfef6c5fe28d9008a304d4f5f650d7ac1dfbcd"]https://github.com/HerculesWS/Hercules/commit/16dfef6c5fe28d9008a304d4f5f650d7ac1dfbcd[/url]
Thank you