Issue information

Issue ID
#7163
Status
Working as Intended
Severity
None
Started
Ryuuzaki
Apr 12, 2013 22:37
Last Post
Judas
Apr 17, 2013 13:32
Confirmation
N/A

Ryuuzaki - Apr 12, 2013 22:37

As topic name states, the weapon atk is falsely added to the status atk in the status window. This bug has been around on rathena already, just noticed it when i was testing some weapons.

[b]Reproduce:[/b]

Take any class (in my test is was a monk)
@item chain
equip the chain and look at your status window

[b]Official servers:[/b]

It shows status_atk + 84 (chain atk)

[b]Hercules / RA:[/b]

It shows (status_atk+84) + 0

Thanks for taking a look into it!

Judas - Apr 13, 2013 14:49

it's been around for a long time then O.o
I think this includes pc.c, battle.c probably

Ryuuzaki - Apr 13, 2013 15:51

Was there on rA already yes. The damage itself is calculated properly as far as i can see, probably just a clif issue.

Ryuuzaki - Apr 16, 2013 22:20

Shoving that issue up so it won't go down.

Judas - Apr 17, 2013 4:08

can you post a picture of what it looks on hercules?

Ind - Apr 17, 2013 6:00

What controls this is on pc.h[code=auto:0] #ifdef RENEWAL #define pc_leftside_atk(sd) ((sd)->battle_status.batk) #define pc_rightside_atk(sd) ((sd)->battle_status.rhw.atk + (sd)->battle_status.lhw.atk + (sd)->battle_status.rhw.atk2 + (sd)->battle_status.lhw.atk2) #else #define pc_leftside_atk(sd) ((sd)->battle_status.batk + (sd)->battle_status.rhw.atk + (sd)->battle_status.lhw.atk) #define pc_rightside_atk(sd) ((sd)->battle_status.rhw.atk2 + (sd)->battle_status.lhw.atk2) #endif [/code]I find it curious though o__O is it reversed or it works like you claim on renewal as well?

Ryuuzaki - Apr 17, 2013 9:07

*naked*


[attachment=169:screenSakray002.jpg]


*weapon on*

[attachment=170:screenSakray004.jpg]


*impositio manus active (works properly!)

[attachment=171:screenSakray005.jpg]

Ryuuzaki - Apr 17, 2013 9:18

Guess i have to admit i had in differently in mind, checking on iRO classic, asking old friends and researching for some time.

Don't know why i thought the watk is shown righthand, maybe because the other way around it's not logical for and additionally i played renewal for too long xD.


[b]TLDR: Forget the report, i'm getting old <.<"[/b]

Judas - Apr 17, 2013 11:32

so it's working as intended correct?

Ryuuzaki - Apr 17, 2013 11:57

Yeah it is working as intended *takes a breath from oxygen machine* xD