Issue information

Issue ID
#7181
Status
Fixed
Severity
None
Started
mybitch
Apr 23, 2013 3:21
Last Post
kyeme
Dec 19, 2013 10:18
Confirmation
Yes (1)
No (0)

mybitch - Apr 23, 2013 3:21

After clicking buy at cash shop using 2012-07-16 Ragexe. It successfully buys the item [size=6][b]BUT [/b][size=4]doesn't show any notice that you have obtained it. Also the cash doesn't change. Only by reopening the cash shop - the cash (placed on the bottom left of the window) changes. Also you will receive the item after reconnecting..[/size][/size]

See Attached photo.[img]http://sphotos-b.ak.fbcdn.net/hphotos-ak-prn1/936714_176289809193738_652846082_n.jpg[/img]

[img]http://sphotos-h.ak.fbcdn.net/hphotos-ak-prn1/936102_176289819193737_1942244137_n.jpg[/img]

[img]http://sphotos-c.ak.fbcdn.net/hphotos-ak-ash3/28013_176289862527066_344588962_n.jpg[/img]

[img]http://sphotos-e.ak.fbcdn.net/hphotos-ak-prn1/32312_176289849193734_46726300_n.jpg[/img]

[img]http://sphotos-a.ak.fbcdn.net/hphotos-ak-ash4/378336_176289875860398_681982455_n.jpg[/img]
[size=5][b]THIS IS WHAT HAPPENS AFTER BUYING THE ITEM. NO ITEM ADDED[/b][/size]

[img]http://sphotos-g.ak.fbcdn.net/hphotos-ak-ash3/525317_176289879193731_1832303861_n.jpg[/img]
[size=5]THIS IS THE PART WHEN YOU NEED TO REOPEN THE CASH SHOP TO SEE THE CASH POINTS CHANGING[/size]

[img]http://sphotos-h.ak.fbcdn.net/hphotos-ak-prn1/934670_176289899193729_2041297312_n.jpg[/img]
[b][size=5]THIS IS THE PART WHEN YOU RELOG TO YOUR CHARACTER. THE ITEM IS ADDED[/size][/b]

How to reproduce:
1. Recompile server using 2012-07-16
2. Add this to the packets.h under 2012-06-18 since it uses the same packet.[code=auto:0] packet(0x0844,2,clif->pCashShopOpen,0);/* tell server cashshop window is being open */ packet(0x084a,2,clif->pCashShopClose,0);/* tell server cashshop window is being closed */ packet(0x08c9,2,clif->pCashShopSchedule,0); packet(0x0848,-1,clif->pCashShopBuy,0); [/code]
3. Run the server and client
4. Buy any item.. (No notice and cash points didn't changed)
5. Reopen cash shop (Cash Points changed)
6. View inventory, no items added
7. Relog see inventory

This post has been edited by mybitch on Apr 23, 2013 3:27

Judas - Apr 23, 2013 3:40

I haven't tried 07-16 yet, but I'll confirm that it's working on 2013 client.
When you buy the item cash shop points get deducted and the item is in the iventory

mybitch - Apr 23, 2013 3:41

[quote name="Judas" timestamp="1366688402"]
I haven't tried 07-16 yet, but I'll confirm that it's working on 2013 client.
When you buy the item cash shop points get deducted and the item is in the iventory[/quote]
I too can confirm that its working on 2013 client without any problems but client before it, it doesnt work as intended :D

kyeme - Apr 23, 2013 3:43

I can confirm this :)

kyeme - Apr 23, 2013 3:48

I think not only in using Cash Shop, also in using @item or buying @ npc

mybitch - Apr 23, 2013 3:50

[quote name="kyeme" timestamp="1366688903"]
I think not only in using Cash Shop, also in using @item or buying @ npc[/quote]

Didn't try thou @ npc.. but only in cash shop.

Judas - Apr 23, 2013 3:51

O.o @item isn't working? ^kyeme?


Confirmed that doesn't work for 2012-07-16, do you think ones earlier than this also have a problem?

I'm stumped on why it isn't working, since it uses the same packets =x

This post has been edited by Judas on Apr 23, 2013 4:07

bgamez23 - Apr 23, 2013 7:46

and also this is not working for 2012-06-04aRagexe.

the item purchased is missing but the cash points was decreased.

malufett - Apr 23, 2013 13:37

hmm..it seems we need a major backward compability check..since we used 2013 client in implementing...

:meow:

bgamez23 - Apr 24, 2013 19:04

this is already fix.
[url="http://herc.ws/board/tracker/issue-7182-item-delay-issue/"]http://herc.ws/board/tracker/issue-7182-item-delay-issue/[/url]

[color=rgb(34,89,133)][font=helvetica, arial, sans-serif][size=3][right][url="http://herc.ws/board/user/1-ind/"]Ind[/url] said [/right][/size][/font][/color][color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Its a typo in the date.[/size][/font][/color]
[url="https://github.com/HerculesWS/Hercules/commit/018680a339e96fe28e115f94a9eb0f0816bd72c4"]https://github.com/HerculesWS/Hercules/commit/018680a339e96fe28e115f94a9eb0f0816bd72c4[/url]

kyeme - Dec 19, 2013 10:18

[quote name="bgamez23" timestamp="1366830294"]
this is already fix.
[url="http://herc.ws/board/tracker/issue-7182-item-delay-issue/"]http://herc.ws/board/tracker/issue-7182-item-delay-issue/[/url]

[url="http://herc.ws/board/user/1-ind/"]Ind[/url] said[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Its a typo in the date.[/size][/font][/color]
[url="https://github.com/HerculesWS/Hercules/commit/018680a339e96fe28e115f94a9eb0f0816bd72c4"]https://github.com/HerculesWS/Hercules/commit/018680a339e96fe28e115f94a9eb0f0816bd72c4[/url][/quote]
Thanks for the update
Marking as Fixed