Issue information

Issue ID
#7183
Status
Fixed
Severity
None
Started
bgamez23
Apr 23, 2013 15:04
Last Post
Mysterious
Jun 11, 2013 19:14
Confirmation
N/A

bgamez23 - Apr 23, 2013 15:04

this is happen when i try to move to the mvp and use heal.

how to produce.
just take a heal at the npc, then try to move, or use some skill the problem will occur.

Any work in progress (NPC dialog, manufactoring,,,) quit and try again.

you must relogin to remove that problem.

[img]http://s15.postimg.org/bjly86iu3/screen_Hercules_Test003.jpg[/img]
[img]http://s16.postimg.org/xw19bbrvp/screen_Hercules_Test004.jpg[/img]
[img]http://s15.postimg.org/pslkq8xcr/screen_Hercules_Test005.jpg[/img]
[img]http://s23.postimg.org/g75ic9awb/screen_Hercules_Test006.jpg[/img]

bgamez23 - Apr 24, 2013 19:02

bump for this. still having a problem for these on latest revision.

Ind - Apr 24, 2013 19:54

can you show the script?

bgamez23 - Apr 24, 2013 20:04

[quote name="Ind" timestamp="1366833292"]
can you show the script?[/quote]
i just enable this following custom npc from npc\scripts_custom.conf
[code=auto:0] // ----------------------- Basic Scripts ----------------------- npc: npc/custom/warper.txt npc: npc/custom/jobmaster.txt npc: npc/custom/platinum_skills.txt npc: npc/custom/healer.txt npc: npc/custom/breeder.txt npc: npc/custom/itemmall.txt npc: npc/custom/stylist.txt npc: npc/custom/resetnpc.txt npc: npc/custom/card_remover.txt //npc: npc/custom/item_signer.txt npc: npc/custom/woe_controller.txt // ----------------------- Other Scripts ----------------------- // -- MVP Arena npc: npc/custom/etc/mvp_arena.txt [/code]

bgamez23 - Apr 25, 2013 6:48

any luck for this issue?

bgamez23 - Apr 26, 2013 13:05

bump.

bgamez23 - Apr 27, 2013 16:42

bump

i use the latest revision but the problem still there.

This post has been edited by bgamez23 on Apr 27, 2013 16:45

bgamez23 - Apr 29, 2013 5:53

bump this for 6th days

Zopokx - Apr 29, 2013 10:01

Script related issue?

bgamez23 - Apr 29, 2013 11:37

[quote name="Zopokx" timestamp="1367229661"]
Script related issue?[/quote]
im not sure if its on the script since there is no error on map server.

bgamez23 - Apr 30, 2013 6:33

bump again.

kyeme - Apr 30, 2013 6:46

[quote name="bgamez23" timestamp="1367303626"]
bump again.[/quote]
Post your heal script.

bgamez23 - Apr 30, 2013 7:23

[quote name="kyeme" timestamp="1367304413"][quote name="bgamez23" timestamp="1367303626"]

bump again.[/quote]Post your heal script.[/quote]

the script was posted above. just simply enable the mvp summoner lol.

kyeme - Apr 30, 2013 7:53

Isee, i can confirm this.

bgamez23 - Apr 30, 2013 7:57

[quote name="kyeme" timestamp="1367308419"]
Isee, i can confirm this.[/quote]
nice. it looks like i'm not the only one who got this issue,

Kenpachi - Apr 30, 2013 10:53

[code=auto:0] function script Protector { switch(select(""+((getarg(0)=="")?"":"Harder Monsters")+":Heal:Exit")) { case 1: warp getarg(0),102,102; close; case 2: specialeffect2 313; percentheal 100,100; close; case 3: warp "prontera",156,179; close; } } [/code]
The script looks fine, even though [i]end;[/i] would be more accurate than [i]close;[/i]. Maybe changing it will fix this issue, but I can't test it for the next few hours.

bgamez23 - Apr 30, 2013 11:29

[quote name="Kenpachi" timestamp="1367319208"][code=auto:0] function script Protector { switch(select(""+((getarg(0)=="")?"":"Harder Monsters")+":Heal:Exit")) { case 1: warp getarg(0),102,102; close; case 2: specialeffect2 313; percentheal 100,100; close; case 3: warp "prontera",156,179; close; } } [/code]The script looks fine, even though [i]end;[/i] would be more accurate than [i]close;[/i]. Maybe changing it will fix this issue, but I can't test it for the next few hours.[/quote]

still not working sir. the character still stock up. but the npc dialog is now gone and i can use skills now. but when i try to do this. talk to the npc when the npc dialog box appear. press esc then the game settings window will appear. press esc again. the npc diaglog box and game settings window will be gone. and you can't move use skill again and then the problem is back.
the Any work in progress (NPC dialog, manufactoring,,,) quit and try again. will appear when you try to use skills.

bgamez23 - May 1, 2013 13:28

up

Kenpachi - May 1, 2013 16:08

[s]This should be fixed since 2013-04-16. ([url="http://herc.ws/board/tracker/issue-7116-close-close2-script-commands/"]http://herc.ws/board/tracker/issue-7116-close-close2-script-commands/[/url])
Please update your server.[/s]

//EDIT: Nevermind. My fault. :(

This post has been edited by Kenpachi on May 1, 2013 16:10

bgamez23 - May 1, 2013 17:10

[quote name="Kenpachi" timestamp="1367424516"]
[s]This should be fixed since 2013-04-16. ([url="http://herc.ws/board/tracker/issue-7116-close-close2-script-commands/"]http://herc.ws/board/tracker/issue-7116-close-close2-script-commands/[/url])
Please update your server.[/s]

//EDIT: Nevermind. My fault. :([/quote]
i think there is a lot of conflict regarding on the replacement for close to end.

here is my simple way to fix this problem.

i revert back the end to close on this script.
and then i add the dialog box for the npc.

because i noticed that this is only happen for those who don't have dialog box with menu screen.

on the protector script i just add the npc dialog box to make it work correctly.

[code=auto:0] // Protectors function script Protector { mes "[ ^0065DFMVP Protector^000000 ]"; switch(select(""+((getarg(0)=="")?"":"Harder Monsters")+":Heal:Exit")) { [/code]

bgamez23 - May 1, 2013 17:12

and also it will fix the other way to produce this bug. by pressing esc 2x while talking to the npc.

Kenpachi - May 2, 2013 11:16

Mhmhmh, odd...
Well, I'll commit that fix later today, but it seems there is a bug with [i]switch[/i] or [i]select[/i] command.

bgamez23 - May 2, 2013 11:30

[quote name="Kenpachi" timestamp="1367493384"]
Mhmhmh, odd...
Well, I'll commit that fix later today, but it seems there is a bug with [i]switch[/i] or [i]select[/i] command.[/quote]
hmmm i'm not sure sir because i just notice this bug since the implementation of close to end function for the script.

Kenpachi - May 2, 2013 19:42

Acute bug fixed in [url="https://github.com/HerculesWS/Hercules/commit/58a035a53efcafea1623999832a764fabba1bf5f"]https://github.com/HerculesWS/Hercules/commit/58a035a53efcafea1623999832a764fabba1bf5f[/url]

This report remains open because of the odd behaviour.

Ind - May 2, 2013 22:04

thank you Kenpachi I'll try to fix this odd thing

Ind - May 2, 2013 22:29

identified the issue, will commit soon

bgamez23 - May 19, 2013 7:51

[quote name="Ind" timestamp="1367533762"]
identified the issue, will commit soon[/quote]
i think the problem sir was on the src\map\script.c
[code=auto:0] /// Ends the script and displays the button 'close' on the npc dialog. /// The dialog is closed when the button is pressed. /// /// close; BUILDIN(close) { TBL_PC* sd; sd = script_rid2sd(st); if( sd == NULL ) return true; st->state = CLOSE; clif->scriptclose(sd, st->oid); return true; } [/code]

and i replace the
[code=auto:0] /// Ends the script and displays the button 'close' on the npc dialog. /// The dialog is closed when the button is pressed. /// /// close; BUILDIN(close) { TBL_PC* sd; sd = script_rid2sd(st); if( sd == NULL ) return true; st->state = END; clif->scriptclose(sd, st->oid); return true; } [/code]

after i change it there is no problem regarding on the npc even i reverted back the old script still working on the latest revision.

Nameless2you - May 19, 2013 8:44

Alternatively I'd have tried using a combination of[code=auto:0]close2;[/code] followed by [code=auto:0]end;[/code] and see if that would've resolved it.
The close button is supposed to work that way, that it only works and ends correctly with dialogs, since there is a no dialog there it can't really end. But again since I can't test it I'd have to rely on others confirming it, or waiting until I can get my desktop back up and running.

Joseph - Jun 6, 2013 17:40

Tried, not working.

bgamez23 - Jun 6, 2013 18:13

still waiting for official fix.

Ind - Jun 6, 2013 19:36

but I fixed this O_O~ uh maybe i forgot to update this or didnt commit it from my working copy, lemme check

Ind - Jun 6, 2013 19:40

Yup it was fixed here
[url="https://github.com/HerculesWS/Hercules/commit/adc2e6ea9778e34945722f8f7d89e10cd9a4b972"]https://github.com/HerculesWS/Hercules/commit/adc2e6ea9778e34945722f8f7d89e10cd9a4b972[/url]

bgamez23 - Jun 11, 2013 17:56

[quote name="Ind" timestamp="1370547644"]
Yup it was fixed here
[url="https://github.com/HerculesWS/Hercules/commit/adc2e6ea9778e34945722f8f7d89e10cd9a4b972"]https://github.com/HerculesWS/Hercules/commit/adc2e6ea9778e34945722f8f7d89e10cd9a4b972[/url][/quote]
the link that you post is Navigation system?

Mysterious - Jun 11, 2013 19:14

[quote name="bgamez23" timestamp="1370973407"][quote name="Ind" timestamp="1370547644"]

Yup it was fixed here
[url="https://github.com/HerculesWS/Hercules/commit/adc2e6ea9778e34945722f8f7d89e10cd9a4b972"]https://github.com/HerculesWS/Hercules/commit/adc2e6ea9778e34945722f8f7d89e10cd9a4b972[/url][/quote]the link that you post is Navigation system?[/quote]

No, he linked you to the commit that fixes the dialogue issue as discussed in this bug report.