Issue information

Issue ID
#7199
Status
New
Severity
None
Started
Zopokx
Apr 28, 2013 17:46
Last Post
Zopokx
Jul 17, 2013 7:56
Confirmation
Yes (1)
No (0)

Zopokx - Apr 28, 2013 17:46

@trade should work without check the distance between the 2 traders, right?

Right now it is only working like regular 'right-click-trade'

Zopokx - May 22, 2013 18:45

up!

Bug, or working as intended?

Xgear - May 22, 2013 21:18

The server checks wether or not the character can use @trade, if it can't it will check for distance.

I don't seem to have the issue on latest revisions though. I'll check a clean one just in case once I have some time.

Xgear - May 23, 2013 6:32

Tested and confirmed. The issues lies within trade.c @ trade_tradeack.
Tradeack is sent from the target to the source (from the @trade receiver) and the check is made to see if the one accepting has @trade instead of the one who issued the command.

Changing

// Players can not request trade from far away, unless they are allowed to use @trade.
// Check here as well since the original character could had warped.
if (!pc_can_use_command([b]sd[/b], "@trade") &&

to

if (!pc_can_use_command([b]t[/b][b]sd[/b], "@trade") &&

Should fix the issue (If you're in a rush until this is officially fixed in Hercules :P)

This post has been edited by Xgear on May 23, 2013 18:15

Zopokx - May 23, 2013 7:59

It is not urgent (not for me) but thanks for your interest and for the fix!

Zopokx - Jul 17, 2013 7:56

Up! :D