Kenpachi - May 1, 2013 0:24
Refering to [url="http://herc.ws/board/tracker/issue-6396-chemical-protection/?gopid=17637#entry17637"]this bug report[/url] the itemskill command should check for required items and show the "Skill has failed." message if necessary. Maybe an optional parameter (0 or 1) is the best way to add this feature.
This post has been edited by
Kenpachi
on May 1, 2013 0:36
Ind - May 3, 2013 0:51
[url="https://github.com/HerculesWS/Hercules/commit/c6f8d9ed12d930a63f5c82370962ac94cd70b13c"]https://github.com/HerculesWS/Hercules/commit/c6f8d9ed12d930a63f5c82370962ac94cd70b13c[/url]
Thanks Kenpachi :D
Ind - May 3, 2013 0:54
ah there is a trick. something in the requirement stuff will block this fix =_=[code=auto:0]
if( sd->skillitem == skill_id )
return req; // Item skills and Hocus-Pocus don't have requirements.[Inkfish]
[/code]
Ind - May 3, 2013 0:57
the comment above ^ makes me wonder, this requires a new script command OR all itemskill casts require comments and inkfish's fix is wrong?
kyeme - May 3, 2013 1:02
@offtopic
@Sir Ind, is this possible to add flag to consume the item immediately? [url="http://herc.ws/board/tracker/issue-5966-item-usable-with-delayed-consumption-item-scroll/?gopid=10219#entry10219"]Issue[/url] :)
Kenpachi - May 3, 2013 6:52
[quote name="kyeme" timestamp="1367542942"]
@offtopic
@Sir Ind, is this possible to add flag to consume the item immediately? [url="http://herc.ws/board/tracker/issue-5966-item-usable-with-delayed-consumption-item-scroll/?gopid=10219#entry10219"]Issue[/url] :)[/quote]
This must be handled by the item type, not the bonus. I'm aware of that issue and will be investigating it next week.
Ind - May 3, 2013 16:41
what about the inkfish thing oo all itemskills' should check requirements or selected ones?
Kenpachi - May 3, 2013 16:49
[s]What is "the inkfish thing"? ^^[/s] Nevermind, you're talking about the code block you posted. Mhm, maybe it was like this in pre-RE?
And yes, all official item scripts which make use of [i]itemskill[/i] should check for the required items and states. (skill_require_db.txt) If there is an item which does not make use of this I can simply set the optional flag, so don't worry.
This post has been edited by
Kenpachi
on May 3, 2013 17:08
Ind - May 3, 2013 18:40
alright I'll dump the blocked sections, thank you :D
This post has been edited by
Ind
on May 3, 2013 18:40
Kenpachi - May 4, 2013 0:10
But pay attention when removing that block. Hocus-Pocus should not check the requirements.
Ind - May 4, 2013 19:01
Aye! There we go :D [url="https://github.com/HerculesWS/Hercules/commit/ad9a13be6ef115de1d5e124283a1d63a0bc5cd4d"]https://github.com/HerculesWS/Hercules/commit/ad9a13be6ef115de1d5e124283a1d63a0bc5cd4d[/url]
Zopokx - May 13, 2013 7:29
But it still consume SP :/
Ind - May 15, 2013 20:31
I've reverted and am waiting for more information, this all-or-none thing was breaking behavior for a high number of items.
kyeme - Dec 2, 2013 4:33
We can test this on ~aegis server~ :D
This post has been edited by
kyeme
on Nov 17, 2014 9:41