mybitch - May 14, 2013 4:52
Alright I'll try my best how to explain this..
You must be a wizard to reproduce this one.[list=1]
[*]Be a wizard and get a party or just use phen clip
[*]Mob all High Orcs
[*]Use Storm Gust
[*]Here's the loop issue
If you kill the High Orc in 2 hits (S.G. does max damage on High Orcs), after the monster respawn and you mob them again, high orcs freeze in just 1 hit which is supposed to be per 3 hits.
So the thing is, I think a loop issue in the monsters?
Some High Orcs are frozen after being hit by SG but some High Orcs are being frozen after 3 hits.
[*]Same goes to all monster..
[/list]
Playtester - May 14, 2013 7:13
sg_counter doesn't get reset on mob dead, but it probably should.
malufett - May 14, 2013 11:00
hmm..just to ask before commiting is your settings pre or re?
:meow:
mybitch - May 14, 2013 12:58
[quote name="malufett" timestamp="1368529219"]
hmm..just to ask before commiting is your settings pre or re?
:meow:[/quote]
Oh yes sorry I didn't include it. Both. I run both renewal and pre-renewal.
malufett - May 14, 2013 13:17
hmm..cause in renewal there is no sg counter..
:meow:
mybitch - May 14, 2013 13:33
[quote name="malufett" timestamp="1368537463"]
hmm..cause in renewal there is no sg counter..
:meow:[/quote]
I don't know how to read the source file so I assumed that it happens to both. But for the current problem, it happens on my pre-renewal.
malufett - May 14, 2013 13:42
[quote]
I don't know how to read the source file so I assumed that it happens to both. But for the current problem, it happens on my pre-renewal.[/quote]
anyway in pre I confirmed...
:meow:
mybitch - May 14, 2013 14:24
Thanks for confirming. Is there any way to partially fix this one?
This post has been edited by
mybitch
on May 14, 2013 14:26
malufett - May 14, 2013 14:48
here is the fix,,..ATM I can't commit my connection is as slow as snail...
@status.c
[code=auto:0]
status_change_end(bl, (sc_type)i, INVALID_TIMER);
if( type == 1 && sc->data[i] ) {
//If for some reason status_change_end decides to still keep the status when quitting. [Skotlex]
(sc->count)--;
if (sc->data[i]->timer != INVALID_TIMER)
delete_timer(sc->data[i]->timer, status_change_timer);
ers_free(sc_data_ers, sc->data[i]);
sc->data[i] = NULL;
}
}
sc->opt1 = 0;
sc->opt2 = 0;
sc->opt3 = 0;
+sc->bs_counter = 0;
+#ifndef RENEWAL
+sc->sg_counter = 0;
+#endif
if( type == 0 || type == 2 )
clif->changeoption(bl);return 1;
}
[/code]
Ind - May 15, 2013 20:17
Thank you malufett, [url="https://github.com/HerculesWS/Hercules/commit/120827a91283d60699824e9b1c56dd85c4747125"]https://github.com/HerculesWS/Hercules/commit/120827a91283d60699824e9b1c56dd85c4747125[/url]
mybitch - May 19, 2013 14:53
[quote name="Ind" timestamp="1368649054"]
Thank you malufett, [url="https://github.com/HerculesWS/Hercules/commit/120827a91283d60699824e9b1c56dd85c4747125"]https://github.com/HerculesWS/Hercules/commit/120827a91283d60699824e9b1c56dd85c4747125[/url][/quote]
Still the problem is there. :( Some mobs still freeze after 1 hit of SG . This applies to High Orcs.
mybitch - May 19, 2013 23:40
Thanks for changing its status.
mybitch - May 21, 2013 0:40
just reopening the issue.
mybitch - May 23, 2013 14:40
bumping for this..
malufett - May 23, 2013 15:11
[quote]
Still the problem is there. Some mobs still freeze after 1 hit of SG . This applies to High Orcs.[/quote]
sorry I'm unable to reproduce...
check 100 times and I make used of one mob in a closed map to make sure to hit the same mob after respawn and it always freeze after 3 hits...make sure you are not using renewal settings...
:meow:
Kichi - May 23, 2013 16:11
[quote name="mybitch" timestamp="1368975181"]
Still the problem is there. :( Some mobs still freeze after 1 hit of SG . This applies to High Orcs.[/quote]
invalid report
u should update to latest git than recompile :)
mybitch - May 26, 2013 13:39
I have updated to the latest revision and still it acts like it :(
mybitch - May 26, 2013 13:40
isn't this the only fix for these issue?
[code=auto:0]+ sc->bs_counter = 0;
+#ifndef RENEWAL
+ sc->sg_counter = 0;
+#endif[/code]
applied it manually and it does't fix the issue. I didn't update my revision since what I'm using is a pre-renewal server. Just a manual update. By chance having a conclusion that there's an update after this?
This post has been edited by
mybitch
on May 26, 2013 13:50
mybitch - May 26, 2013 13:50
[quote name="malufett" timestamp="1369321865"][quote]
Still the problem is there. Some mobs still freeze after 1 hit of SG . This applies to High Orcs.[/quote]sorry I'm unable to reproduce...
check 100 times and I make used of one mob in a closed map to make sure to hit the same mob after respawn and it always freeze after 3 hits...make sure you are not using renewal settings...
:meow:[/quote]
Really didn't fix it. Wonder why? Is there any update with regards to the one you have posted above?
malufett - May 26, 2013 13:56
[quote]
//SG counter does not reset per stormgust. IE: One hit from a SG and two hits from another will freeze you.[/quote]
did you consider this in your test? are you sure you are hitting fresh respawn monster?
:meow:
mybitch - May 27, 2013 1:10
[quote name="malufett" timestamp="1369576592"][quote]
//SG counter does not reset per stormgust. IE: One hit from a SG and two hits from another will freeze you.[/quote]did you consider this in your test? are you sure you are hitting fresh respawn monster?
:meow:[/quote]
yes. I considered this in my test. I actually let 100 high orc spawn on alde_dun just to check this one. But still it doesn't. After killing mobs in 1 hit. Some of them does freeze on its 2nd hit or in 1st..
Jeffery - May 28, 2013 20:08
I'm giving you my solution to this bug.
Open mob.c
Find
[code=auto:0]
md->state.aggressive = md->status.mode&MD_ANGRY?1:0;
[/code]
Add after that
[code=auto:0]
#ifndef RENEWAL
md->sc.sg_counter = 0;
#endif[/code]