Any work in progress (NPC dialog, manufactoring,,,) quit and try again.

I'm going to go out on a hunch here and say that when using message [code=auto:0]strcharinfo(0),"msg";[/code] it'll require [code=auto:0]end;[/code] rather than [code=auto:0]close;[/code] because it doesn't attach like [code=auto:0]mes[/code] does. However considering I can't test it because my desktop is currently broken it'll have to wait for other parties confirmation or until I manage to fix it.

I had to do that fix on my server to fix it (change close; to end;). Thing is documentation says *close; will end the script execution, but it doesnt. Assuming the documentation is right, the problem lies in the *close function.

[quote name="Nameless2you" timestamp="1368947991"]
I'm going to go out on a hunch here and say that when using message[code=auto:0] strcharinfo(0),"msg";[/code]it'll require[code=auto:0] end;[/code]rather than[code=auto:0] close;[/code]because it doesn't attach like[code=auto:0] mes[/code]does. However considering I can't test it because my desktop is currently broken it'll have to wait for other parties confirmation or until I manage to fix it.[/quote]

thanks it's working now. since Hercules adopt the implementation of rA on changing end to close. is the any possible way to revert it back to normal way before the implementation of it? because i think that was incomplete as off now lots of bug happening on the npc. specially on hercules :(

hmmm by the way thanks for the confirm. i made my fix for this to avoid any problem regarding on the close function.

i edit my src\map\script.c

and i replace the st->state = CLOSE; to st->state = END; and no more problem regarding on close function.

I'll edit the script and the documentation where needed.
[code=auto:0]close;[/code] is only for dialog boxes now, i.e. for [code=auto:0]mes "Hello there bggamez23";[/code][code=auto:0]end;[/code] is for everything else.

Fixed in: [url="https://github.com/HerculesWS/Hercules/commit/75d276d7e30c9ca92cd450de9ef897c98a2a4ab3"]https://github.com/HerculesWS/Hercules/commit/75d276d7e30c9ca92cd450de9ef897c98a2a4ab3[/url]

thanks for the fix. but i fix it on the source to avoid some problem regarding on close to end issue just like this topic and also for this issue. [url="http://herc.ws/board/index.php?app=tracker&showissue=7183"]http://herc.ws/board/index.php?app=tracker&showissue=7183[/url]

Yeah, noticed that. Although that'll hinder further progress on fixing those issues. As you won't be able to report them anymore.
And I'm also not sure if that warp script may have a different issue, I haven't looked at it yet.

[quote name="Nameless2you" timestamp="1368952602"]
Yeah, noticed that. Although that'll hinder further progress on fixing those issues. As you won't be able to report them anymore.
And I'm also not sure if that warp script may have a different issue, I haven't looked at it yet.[/quote]
what warp script?the warper?as of now there is no problem regarding on that one. unless you enabled the secure_npc_timeout.

I was just referring to it as warp script, I did mean the mvp_arena.txt one.

[quote name="Nameless2you" timestamp="1368953136"]
I was just referring to it as warp script, I did mean the mvp_arena.txt one.[/quote]
oh i see. it looks like i found another bug. since you mention other script. and i was mention another script.

Why did we have to do this anyway? I mean changing close; to end;? Years of scripting undone by this one little change. Sometimes even after changing, characters still get stuck and need to go back to character select screen just to be able to move again.

[quote name="mofo" timestamp="1370396099"]
Why did we have to do this anyway? I mean changing close; to end;? Years of scripting undone by this one little change. Sometimes even after changing, characters still get stuck and need to go back to character select screen just to be able to move again.[/quote]
i think they adopt it on rA. but the fix for this is on your src\map\script.c

find BUILDIN(close)

look for

st->state = CLOSE;
clif->scriptclose(sd, st->oid);
return true;

replace the CLOSE to END. to end all the problem regarding on stock up. and also it will fix the issue regarding on the close to end.

recompile after you edit the source.

[quote]
Why did we have to do this anyway? I mean changing close; to end;? Years of scripting undone by this one little change. Sometimes even after changing, characters still get stuck and need to go back to character select screen just to be able to move again.[/quote]
because it's the official way and close has a new function for now and a proper used for end and close command...
close = to show the close button and when click terminate the script so it only means used it after mes..take note using end instead of close will make the character detach to the script...
end = immediately terminate the script..

:meow:

rAthena does this differently to preserve backwards compatibility.
[url="http://rathena.org/board/topic/81860-r17280-slight-script-engine-update/"]http://rathena.org/board/topic/81860-r17280-slight-script-engine-update/[/url]
[url="http://sourceforge.net/p/rathena/svn/17280"]http://sourceforge.net/p/rathena/svn/17280[/url]