Status Weapon Switch

i dont see this being possible huhu o__o~ it'd be more easy to understand the hydra weapon being broken hmmm whats asura damage with the stormy weapon?

Iv make a new video:
[url="http://www.youtube.com/watch?v=iWkhTAotIc8&feature=youtu.be"]http://www.youtube.com/watch?v=iWkhTAotIc8&feature=youtu.be[/url]


Asura with +0 double bloody double bone mace [4] = 5,294
Asura with +0 Quad StormyKnight mace [4] = 3.4k

In the video you can see my damage is 5,294 but the High orc got frozen because of switching bug.

To reproduce:
Before casting bar end. . switch to status weapon (stormy card, etc. )

ah i understand now how its possible thanks for the video.

Bump.

[url="https://github.com/HerculesWS/Hercules/commit/144a9d0843dfe47e0b58c8857762f58ae70543c8"]https://github.com/HerculesWS/Hercules/commit/144a9d0843dfe47e0b58c8857762f58ae70543c8[/url]
Thank you all.

Yahoooooo! THANK YOU!! :)

When i tried to switch my weapon quickly after i cast my skill, i'd got this msg "[color=#ff0000]You can't put this item on[/color]" or you unable to change your weapon.
Is this intentional? :)

[quote name="kyeme" timestamp="1373090338"]
When i tried to switch my weapon quickly after i cast my skill, i'd got this msg "[color=#ff0000]You can't put this item on[/color]" or you unable to change your weapon.
Is this intentional? :)[/quote]I'd say its intentional, the fix to this makes character unable to change gear while any skill previously cast hasn't completed processing -- this avoids any gear change to affect damage/post-effect. (in most skills this is instantly and unnoticeable though)

[quote name="Ind" timestamp="1373138772"][quote name="kyeme" timestamp="1373090338"]

When i tried to switch my weapon quickly after i cast my skill, i'd got this msg "[color=#ff0000]You can't put this item on[/color]" or you unable to change your weapon.
Is this intentional? :)[/quote]I'd say its intentional, the fix to this makes character unable to change gear while any skill previously cast hasn't completed processing -- this avoids any gear change to affect damage/post-effect. (in most skills this is instantly and unnoticeable though)[/quote]

But Sir, the way you fixed the bug the official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger. :o

I don't know if this is related to this bugfix but...

It seems that in some way, after several minutes playing, you can't switch any weapon/equipment. It just doesn't work. You need to relog to be able to switch equipment again. This affects arrows too.

[quote name="Zopokx" timestamp="1373369867"]
I don't know if this is related to this bugfix but...

It seems that in some way, after several minutes playing, you can't switch any weapon/equipment. It just doesn't work. You need to relog to be able to switch equipment again. This affects arrows too.[/quote]
I can confirm this, related ithink :)

hmm..I tried to investigate I reverted Ind's fixed and I tried to mimic Kyeme's video and used some debug message in the server and it shows that the problem doesn't exist in Hercules..only tested in Re..but let me test again in Pre..

:meow:

I'm using RE, but I still don't know how to reproduce... because doing the same actions, the first time it worked but the second time it didn't. Weird, so weird.

[quote name="kyeme" timestamp="1373366395"]

[quote name="Ind" timestamp="1373138772"]

[quote name="kyeme" timestamp="1373090338"]
When i tried to switch my weapon quickly after i cast my skill, i'd got this msg "[color=#ff0000]You can't put this item on[/color]" or you unable to change your weapon.
Is this intentional? :)[/quote]I'd say its intentional, the fix to this makes character unable to change gear while any skill previously cast hasn't completed processing -- this avoids any gear change to affect damage/post-effect. (in most skills this is instantly and unnoticeable though)

[/quote]But Sir, the way you fixed the bug the official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger. :o

[/quote]I'll take a look
[hr][quote name="malufett" timestamp="1373372855"]
hmm..I tried to investigate I reverted Ind's fixed and I tried to mimic Kyeme's video and used some debug message in the server and it shows that the problem doesn't exist in Hercules..only tested in Re..but let me test again in Pre..

:meow:[/quote]I think the problem is in the timing (in your testing), as i understand (i can of course be wrong if you know it to be otherwise please tell me =3) there is nothing in the code that prevents it from happening (without the fix) regardless of pre-re or RE, damage is calculated before delay_damage is called, then when it is cast it calls a timer, so it is possible (without the fix) to switch gear during that timer, when the timer ends it calls:[code=auto:0] if( dat->attack_type && !iStatus->isdead(target) && dat->additional_effects ) skill->additional_effect(src,target,dat->skill_id,dat->skill_lv,dat->attack_type,dat->dmg_lv,tick); if( dat->dmg_lv > ATK_BLOCK && dat->attack_type ) skill->counter_additional_effect(src,target,dat->skill_id,dat->skill_lv,dat->attack_type,tick);[/code]which would trigger any effects of the weapons changed afterwards

[quote name="kyeme" timestamp="1373370190"]

[quote name="Zopokx" timestamp="1373369867"]
I don't know if this is related to this bugfix but...

It seems that in some way, after several minutes playing, you can't switch any weapon/equipment. It just doesn't work. You need to relog to be able to switch equipment again. This affects arrows too.[/quote]I can confirm this, related ithink :)

[/quote]Do you have any info that can help me into reproducing this? I couldn't

[quote name="kyeme" timestamp="1373370190"]

[quote name="Zopokx" timestamp="1373369867"]
I don't know if this is related to this bugfix but...

It seems that in some way, after several minutes playing, you can't switch any weapon/equipment. It just doesn't work. You need to relog to be able to switch equipment again. This affects arrows too.[/quote]I can confirm this, related ithink :)

[/quote]I think I see how this could happen, might have been fixed in [url="https://github.com/HerculesWS/Hercules/commit/172315bdc45220bc2edeed57b8e6f6a781c2b640"]https://github.com/HerculesWS/Hercules/commit/172315bdc45220bc2edeed57b8e6f6a781c2b640[/url]

Up~ :)

Yep, I am able to reproduce this before [url="https://github.com/HerculesWS/Hercules/commit/172315bdc45220bc2edeed57b8e6f6a781c2b640"]https://github.com/HerculesWS/Hercules/commit/172315bdc45220bc2edeed57b8e6f6a781c2b640[/url] but it should be fixed now. Is it still not fixed for you kyeme?

[quote name="Haru" timestamp="1373729471"]
Yep, I am able to reproduce this before [url="https://github.com/HerculesWS/Hercules/commit/172315bdc45220bc2edeed57b8e6f6a781c2b640"]https://github.com/HerculesWS/Hercules/commit/172315bdc45220bc2edeed57b8e6f6a781c2b640[/url] but it should be fixed now. Is it still not fixed for you kyeme?[/quote]
The "can't switch item" issue that posted by Zopokx was already fixed.
The only problem now is "[color=#282828][font=helvetica, arial, sans-serif][size=3]official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."[/size][/font][/color]

UP~

[quote name="kyeme" timestamp="1373817894"]
The only problem now is "[color=#282828][font=helvetica, arial, sans-serif][size=3]official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."[/size][/font][/color][/quote]can you elaborate/clarify? I don't understand what you are referring to

maybe his referring with the delay?
You can't put this item on.

just like doing a normal attack. on a Barricade without any weapon. while having a continues attack.
try to equip a weapon or just like a knife. then continues attacking. the remove the knife.
then do it again. and you will get this message. You can't put this item on.

i just try it on iRO there is no You can't put this item on. while switching the weapon.

yes confirmed, i even tried to report it again. haha. all my players are complaining about it. because they cannot switch their weapon as fast as they could they always getting the "you cannot put this item" warning.

You can also do this:

Use sniper, normal attack other player then try to switch weapon while the character is attacking, you will get the warning which is not normal.

up, i hope this will be fix as soon as possible because it's an important thing in a PVP Server. ehehehe. thnx

[quote name="ramzelle100" timestamp="1374474035"]
up, i hope this will be fix as soon as possible because it's an important thing in a PVP Server. ehehehe. thnx[/quote]do you realize that by not having this fix players are able to do what the video in the first post shows? (attack with damage weapon; switch quickly to a status weapon and have them both work in a single strike), if you understand and agree to that I could give you a diff to remove it (its a very small portion of code anyway)

[quote name="Ind" timestamp="1374475232"]
[quote name="ramzelle100" timestamp="1374474035"]

up, i hope this will be fix as soon as possible because it's an important thing in a PVP Server. ehehehe. thnx[/quote]do you realize that by not having this fix players are able to do what the video in the first post shows? (attack with damage weapon; switch quickly to a status weapon and have them both work in a single strike), if you understand and agree to that I could give you a diff to remove it (its a very small portion of code anyway)[/quote]

oh sure, can you send it to me or post it here sir? just to stop my players from bugging me. thnx

This can only be done on low rate / 99/70 server anyway, so it wont affect us in a no cast server.

[quote name="Ind" timestamp="1374407530"][quote name="kyeme" timestamp="1373817894"]

The only problem now is "[color=#282828][font=helvetica, arial, sans-serif][size=3]official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."[/size][/font][/color][/quote]can you elaborate/clarify? I don't understand what you are referring to[/quote]

What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)

[quote name="kyeme" timestamp="1374603386"][quote name="Ind" timestamp="1374407530"]
[quote name="kyeme" timestamp="1373817894"]


The only problem now is "[color=#282828][font=helvetica, arial, sans-serif][size=3]official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."[/size][/font][/color][/quote]can you elaborate/clarify? I don't understand what you are referring to
[/quote]
What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)[/quote]

you can fix it on your own.
in your clif.c

look for this[code=auto:0] if(!sd->status.inventory[index].identify || sd->delayed_damage != 0) { [/code]
remove the[code=auto:0] || sd->delayed_damage != 0 [/code]
then recompile.

[quote name="kyeme" timestamp="1374603386"]
What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)[/quote]What officials do when you try to swap a weapon during calculation? it lets the exploit take place?

[quote name="Ind" timestamp="1374855578"][quote name="kyeme" timestamp="1374603386"]

What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)[/quote]What officials do when you try to swap a weapon during calculation? it lets the exploit take place?[/quote]

The weapon you are using upon casting the skill is the only effect that should apply. And even you switch your weapon to the end of the cast the effect of the switched weapon will not take effect.

Thank you kyeme
[url="https://github.com/HerculesWS/Hercules/commit/2eab181cece04d8c6a79f9d1a3ff74343cd3ae76"]https://github.com/HerculesWS/Hercules/commit/2eab181cece04d8c6a79f9d1a3ff74343cd3ae76[/url]

[quote name="Ind" timestamp="1374871671"]
Thank you kyeme
[url="https://github.com/HerculesWS/Hercules/commit/2eab181cece04d8c6a79f9d1a3ff74343cd3ae76"]https://github.com/HerculesWS/Hercules/commit/2eab181cece04d8c6a79f9d1a3ff74343cd3ae76[/url][/quote]
Working perfect! Thank you SIR! /no1

[quote name="bgamez23" timestamp="1374844356"][quote name="kyeme" timestamp="1374603386"]
[quote name="Ind" timestamp="1374407530"]
[quote name="kyeme" timestamp="1373817894"]






The only problem now is "[color=#282828][font=helvetica, arial, sans-serif][size=3]official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."[/size][/font][/color][/quote]can you elaborate/clarify? I don't understand what you are referring to




[/quote]What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)



[/quote]you can fix it on your own.
in your clif.c

look for this[code=auto:0] if(!sd->status.inventory[index].identify || sd->delayed_damage != 0) { [/code]remove the[code=auto:0] || sd->delayed_damage != 0 [/code]then recompile.[/quote]

any fix update on this? fast switching behavior?

i wanna enable it. like on rathena.

[quote name="Shatotech" timestamp="1425311396"][quote name="bgamez23" timestamp="1374844356"]
[quote name="kyeme" timestamp="1374603386"]
[quote name="Ind" timestamp="1374407530"]
[quote name="kyeme" timestamp="1373817894"]







The only problem now is "[color=#282828][font=helvetica, arial, sans-serif][size=3]official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."[/size][/font][/color][/quote]can you elaborate/clarify? I don't understand what you are referring to





[/quote]What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)




[/quote]you can fix it on your own.
in your clif.c

look for this[code=auto:0] if(!sd->status.inventory[index].identify || sd->delayed_damage != 0) { [/code]remove the[code=auto:0] || sd->delayed_damage != 0 [/code]then recompile.
[/quote]
any fix update on this? fast switching behavior?

i wanna enable it. like on rathena.[/quote]

..............

[quote name="Shatotech" timestamp="1425311396"]
any fix update on this? fast switching behavior?

i wanna enable it. like on rathena.[/quote]you misunderstand it. being able to switch it fast is the bug in question, if you want it to work like that see what my commit linked earlier did, and undo it.

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif]
I got a problem in recompiling my server. A bit new in fixing server. [/font][/color]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif]
I had a back up of my trunk before i start editing files in my src folder. And I also have the original copy of the files i edited.[/font][/color]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif]
I was trying to enable frost switch so i undo everything from this topic. As I recompile, I got those errors and i tried to bring back the original files and yet same errors occurred.[/font][/color][code=html:0] make[1]: Entering directory `/home/trincli0900/trunk/src/map' MKDIR obj CC achievement.c CC atcommand.c atcommand.c:52:21: error: faction.h: No such file or directory atcommand.c: In function 'atcommand_mobevent': atcommand.c:8602: warning: unused variable 'y' atcommand.c:8602: warning: unused variable 'x' atcommand.c: In function 'atcommand_faction': atcommand.c:10791: warning: implicit declaration of function 'faction_search' atcommand.c:10791: warning: assignment makes pointer from integer without a cast atcommand.c:10798: error: dereferencing pointer to incomplete type atcommand.c:10801: error: dereferencing pointer to incomplete type atcommand.c: In function 'atcommand_language': atcommand.c:10813: warning: initialization makes pointer from integer without a cast atcommand.c:10814: error: dereferencing pointer to incomplete type atcommand.c:10821: error: dereferencing pointer to incomplete type atcommand.c:10821: warning: implicit declaration of function 'lang_search' atcommand.c:10821: error: dereferencing pointer to incomplete type atcommand.c:10823: error: dereferencing pointer to incomplete type atcommand.c:10824: error: dereferencing pointer to incomplete type atcommand.c:10836: warning: assignment makes pointer from integer without a cast atcommand.c:10836: error: dereferencing pointer to incomplete type atcommand.c:10842: error: 'lang_pow' undeclared (first use in this function) atcommand.c:10842: error: (Each undeclared identifier is reported only once atcommand.c:10842: error: for each function it appears in.) atcommand.c:10844: error: dereferencing pointer to incomplete type atcommand.c:10850: error: dereferencing pointer to incomplete type atcommand.c: In function 'atcommand_learnlang': atcommand.c:10860: warning: assignment makes pointer from integer without a cast atcommand.c:10866: error: 'lang_pow' undeclared (first use in this function) atcommand.c:10868: error: dereferencing pointer to incomplete type atcommand.c:10875: error: dereferencing pointer to incomplete type atcommand.c: In function 'atcommand_unlearnlang': atcommand.c:10885: warning: assignment makes pointer from integer without a cast atcommand.c:10891: error: 'lang_pow' undeclared (first use in this function) atcommand.c:10894: error: dereferencing pointer to incomplete type atcommand.c:10899: error: dereferencing pointer to incomplete type atcommand.c: In function 'atcommand_say': atcommand.c:10913: warning: implicit declaration of function 'lang_convert' make[1]: *** [obj/atcommand.o] Error 1 make[1]: Leaving directory `/home/trincli0900/trunk/src/map' make: *** [map] Error 2 [/code]

Unfortunately this line does not exist anymore:[code=auto:0] if(!sd->status.inventory[index].identify || sd->delayed_damage != 0) { [/code]
I tried to disable this feature by removing:[code=auto:0] pc->update_idle_time(sd, BCIDLE_USEITEM); [/code]
from [i]clif_parse_EquipItem[/i] and [i]clif_parse_UnequipItem, [/i]but that didn't work. Can someone provide me the code i have to change to disable it?

Thanks in advance!
-simh

What part in src folder to edit to enable the player to switch weapon to frost and take effect?