Issue information

Issue ID
#7333
Status
Fixed
Severity
Medium
Started
kyeme
Jun 9, 2013 5:21
Last Post
Ind
Feb 3, 2014 18:13
Confirmation
N/A

kyeme - Jun 9, 2013 5:21

Old zone restriction was dropped

Example:
ive disabled Yggdrasilberry in the map of prontera using:
[code=auto:0] { name: "Towns" disabled_items: { Yggdrasilberry: true } } [/code]

I want to enable GVG on prontera: using command @gvgon
[color=#ff0000][u]The GvG behavior will activate AND my Zone for Prontera is now useless[/u][/color]
. . . . . .
Its not like from the old skill/item restriction behavior:
[code=auto:0] //Zone 7 - Towns 607,2048 //Yggdrasilberry [/code]

@gvgon or not you cant use yggdrasilberry in the town of prontera = The two or more [color=#a9a9a9](if possible more inherit)[/color] Flag are possible to merge.

[code=auto:0] //Towns alberta mapflag restricted 7 aldebaran mapflag restricted 7 amatsu mapflag restricted 7 ayothaya mapflag restricted 7 brasilis mapflag restricted 7 comodo mapflag restricted 7 einbroch mapflag restricted 7 einbech mapflag restricted 7 geffen mapflag restricted 7 gonryun mapflag restricted 7 izlude mapflag restricted 7 jawaii mapflag restricted 7 hugel mapflag restricted 7 lighthalzen mapflag restricted 7 louyang mapflag restricted 7 manuk mapflag restricted 7 mid_camp mapflag restricted 7 moc_ruins mapflag restricted 7 morocc mapflag restricted 7 moscovia mapflag restricted 7 niflheim mapflag restricted 7 prontera mapflag restricted 7 payon mapflag restricted 7 pay_arche mapflag restricted 7 rachel mapflag restricted 7 splendide mapflag restricted 7 umbala mapflag restricted 7 veins mapflag restricted 7 xmas mapflag restricted 7 yuno mapflag restricted 7 [/code]

Suggestion:
1.)
Regarding again to my issue xD.
If I use @gvgon gm commands, so the restriction is gvg flag. No Assump, No Tele, etc etc.
It would be nice if we have enabled_skills: { } this commands will override the 1st settings (like disabled_items: { itemname: false } )

2.) Can apply more inherit

Thank you :)

This post has been edited by kyeme on Jun 9, 2013 5:36

kyeme - Jun 10, 2013 22:05

And for disabled_items please add warning msg like official does
[code=auto:0] disabled_items: { } [/code]
[img]http://i.imgur.com/zY5wu0U.jpg[/img]

kyeme - Aug 2, 2013 16:23

Bump ~

kyeme - Aug 4, 2013 23:39

Up~
Sorry for bumping~

Ind - Aug 7, 2013 19:28

I'm inclined to say the gvgon scenario is intended by design, I'll see what the other developers think on this[quote name="kyeme" timestamp="1370901902"]
And for disabled_items please add warning msg like official does[code=auto:0] disabled_items: { } [/code][img]http://i.imgur.com/zY5wu0U.jpg[/img]

[/quote]Added in [url="https://github.com/HerculesWS/Hercules/commit/4fee6cb386a90f24306e54ea3606fa7fa133b8e3"]https://github.com/HerculesWS/Hercules/commit/4fee6cb386a90f24306e54ea3606fa7fa133b8e3[/url]
Thank you very much.

kyeme - Aug 14, 2013 16:19

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]I'm inclined to say the gvgon scenario is intended by design, I'll see what the other developers think on this[/size][/font][/color][color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3][b]
kyeme, on 11 Jun 2013 - 05:57, said:[/b][/size][/font][/color][quote name="kyeme" timestamp="1370901902"]
And for disabled_items please add warning msg like official doesdisabled_items[color=rgb(102,102,0)]:[/color] [color=rgb(102,102,0)]{[/color]
[color=rgb(102,102,0)]}[/color][img]http://i.imgur.com/zY5wu0U.jpg[/img][/quote]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Added in [/size][/font][/color][url="https://github.com/HerculesWS/Hercules/commit/4fee6cb386a90f24306e54ea3606fa7fa133b8e3"]https://github.com/H...606fa7fa133b8e3[/url]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Thank you very much. [/size][/font][/color]

Thank you :)

Super Bumping ~ xD

The restriction in Prontera (zone name :Town) disappears or not applied when @gvgon command is applied because the gvg behavior takes place of the town zone. The two restriction from the @gvgon(gvg restriction) and town restrictions should apply both at the same time on the map.

:)

This post has been edited by kyeme on Aug 14, 2013 16:21

Ind - Aug 14, 2013 16:41

I understand thats the cause but zones are not meant to stack, they override each other (thats why I said inclined to say its by design)

kyeme - Aug 27, 2013 9:30

Ok Sir :)


Up~

Frost - Oct 10, 2013 16:45

Bump

kyeme - Oct 11, 2013 4:49

Super Bump~

kyeme - Oct 19, 2013 1:17

[quote name="kyeme" timestamp="1381466953"]
Super Bump~[/quote]

Ind - Oct 24, 2013 7:06

I'm sorry I got lost here, what still hasn't been fixed?

kyeme - Oct 24, 2013 7:53

[quote name="Ind" timestamp="1382598384"]
I'm sorry I got lost here, what still hasn't been fixed?[/quote]

My example is:
Im at prontera and flag as Zone: Towns
And the Zone: Towns disabled the skill Heal

Now when i use the command @gvgon the result is:
The prontera is now a Zone: GVG BUT the [u]Zone: Towns[/u] was removed (i can now use Heal skill)

In short: Not stacking

This post has been edited by kyeme on Oct 24, 2013 7:56

Ind - Oct 24, 2013 7:55

to that I say working as intended, zones are not meant to be stackable

kyeme - Oct 24, 2013 8:03

[quote name="Ind" timestamp="1382601321"]
to that I say working as intended, zones are not meant to be stackable[/quote]
Ok,
Hmm so how to make this possible?

[size=4][color=rgb(40,40,40)][font=helvetica, arial, sans-serif]Its not like from the old skill/item restriction behavior:[/font][/color][/size][code=auto:0] //Zone 7 - Towns 607,2048 //Yggdrasilberry[/code][code=auto:0] //Towns prontera mapflag restricted 7[/code]
[size=4][color=rgb(40,40,40)][font=helvetica, arial, sans-serif]@gvgon / mf_gvg or NOT you cant use yggdrasilberry in the town of prontera[/font][/color][/size]

This post has been edited by kyeme on Oct 24, 2013 8:29

Ind - Oct 24, 2013 10:16

[quote name="kyeme" timestamp="1382601805"]

[quote name="Ind" timestamp="1382601321"]
to that I say working as intended, zones are not meant to be stackable[/quote]Ok,
Hmm so how to make this possible?

[size=4][color=#282828][font=helvetica, arial, sans-serif]Its not like from the old skill/item restriction behavior:[/font][/color][/size][code=auto:0]//Zone 7 - Towns 607,2048 //Yggdrasilberry[/code][code=auto:0]//Towns prontera mapflag restricted 7[/code][size=4][color=#282828][font=helvetica, arial, sans-serif]@gvgon / mf_gvg or NOT you cant use yggdrasilberry in the town of prontera[/font][/color][/size]

[/quote]If I understood what you want to do, it can be achieved by (let me know if thats not it):
Create a new zone, e.g. "Prontera", make it inherit the "towns" zone, and disable yggdrasil in it.

kyeme - Oct 24, 2013 10:42

If I create a new zone like "PronteraNoYgg" and make inherit
and i type @gvgon or @pvpon: it will be applied the pvp/gvg behavior and will removed the "PronteraNoYgg" zone

Unless if i add[b] yggberry: True[/b] in [b]Zone: PvP [/b]
It works but all PvP maps will disabled the yggberry

Here another example [url="http://herc.ws/board/tracker/issue-7697-map-zone-db-confused-wrong/?gopid=20393#entry20393"][url="http://herc.ws/board/tracker/issue-7697-map-zone-db-confused-wrong/?gopid=20393#entry20393"][url="http://herc.ws/board/tracker/issue-7697-map-zone-db-confused-wrong/?gopid=20393#entry20393"][url="http://herc.ws/board/tracker/issue-7697-map-zone-db-confused-wrong/?gopid=20393#entry20393"]http://herc.ws/board/tracker/issue-7697-map-zone-db-confused-wrong/?gopid=20393#entry20393[/url][/url][/url][/url]

This post has been edited by kyeme on Oct 24, 2013 10:56

Ind - Oct 24, 2013 13:03

I see what you mean... not sure what to do about it, will go over the zone feature and think

kyeme - Jan 15, 2014 1:38

Up~ :)

Ind - Feb 3, 2014 18:13

Should be fixed in [url="https://github.com/HerculesWS/Hercules/commit/50bc76c412b6618d90fdbdb24d43da2bda0525a2"]https://github.com/HerculesWS/Hercules/commit/50bc76c412b6618d90fdbdb24d43da2bda0525a2[/url]