Issue information

Issue ID
#7338
Status
Fixed
Severity
Low
Started
kyeme
Jun 10, 2013 1:30
Last Post
pan
Mar 22, 2014 3:10
Confirmation
Yes (3)
No (0)

kyeme - Jun 10, 2013 1:30

Official:
You cant delete your char while you are in a guild or party
msgstringtable.txt line 1819 and 1820
[code=auto:0] Please leave your guild first in order to remove your character.# Please leave your party first in order to remove your character.# [/code]

Source pRO Sakray:
[url="http://www.youtube.com/watch?v=kM3Q7jPaINg&feature=youtu.be"]http://www.youtube.com/watch?v=kM3Q7jPaINg&feature=youtu.be[/url]

mkbu95 - Jun 10, 2013 3:10

When was this feature implemented?

kyeme - Jun 10, 2013 6:56

Sorry, I dont have any information.. :(

This post has been edited by kyeme on Jun 10, 2013 9:12

Mysterious - Jun 11, 2013 16:01

I thought once you delete the character, the server removes them from the SQL tables? o_O

bgamez23 - Jun 11, 2013 17:52

i can confirm this. should leave guild or party before deleting character.

mkbu95 - Jun 11, 2013 21:05

@Mysterious
Yes, it does, but well it is a feature (useless IMO).

Vali - Jun 11, 2013 22:35

#define USE_OFFICIAL_DELETE_CHARACTER //This feature is useles

Use a define maybe a good idea to implement this if is necessary.

Ind - Jun 12, 2013 1:03

[code=auto:0] // packet: 0x828 // len: 14 struct PACKET_HC_DELETE_CHAR3_RESERVED { /* this+0x0 */ short PacketType /* this+0x2 */ unsigned long GID /* this+0x6 */ int Result /* RESULT_FAIL_UNKNOWN = 0x0, RESULT_SUCCESS = 0x1, RESULT_FAIL_CONFIGURATION = 0x2, RESULT_FAIL_DATABASE = 0x3, RESULT_FAIL_GUILD = 0x4, RESULT_FAIL_PARTY = 0x5 */ /* this+0xa */ long DeleteReservedDate } [/code]I guess its this

Ind - Jun 12, 2013 1:03

^(special thanks to kLabMouse/Yommy)

Beret - Aug 14, 2013 16:52

Bump.

bgamez23 - Sep 17, 2013 9:33

bump for this.

Beret - Mar 12, 2014 20:21

bump.

Ind - Mar 14, 2014 19:55

I think they do this because upon deletiong they dont clear their data properly, we do however so its a pretty cosmetic/pointless requirement -- adds overhead to the user. I'm flagging it as low priority.[quote name="Vali" timestamp="1370990142"]
#define USE_OFFICIAL_DELETE_CHARACTER //This feature is useles

Use a define maybe a good idea to implement this if is necessary.[/quote]I personally think a char-server.conf setting would be best here

pan - Mar 22, 2014 3:09

Added feature in [url="https://github.com/HerculesWS/Hercules/commit/aa120720cec6ba1ddf6ec8ac6098fef6377dddc0"]https://github.com/HerculesWS/Hercules/commit/aa120720cec6ba1ddf6ec8ac6098fef6377dddc0[/url]
I added a char-server.conf setting to activate this behavior:[code=auto:0] +// Block deletion if character is inside a guild or a party? (BOOL) +// default: 0 official: 1 +// !!This check is imposed by Aegis to avoid dead entries in databases and _is_not_needed_ as we clear data properly!! +char_aegis_delete: 0 [/code]Just change it to 1 and it will work just like Aegis does.