mofo - Jun 10, 2013 16:07
Changing the value doesn't seem to have any effect.
Tested some more and it seems that it only works for 14 tiles and below. Even if the official value is 17.
Please disregard, I disabled the official walkpath via core.h and it works now.
This post has been edited by
mofo
on Jun 11, 2013 2:59
Ind - Jun 11, 2013 21:14
I am confirming it because the config is indeed not being used in a specific place in the code[code=auto:0]
#ifdef OFFICIAL_WALKPATH
if( !path_search_long(NULL, bl->m, bl->x, bl->y, x, y, CELL_CHKNOPASS) // Check if there is an obstacle between
&& wpd.path_len > 14 ) // Official number of walkable cells is 14 if and only if there is an obstacle between. [malufett]
return 0;
#endif
if( (battle_config.max_walk_path < wpd.path_len) && (bl->type != BL_NPC) )
return 0;
[/code]the 14 is hardcoded ^.
Ind - Jun 11, 2013 21:15
talking about it, the OFFICIAL_WALKPATH check needs to disregard BL_NPC walking types as well.
mkbu95 - Jun 14, 2013 3:59
Ind, read malufett's comment. [b]is 14 if and only if there is an obstacle between.[/b]
So, official is 17, but it is reduced to 14 if there is an obstacle between.
Should we reduce by 3 max_walk_path, or make it proportional (14/17).
That means if someone defines max_walk_path as 20, where it is 14 now should be 20*(14/17) = 16,47.
malufett - Jun 14, 2013 4:01
[quote name="mkbu95" timestamp="1371182397"]
Ind, read malufett's comment. [b]is 14 if and only if there is an obstacle between.[/b]
So, official is 17, but it is reduced to 14 if there is an obstacle between.
Should we reduce by 3 max_walk_path, or make it proportional (14/17).
That means if someone defines max_walk_path as 20, where it is 14 now should be 20*(14/17) = 16,47.[/quote]
hmm..nice idea having a ratio...+1
:meow:
Ind - Jun 14, 2013 4:23
oh whops O_O~ sorry D: thanks for pointing out :D
mkbu95 - Jun 14, 2013 15:57
Fixed in [url="https://github.com/HerculesWS/Hercules/commit/f22fada707db4e1e186d331f73fcdbbbc17ebb08"]f22fada707db4e1e186d331f73fcdbbbc17ebb08[/url].