Issue information

Issue ID
#7340
Status
Needs more Info
Severity
None
Started
bgamez23
Jun 11, 2013 17:00
Last Post
Beret
Aug 16, 2013 15:06
Confirmation
N/A

bgamez23 - Jun 11, 2013 17:00

before this features is working correctly. but after this update.
4a51fc7e5eec9a464c754d3d1e0ee44da1ca6f72

i'm not sure what revision is that since we don't use revision on git.

i revert back on what changes on that revision.. and it works again.

[img]http://s23.postimg.org/prfeitz7f/screen_Hercules000.jpg[/img]

This post has been edited by bgamez23 on Jun 11, 2013 17:28

Zopokx - Jun 11, 2013 19:23

Using 04-18 and it works, but sometimes it crashes. I think It was when searching for a 'lvl 0' party :P

mkbu95 - Jun 11, 2013 21:03

Dammit. Well, what the hell happened with that new interface bgamez showed.

This post has been edited by mkbu95 on Jun 11, 2013 21:04

ossi0110 - Jun 11, 2013 21:59

my Interface looks different to lol

im using 2012-04-10 RagexeRE

[img]http://s1.directupload.net/images/130612/oss7yiuk.jpg[/img]

This post has been edited by ossi0110 on Jun 11, 2013 22:04

bgamez23 - Jun 12, 2013 2:36

[quote name="mkbu95" timestamp="1370984596"]
Dammit. Well, what the hell happened with that new interface bgamez showed.[/quote]
they used diff UI. if you are using Ragexe. this interface will appear. but if you use RagexeRE the UI interface is with the old interface.

bgamez23 - Jun 12, 2013 2:39

[quote name="ossi0110" timestamp="1370987987"]
my Interface looks different to lol

im using 2012-04-10 RagexeRE

[img]http://s1.directupload.net/images/130612/oss7yiuk.jpg[/img][/quote]

its because your using RagexeRE. but on Ragexe the UI is totally different.

This post has been edited by bgamez23 on Jun 12, 2013 2:39

mkbu95 - Jun 12, 2013 10:37

Depending on the differ you have different Party Booking UIs. Well, guess I am going to set a config for this then since there is no way of knowing which version you have.

bgamez23 - Jun 12, 2013 13:07

[quote name="mkbu95" timestamp="1371033445"]
Depending on the differ you have different Party Booking UIs. Well, guess I am going to set a config for this then since there is no way of knowing which version you have.[/quote]
i think it should be define #ifndef PACKETVER_RE. since your previous update was for RagexeRe only. and by the default the booking system was already working on Ragexe by updating the packet.

mkbu95 - Jun 13, 2013 0:55

ossi0110 is using 2012-04-10aRagexeRE and has this "new" interface.
Your hexed that I used for testing was 2012-04-10aRagexe (not RE) and it has the "new" interface.

What is this diff that changes the UI?
I might put up a config for it instead of auto-detecting.

bgamez23 - Jun 13, 2013 4:33

for 2012-04-10aRagexe and above they used new interface. for 2012-04-10aRagexeRE they used the old interface which has a blocklist.

Ind - Jun 13, 2013 4:35

[quote name="mkbu95" timestamp="1371084924"]
ossi0110 is using 2012-04-10aRagexeRE and has this "new" interface.
Your hexed that I used for testing was 2012-04-10aRagexe (not RE) and it has the "new" interface.

What is this diff that changes the UI?
I might put up a config for it instead of auto-detecting.[/quote]Wouldnt the mmo.h[code=auto:0] // Comment the following line if your client is NOT ragexeRE (required because of conflicting packets in ragexe vs ragexeRE). #define PACKETVER_RE [/code]fix this? (if used in the const.h party_recruit thing)? -- I'm not sure, asking

bgamez23 - Jun 13, 2013 4:38

[quote name="Ind" timestamp="1371098130"][quote name="mkbu95" timestamp="1371084924"]

ossi0110 is using 2012-04-10aRagexeRE and has this "new" interface.
Your hexed that I used for testing was 2012-04-10aRagexe (not RE) and it has the "new" interface.

What is this diff that changes the UI?
I might put up a config for it instead of auto-detecting.[/quote]Wouldnt the mmo.h[code=auto:0] // Comment the following line if your client is NOT ragexeRE (required because of conflicting packets in ragexe vs ragexeRE). #define PACKETVER_RE [/code]fix this? (if used in the const.h party_recruit thing)? -- I'm not sure, asking[/quote]

still not working even i comment to disable the PACKETVER_RE.

since the previous update doesn't check if the settings is using PACKETVER_RE or not. that's why we having an issue regarding on the booking system. because it only works now on RagexeRE but on Ragexe its not totally working now :(

Ind - Jun 13, 2013 4:44

[quote name="bgamez23" timestamp="1371098338"]

[quote name="Ind" timestamp="1371098130"]

[quote name="mkbu95" timestamp="1371084924"]
ossi0110 is using 2012-04-10aRagexeRE and has this "new" interface.
Your hexed that I used for testing was 2012-04-10aRagexe (not RE) and it has the "new" interface.

What is this diff that changes the UI?
I might put up a config for it instead of auto-detecting.[/quote]Wouldnt the mmo.h[code=auto:0]// Comment the following line if your client is NOT ragexeRE (required because of conflicting packets in ragexe vs ragexeRE). #define PACKETVER_RE [/code]fix this? (if used in the const.h party_recruit thing)? -- I'm not sure, asking

[/quote]still not working even i comment to disable the PACKETVER_RE.

since the previous update doesn't check if the settings is using PACKETVER_RE or not. that's why we having an issue regarding on the booking system. because it only works now on RagexeRE but on Ragexe its not totally working now :(

[/quote]I didnt say it was working (I was asking if using that var in the check -- because its not currently used -- would fix it)

bgamez23 - Jun 13, 2013 4:50

oh i see.it was disable since i'm using Ragexe.

mkbu95 - Jun 13, 2013 15:43

bgamez, can you try this?

go to src/config/const.h then find this:[code=auto:0]#if (PACKETVER == 20120410) || (PACKETVER == 20120418) #define PARTY_RECRUIT #endif[/code]change it to:[code=auto:0]#ifdef PACKETVER_RE #if (PACKETVER == 20120410) || (PACKETVER == 20120418) #define PARTY_RECRUIT #endif #endif[/code]and then recompile

i can't test right now

bgamez23 - Jun 13, 2013 17:01

[quote name="mkbu95" timestamp="1371138200"]
bgamez, can you try this?

go to src/config/const.h then find this:[code=auto:0]#if (PACKETVER == 20120410) || (PACKETVER == 20120418) #define PARTY_RECRUIT#endif[/code]change it to:[code=auto:0]#ifdef PACKETVER_RE#if (PACKETVER == 20120410) || (PACKETVER == 20120418) #define PARTY_RECRUIT#endif#endif[/code]and then recompile

i can't test right now[/quote]

thanks it works now. but you should define PACKETVER_RE on your packets.h to make it usable again.
[code=auto:0] //2012-04-10aRagexeRE and 2012-04-10aRagexe #if PACKETVER >= 20120410 packet(0x094B,19,clif->pWantToConnection,2,6,10,14,18); packet(0x0437,5,clif->pWalkToXY,2); packet(0x0886,6,clif->pTickSend,2); packet(0x0871,5,clif->pChangeDir,2,4); packet(0x0938,6,clif->pTakeItem,2); packet(0x0891,6,clif->pDropItem,2,4); packet(0x086C,8,clif->pMoveToKafra,2,4); packet(0x08A6,8,clif->pMoveFromKafra,2,4); packet(0x0438,10,clif->pUseSkillToPos,2,4,6,8); packet(0x091D,18,clif->pPartyBookingRegisterReq,2,4,6); packet(0x0366,90,clif->pUseSkillToPosMoreInfo,2,4,6,8,10); packet(0x0889,6,clif->pGetCharNameRequest,2); packet(0x0884,6,clif->pSolveCharName,2); packet(0x089C,26,clif->pFriendsListAdd,2); packet(0x0885,5,clif->pHomMenu,2,4); packet(0x0961,36,clif->pStoragePassword,0); packet(0x091C,26,clif->pPartyInvite2,2); packet(0x0369,7,clif->pActionRequest,2,6); packet(0x083C,10,clif->pUseSkillToId,2,4,6); packet(0x0945,-1,clif->pItemListWindowSelected,2,4,8); packet(0x08E5,41,clif->pPartyBookingRegisterReq,2,4); packet(0x0815,-1,clif->pReqOpenBuyingStore,2,4,8,9,89); packet(0x0817,2,clif->pReqCloseBuyingStore,0); packet(0x0360,6,clif->pReqClickBuyingStore,2); packet(0x0811,-1,clif->pReqTradeBuyingStore,2,4,8,12); packet(0x0819,-1,clif->pSearchStoreInfo,2,4,5,9,13,14,15); packet(0x0835,2,clif->pSearchStoreInfoNextPage,0); packet(0x0838,12,clif->pSearchStoreInfoListItemClick,2,6,10); packet(0x0439,8,clif->pUseItem,2,4); #ifdef PACKETVER_RE packet(0x01FD,15,clif->pRepairItem,2); packet(0x089C,26,clif->pFriendsListAdd,2); packet(0x0885,5,clif->pHomMenu,2,4); packet(0x0961,36,clif->pStoragePassword,0); packet(0x0288,-1,clif->pcashshop_buy,4,8); packet(0x091C,26,clif->pPartyInvite2,2); packet(0x094B,19,clif->pWantToConnection,2,6,10,14,18); packet(0x0369,7,clif->pActionRequest,2,6); packet(0x083C,10,clif->pUseSkillToId,2,4,6); packet(0x0439,8,clif->pUseItem,2,4); packet(0x0945,-1,clif->pItemListWindowSelected,2,4,8); packet(0x0815,-1,clif->pReqOpenBuyingStore,2,4,8,9,89); packet(0x0817,2,clif->pReqCloseBuyingStore,0); packet(0x0360,6,clif->pReqClickBuyingStore,2); packet(0x0811,-1,clif->pReqTradeBuyingStore,2,4,8,12); packet(0x0819,-1,clif->pSearchStoreInfo,2,4,5,9,13,14,15); packet(0x0835,2,clif->pSearchStoreInfoNextPage,0); packet(0x0838,12,clif->pSearchStoreInfoListItemClick,2,6,10); packet(0x0437,5,clif->pWalkToXY,2); packet(0x0886,6,clif->pTickSend,2); packet(0x0871,5,clif->pChangeDir,2,4); packet(0x0938,6,clif->pTakeItem,2); packet(0x0891,6,clif->pDropItem,2,4); packet(0x086C,8,clif->pMoveToKafra,2,4); packet(0x08A6,8,clif->pMoveFromKafra,2,4); packet(0x0438,10,clif->pUseSkillToPos,2,4,6,8); packet(0x0366,90,clif->pUseSkillToPosMoreInfo,2,4,6,8,10); packet(0x0889,6,clif->pGetCharNameRequest,2); packet(0x0884,6,clif->pSolveCharName,2); packet(0x08E5,41,clif->pPartyBookingRegisterReq,2,4); packet(0x08E6,4); packet(0x08E7,10,clif->pPartyBookingSearchReq,2); packet(0x08E8,-1); packet(0x08E9,2,clif->pPartyBookingDeleteReq,2); packet(0x08EA,4); packet(0x08EB,39,clif->pPartyBookingUpdateReq,2); packet(0x08EC,73); packet(0x08ED,43); packet(0x08EE,6); #ifdef PARTY_RECRUIT packet(0x08EF,6,clif->pDull,2); //bookingignorereq packet(0x08F0,6,clif->pDull,2); packet(0x08F1,6,clif->pDull,2); //bookingjoinpartyreq #endif packet(0x08F2,36); packet(0x08F3,-1); packet(0x08F4,6); packet(0x08F5,-1,clif->pDull,2,4); //bookingsummonmember packet(0x08F6,22); packet(0x08F7,3); packet(0x08F8,7); packet(0x08F9,6); #ifdef PARTY_RECRUIT packet(0x08F9,6,clif->pDull,2); #endif packet(0x08FA,6); packet(0x08FB,6,clif->pDull,2); //bookingcanceljoinparty packet(0x0907,5,clif->pMoveItem,2,4); packet(0x0908,5); packet(0x08CF,10);//Amulet spirits packet(0x0977,14);//Monster HP Bar #endif [/code]

This post has been edited by bgamez23 on Jun 13, 2013 17:09

bgamez23 - Jun 13, 2013 17:20

2012-04-10aRagexeRE UI[img]http://s18.postimg.org/mz8dxnac9/screen_Hercules000.jpg[/img]

2012-04-10aRagexe[img]http://s18.postimg.org/mnqxkvtw9/screen_Hercules001.jpg[/img]

@mkbu95 can you correct a minor typo on packet.h?

the #if[color=#ff0000]n[/color]def PACKETVER_RE to #ifdef PACKETVER_RE

line 1897 thanks

This post has been edited by bgamez23 on Jun 13, 2013 17:22

Ind - Jun 13, 2013 17:27

[quote name="bgamez23" timestamp="1371144032"]
@mkbu95 can you correct a minor typo on packet.h?

the #if[color=#ff0000]n[/color]def PACKETVER_RE to #ifdef PACKETVER_RE

line 1897 thanks[/quote]that is [u]not[/u] a typo, the packets in that #ifndef packet is for ragexe (not ragexeRE).

bgamez23 - Jun 13, 2013 18:56

[quote name="Ind" timestamp="1371144441"]
[quote name="bgamez23" timestamp="1371144032"]

@mkbu95 can you correct a minor typo on packet.h?

the #if[color=#ff0000]n[/color]def PACKETVER_RE to #ifdef PACKETVER_RE

line 1897 thanks[/quote]that is not a typo, the packets in that #ifndef packet is for ragexe (not ragexeRE).[/quote]

i tried to use it. if i use [size=3][background=rgb(247,247,247)]#ifndef it will not work. just an example on this.[/background][/size]

[color=rgb(0,0,0)][font=monospace][size=3][spoiler][/size][/font][/color][code=auto:0] //2012-04-10aRagexeRE and 2012-04-10aRagexe #if PACKETVER >= 20120410 packet(0x094B,19,clif->pWantToConnection,2,6,10,14,18); packet(0x0437,5,clif->pWalkToXY,2); packet(0x0886,6,clif->pTickSend,2); packet(0x0871,5,clif->pChangeDir,2,4); packet(0x0938,6,clif->pTakeItem,2); packet(0x0891,6,clif->pDropItem,2,4); packet(0x086C,8,clif->pMoveToKafra,2,4); packet(0x08A6,8,clif->pMoveFromKafra,2,4); packet(0x0438,10,clif->pUseSkillToPos,2,4,6,8); packet(0x091D,18,clif->pPartyBookingRegisterReq,2,4,6); packet(0x0366,90,clif->pUseSkillToPosMoreInfo,2,4,6,8,10); packet(0x0889,6,clif->pGetCharNameRequest,2); packet(0x0884,6,clif->pSolveCharName,2); packet(0x089C,26,clif->pFriendsListAdd,2); packet(0x0885,5,clif->pHomMenu,2,4); packet(0x0961,36,clif->pStoragePassword,0); packet(0x091C,26,clif->pPartyInvite2,2); packet(0x0369,7,clif->pActionRequest,2,6); packet(0x083C,10,clif->pUseSkillToId,2,4,6); packet(0x0945,-1,clif->pItemListWindowSelected,2,4,8); packet(0x08E5,41,clif->pPartyBookingRegisterReq,2,4); packet(0x0815,-1,clif->pReqOpenBuyingStore,2,4,8,9,89); packet(0x0817,2,clif->pReqCloseBuyingStore,0); packet(0x0360,6,clif->pReqClickBuyingStore,2); packet(0x0811,-1,clif->pReqTradeBuyingStore,2,4,8,12); packet(0x0819,-1,clif->pSearchStoreInfo,2,4,5,9,13,14,15); packet(0x0835,2,clif->pSearchStoreInfoNextPage,0); packet(0x0838,12,clif->pSearchStoreInfoListItemClick,2,6,10); packet(0x0439,8,clif->pUseItem,2,4); #ifdef PACKETVER_RE packet(0x01FD,15,clif->pRepairItem,2); packet(0x089C,26,clif->pFriendsListAdd,2); packet(0x0885,5,clif->pHomMenu,2,4); packet(0x0961,36,clif->pStoragePassword,0); packet(0x0288,-1,clif->pcashshop_buy,4,8); packet(0x091C,26,clif->pPartyInvite2,2); packet(0x094B,19,clif->pWantToConnection,2,6,10,14,18); packet(0x0369,7,clif->pActionRequest,2,6); packet(0x083C,10,clif->pUseSkillToId,2,4,6); packet(0x0439,8,clif->pUseItem,2,4); packet(0x0945,-1,clif->pItemListWindowSelected,2,4,8); packet(0x0815,-1,clif->pReqOpenBuyingStore,2,4,8,9,89); packet(0x0817,2,clif->pReqCloseBuyingStore,0); packet(0x0360,6,clif->pReqClickBuyingStore,2); packet(0x0811,-1,clif->pReqTradeBuyingStore,2,4,8,12); packet(0x0819,-1,clif->pSearchStoreInfo,2,4,5,9,13,14,15); packet(0x0835,2,clif->pSearchStoreInfoNextPage,0); packet(0x0838,12,clif->pSearchStoreInfoListItemClick,2,6,10); packet(0x0437,5,clif->pWalkToXY,2); packet(0x0886,6,clif->pTickSend,2); packet(0x0871,5,clif->pChangeDir,2,4); packet(0x0938,6,clif->pTakeItem,2); packet(0x0891,6,clif->pDropItem,2,4); packet(0x086C,8,clif->pMoveToKafra,2,4); packet(0x08A6,8,clif->pMoveFromKafra,2,4); packet(0x0438,10,clif->pUseSkillToPos,2,4,6,8); packet(0x0366,90,clif->pUseSkillToPosMoreInfo,2,4,6,8,10); packet(0x0889,6,clif->pGetCharNameRequest,2); packet(0x0884,6,clif->pSolveCharName,2); packet(0x08E5,41,clif->pPartyBookingRegisterReq,2,4); packet(0x08E6,4); packet(0x08E7,10,clif->pPartyBookingSearchReq,2); packet(0x08E8,-1); packet(0x08E9,2,clif->pPartyBookingDeleteReq,2); packet(0x08EA,4); packet(0x08EB,39,clif->pPartyBookingUpdateReq,2); packet(0x08EC,73); packet(0x08ED,43); packet(0x08EE,6); #ifdef PARTY_RECRUIT packet(0x08EF,6,clif->pDull,2); //bookingignorereq packet(0x08F0,6,clif->pDull,2); packet(0x08F1,6,clif->pDull,2); //bookingjoinpartyreq #endif packet(0x08F2,36); packet(0x08F3,-1); packet(0x08F4,6); packet(0x08F5,-1,clif->pDull,2,4); //bookingsummonmember packet(0x08F6,22); packet(0x08F7,3); packet(0x08F8,7); packet(0x08F9,6); #ifdef PARTY_RECRUIT packet(0x08F9,6,clif->pDull,2); #endif packet(0x08FA,6); packet(0x08FB,6,clif->pDull,2); //bookingcanceljoinparty packet(0x0907,5,clif->pMoveItem,2,4); packet(0x0908,5); packet(0x08CF,10);//Amulet spirits packet(0x0977,14);//Monster HP Bar #endif[/code]
​[/spoiler]

feel free to test it.

This post has been edited by bgamez23 on Jun 13, 2013 18:56

mkbu95 - Jun 14, 2013 4:01

Well, I committed something. Does it work now?

bgamez23 - Jun 14, 2013 4:13

[quote name="mkbu95" timestamp="1371182486"]
Well, I committed something. Does it work now?[/quote]
yup it works now. but make sure to fix the typo on packet.h and use the [color=rgb(136,0,0)]#ifdef[/color] PACKETVER_RE for your packets to make it sure that he check which packetver he will use. and i also have a screenshots. proof that it is already working.

bgamez23 - Jun 14, 2013 4:32

using the latest revision. the booking system for 2012-04-10aRagexe is still not working lol.

[img]http://s17.postimg.org/n20wh7hlb/screen_Hercules000.jpg[/img][code=auto:0] [Warning]: clif_parse: Received unsupported packet (packet 0x091d, 18 bytes rece ived), disconnecting session #3. [/code]

bgamez23 - Jun 14, 2013 4:36

you still need to add for 20120410
#ifndef PACKETVER_RE
packet(0x091D,18,clif->pPartyBookingRegisterReq,2,4,6);
#endif

mkbu95 - Jun 14, 2013 9:27

Hmm. But on RagexeRE is working right?
With 0x091D, can you use the other functions of booking system?

bgamez23 - Jun 14, 2013 9:30

[quote name="mkbu95" timestamp="1371202023"]
Hmm. But on RagexeRE is working right?
With 0x091D, can you use the other functions of booking system?[/quote]
yup its working. on the new UI it works normally since there is no blocklist there.

Ind - Jun 14, 2013 15:32

[quote name="bgamez23" timestamp="1371149761"]

[quote name="Ind" timestamp="1371144441"]

[quote name="bgamez23" timestamp="1371144032"]
@mkbu95 can you correct a minor typo on packet.h?

the #if[color=#ff0000]n[/color]def PACKETVER_RE to #ifdef PACKETVER_RE

line 1897 thanks[/quote]that is not a typo, the packets in that #ifndef packet is for ragexe (not ragexeRE).

[/quote]i tried to use it. if i use [size=3]#ifndef it will not work. just an example on this.[/size]

[/quote]you have to uncomment the PACKETVER_RE thing when using ragexe, thats why the ifndef didnt work for you.

mkbu95 - Jun 14, 2013 15:58

Already committed it Thanks!

If anyone is having issues, keep 'em coming 'til we solve 'em

Ind - Jul 29, 2013 18:12

was this fixed?

Beret - Aug 16, 2013 15:06

In Aegis makes use sql.
[code=:0] CREATE TABLE [dbo].[PartyBooking]( [Index] [int] IDENTITY(1,1) NOT NULL, [GID] [int] NOT NULL, [MapID] [smallint] NULL, [Level] [smallint] NULL, [Job1] [smallint] NULL, [Job2] [smallint] NULL, [Job3] [smallint] NULL, [Job4] [smallint] NULL, [Job5] [smallint] NULL, [Job6] [smallint] NULL, [ExpireTime] [datetime] NOT NULL, [/code]

This post has been edited by Beret on Aug 16, 2013 15:08