Damage with reduction cards

Bump? This is a serious issue :P

I can't reproduce, can you give any more info on reproducing it? e.g. certain class/skill/area/damage?

I just tried with RK vs Kagerou. Final strike deals 30k++ damage with or without cranial shield. I tried this even with a fresh svn checkout with no modifications. Same results with my local working git hercules.

I tested it with a ninja and lord knight vs professor.
The problem is what mofo said. It seems that no reduction cards/equipment is working in physical/ranged attacks.

I tested it with a ninja and lord knight vs professor.
The problem is what mofo said. It seems that no reduction cards/equipment is working in physical/ranged attacks.

[quote name="mofo" timestamp="1371738871"]
I just tried with RK vs Kagerou. Final strike deals 30k++ damage with or without cranial shield. I tried this even with a fresh svn checkout with no modifications. Same results with my local working git hercules.[/quote]Thank you for the scenario, confirmed.

[quote name="mofo" timestamp="1371738871"]
I just tried with RK vs Kagerou. Final strike deals 30k++ damage with or without cranial shield. I tried this even with a fresh svn checkout with no modifications. Same results with my local working git hercules.[/quote]
hmm..its works fine..
using Calm Huuma Shuriken and Maximize Power
with cranial I deal 15159
w/o cranial I deal 15217

normal attack
with cranial I deal 391
w/o cranial I deal 451

take note use maximize power to deal accurate result..:D
:meow:

15217 - 15159 = 58
451 - 391 = 60

I thought thara was 30% damage reduction?
As per item_db.txt - { bonus2 bSubRace,RC_DemiHuman,30; }

So based on your tests, shouldn't it be...

15217 x .3 = 4565
15217 - 4565 = 10652

451 x .3 = 135
451 - 135 = 316

take note in renewal only weapon atk is affected by racial reduction..also stated in iro wiki..:D
[quote]
Affected by weapon element when using a melee weapon.
Affected by ammunition element when using a ranged weapon or specific skill.
[b]Affected by element resistance effects such as Raydric Card or Asprika.
Increased by % ATK item effects such as The Sign or Hydra Card.[/b]
Multiplied by 5 when affected by Enchant Deadly Poison.
Though the STR bonus takes Element, it is still considered Neutral.
STR Bonus is always reduced by Ghost armor.
STR Bonus is only reduced by Neutral resistance. like Raydric card, if the weapon is Neutral too.
Variance is a random number ranging from (-5% * Weapon Level * Base Weapon ATK) to (5% * Weapon Level * Base Weapon ATK)[/quote]

and base atk is not affected..[quote]
Normally Neutral except when using Mild Wind.
[b]Ignores element resistance effects such as Raydric Card or Asprika.
Ignores % ATK item effects such as The Sign or Hydra Card.[/b][/quote]

WTF? So, reduction cards/equipment doesn't make any sense now? :/ This is a bit weird and disgusting...
So, a Thara frog card can reduce magical damage but not physical damage?...

Could this be an optional feature? I think that nobody is gonna like this...


BTW, this is weird too: [url="http://herc.ws/board/tracker/issue-7399-neutral-vs-ghost/?gopid=18644#entry18644"]http://herc.ws/board/tracker/issue-7399-neutral-vs-ghost/?gopid=18644#entry18644[/url]
I can attack with an arrow a Ghost LV 4 xDD

[quote name="malufett" timestamp="1371743495"]
[quote name="mofo" timestamp="1371738871"]

I just tried with RK vs Kagerou. Final strike deals 30k++ damage with or without cranial shield. I tried this even with a fresh svn checkout with no modifications. Same results with my local working git hercules.[/quote]hmm..its works fine..
using Calm Huuma Shuriken and Maximize Power
with cranial I deal 15159
w/o cranial I deal 15217

normal attack
with cranial I deal 391
w/o cranial I deal 451

take note use maximize power to deal accurate result.. :D
:meow:[/quote]
That reduction in your test did not include the reduction from thara frog card. That looks like SHIELD DEF reduction. I'm trying it now with normal attacks. Here's my test scenario...

Player A with 100 atk wand + maximize power hits Player B for 115 damage.
Player B wears valk shield with thara frog card and damage is reduced to 90.
Player B switches to valk shield without thara frog card and damage is still 90.

Both players have 1 point on all stats and job lvl 1. I don't see the card reduction in between or at the end of the calculation.

Update: Same results with a beret (0 def, 10% reduction). No reduction from demi-human attacks.

I have same problem too but not using renewal. I'm using pre-renewal. [url="http://herc.ws/board/tracker/issue-7422-thara-frog-card/"]http://herc.ws/board/tracker/issue-7422-thara-frog-card/[/url]

Actually I've been facing an issue with Thara frog card that I was meaning to raise somewhere, wasnt so sure where since its more of a feedback confirmation thing.

When I was testing Thara Frog's reduction I came to notice it was doing about a 50% reduction. I havnt finished doing all my testing since my computer overheats easily and debugging is becoming hell, but what I did get to notice was that the cardfix was being applied twice when using 2-handed weapons. Is that supposed to be that way? O.o

If I can gather more info I'll probabbly issue a report of its own, but thought this could be a good place to ask for some feedback on this :P

I spoke with malufett and he'll try to get a hot-fix asap

[quote name="Ind" timestamp="1372091210"]
I spoke with malufett and he'll try to get a hot-fix asap[/quote]

Thanks Ind (and Malufett), because this is pretty urgent, IMHO.

Thanks for your works =)

Temporary measure until malufett can adjust the formula, fix for pre-re and re: [url="https://github.com/HerculesWS/Hercules/commit/5785dbae3f513da20611e3147dadef2b9c911443"]https://github.com/HerculesWS/Hercules/commit/5785dbae3f513da20611e3147dadef2b9c911443[/url]

Ind after the update of asura, there still was a bug, acid demontration skill is bugged wherein i get only a damage around 5-7k to boss monsters

ok here is it
Fixed @ 074662a4b30e5d380fda32fd7df2d3ae2de759e0

using Calm Huuma Shuriken and Maximize Power
with cranial I deal [s]15159[/s] [b]14589[/b]
w/o cranial I deal 15217

normal attack
with cranial I deal [s]391[/s] [b]340[/b]
w/o cranial I deal 451

:meow:

thank you for this malu!! your the best!

Some skills as Asura is not being reduced by thara frog, is this correct ?

I don't know if you just have changed it with last commit but... should thara/poo poo/etc reduce magical damage in renewal?

Why shouldnt Thara reduce magical damage? Isnt it a 20% Race reduction? (Meaning all damage from X race, independant of the type/kind of damage, gets reduced?)

Pretty much same concept as getting X% less damage from Fire attacks, Firebolt should get reduced, right?

[quote name="malufett" timestamp="1371744946"]
take note in renewal only weapon atk is affected by racial reduction..also stated in iro wiki.. :D[quote]

Affected by weapon element when using a melee weapon.
Affected by ammunition element when using a ranged weapon or specific skill.
[b]Affected by element resistance effects such as Raydric Card or Asprika.
Increased by % ATK item effects such as The Sign or Hydra Card.[/b]
Multiplied by 5 when affected by Enchant Deadly Poison.
Though the STR bonus takes Element, it is still considered Neutral.
STR Bonus is always reduced by Ghost armor.
STR Bonus is only reduced by Neutral resistance. like Raydric card, if the weapon is Neutral too.
Variance is a random number ranging from (-5% * Weapon Level * Base Weapon ATK) to (5% * Weapon Level * Base Weapon ATK)[/quote]
and base atk is not affected..[quote]
Normally Neutral except when using Mild Wind.
[b]Ignores element resistance effects such as Raydric Card or Asprika.
Ignores % ATK item effects such as The Sign or Hydra Card.[/b][/quote][/quote]

Are you sure that damage should ignore racial resistance effects? It only says that ignores '%ATK item effects', but not resistance effects.

I mean, maybe it ignores '% attack' but takes into account '% resistance'

[quote name="Xgear" timestamp="1372401416"]
Why shouldnt Thara reduce magical damage? Isnt it a 20% Race reduction? (Meaning all damage from X race, independant of the type/kind of damage, gets reduced?)

Pretty much same concept as getting X% less damage from Fire attacks, Firebolt should get reduced, right?[/quote]

Thanks for your answer (I was not sure).
BTW, I'm sorry. I didn't explain myself properly. I meant that I don't know why using thara frog card (racial resistance), the magical attacks gets much more reduction than physical attacks.

[quote]
BTW, I'm sorry. I didn't explain myself properly. I meant that I don't know why using thara frog card (racial resistance), the magical attacks gets much more reduction than physical attacks.[/quote]
anyway I'll check in official since I didn't yet touch magical reduction formula only the mdef part..
[quote]
Some skills as Asura is not being reduced by thara frog, is this correct ?[/quote]
Confirming but only in bare fist..eagis code it quite stupid specially in skills that is why its hard to track the process flow..anyway I'll do my best to crack it..:D

:meow:

[quote name="malufett" timestamp="1372418641"][quote]
BTW, I'm sorry. I didn't explain myself properly. I meant that I don't know why using thara frog card (racial resistance), the magical attacks gets much more reduction than physical attacks.[/quote]anyway I'll check in official since I didn't yet touch magical reduction formula only the mdef part..[size=4] [/size][size=4] [/size][/quote]

Be Careful! I think magical resistance may be ~OK, the problem is still with physical reduction!! :meow:

I raised a doubt with you to confirm about it in a previous post! :D

[quote]
Be Careful! I think magical resistance may be ~OK, the problem is still with physical reduction!![/quote]
don't worry we can get it there soon..
and I also found out that racial and other mods is invoke twice officially if using skills...but some factors is still I need to figure out..

:meow:

[quote name="Beret" timestamp="1372309653"]
Some skills as Asura is not being reduced by thara frog, is this correct ?[/quote]
I can confirm, im using pre-renewal.

Bump~

[quote name="kyeme" timestamp="1372481395"][quote name="Beret" timestamp="1372309653"]

Some skills as Asura is not being reduced by thara frog, is this correct ?[/quote]I can confirm, im using pre-renewal.[/quote]

Fixed @ [url="https://github.com/HerculesWS/Hercules/commit/c1401ff17207e9c2aac551066f0bd90928dd90bb"]https://github.com/HerculesWS/Hercules/commit/c1401ff17207e9c2aac551066f0bd90928dd90bb[/url]

:meow:

Is not fixed I still have the same damage without thara frog and thara frog.

[quote name="Beret" timestamp="1372691055"]
Is not fixed I still have the same damage without thara frog and thara frog.[/quote]
did you update your file?
already working in latest version..



:meow:

Is not fixed yet, look at my tests

Target damage without any item was 106678 the 112122

equipped with develing, thara frog and Beret I managed to do 97668 the 99795


The reduction seems very low, in some cases I managed to do damage of 97956 with the target without any item, the Asura damage is very varying.

w8 is that pre or re?
the fixed I was telling is in pre like kyeme said..cause in RE it was pending ATM..

:meow:

tested in re.

and also the damage reduction from the [b]Beret is not working?the damage is still the same.[/b]

Confirming this
I still have problems with racial, attack type and element resist cards (feather beret, noxius and deviling).

I confirm. for example weapon damage on high_orc with water converter is the same as without

[quote name="Ind" timestamp="1372903060"]
I confirm. for example weapon damage on high_orc with water converter is the same as without[/quote]
unable to reproduce
[quote]
Confirming this
I still have problems with racial, attack type and element resist cards (feather beret, noxius and deviling[/quote][quote]
and also the damage reduction from the Beret is not working?the damage is still the same.[/quote]
here is a temporary fix 83e3b8d22acc73aeaafbf2a95e1fb9e6b228a63a
it works like in official however the output is not exact because the formula is not the same..

:meow: