Issue information

Issue ID
#7418
Status
Fixed
Severity
None
Started
kyeme
Jun 23, 2013 6:22
Last Post
Frost
Oct 27, 2013 23:07
Confirmation
N/A

kyeme - Jun 23, 2013 6:22

The mount doesnt disappear even the halter is expired.. the mount remains and causing a bug because you wont be able to take it off unless you buy another halter box

This post has been edited by kyeme on Jul 23, 2013 16:49

malufett - Jun 23, 2013 12:25

it seems that we need to redesign the rental system or made some tweak..
this bug is due of 'pc_reg_received' is triggered first before 'chrif_load_scdata'...
:meow:

Ind - Jun 23, 2013 23:19

humm o-o we could somehow introduce some standardised thing to be run when a rental item ends oo the following most likely sucks but so you can have an idea what I mean:[code=auto:0] 12622,Reins_Of_Mount,Reins Of Mount,11,0,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ setmounting(); end; OnRentalEnd: sc_end SC_ALLRIDING; },{},{} [/code]

Xgear - Jun 25, 2013 23:05

Wouldnt it be better to add a new flag into sc_config like
128 //Dispells when rental ends. and add seomthing like
sc_startrental(blah, blah, blah, ...);

That way it can be used through different means and ended properly?

KeiKun - Jul 9, 2013 2:05

Okay
we tested it under pRO

True:
1. When logout on mount, on login still on mount
2.1 Halter on Expire, Mount still there. Though[b] [/b]since its expired, [b]when you move the mount will disappear[/b]

Frost - Sep 10, 2013 1:01

Bump!

Tepoo - Sep 12, 2013 7:59

is there any progress on this bug?

as i have the same problem and would like to see it fixed.

on my server i am using a headgear as a rental who gives a buff, but when the rental time is over and the person is offline. the item dissapears, but the buff still is there.
i could realy need a fix for this. The Buff who is causing the problem is the SC_CASH_PLUSEXP

This post has been edited by Tepoo on Sep 12, 2013 8:18

Frost - Oct 10, 2013 16:40

Bump

Frost - Oct 24, 2013 13:11

Sir Ind! kindly fix this ASAP, thank you!

Ind - Oct 27, 2013 21:29

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/3e1b9de2a8a106d9471abbd1b232078eae268fbc"]https://github.com/HerculesWS/Hercules/commit/3e1b9de2a8a106d9471abbd1b232078eae268fbc[/url]

Frost - Oct 27, 2013 23:07

Thanks!