$@partymembercount gone missing when @reloadscript is executed

Issue information

Issue ID

#7429

Status

Fixed

Severity

None

Started

Poison

Jun 25, 2013 3:02

Last Post

shenhuyong

Jun 25, 2013 23:10

Confirmation

Yes (2)

No (0)

Poison - Jun 25, 2013 3:02

I'm using latest Hercules without any src modifications. It seems $@partymembercount variable is broken when @reloadscript is executed.

[b]How to reproduce:[/b]

1. NPC Script:

getpartymember getcharid(1), 0; npctalk ""+ $@partymembercount; end;

2. Click NPC and it should return 1 if you are the only one in the party.

3. Execute @reloadscript atcommand.

4. Click NPC again and bug should show. It will return 0 any how.

This post has been edited by Poison on Jun 25, 2013 3:08

Haru - Jun 25, 2013 3:26

Yep, I can confirm this.

I ran a bisect, this is the result:[code=auto:0]fcba8a2161a392369db99ab9a516a24470c54796 is the first bad commit commit fcba8a2161a392369db99ab9a516a24470c54796 Author: shennetsind <[email protected]> Date: Sun Jun 23 16:35:42 2013 -0300 Official Item Group/Package/Chain http://herc.ws/board/topic/1244-official-item-grouppackagechain/ Also Further implemented itemdb.c/storage.c interfaces, and a minor update to db2sql plugin. Signed-off-by: shennetsind <[email protected]> [/code]Now, this scares me:[quote]
54 changed files with 27,026 additions and 9,468 deletions.[/quote]Why are the commits in Hercules always so big, with more than one fix/feature packed together ;_;

Ind - Jun 25, 2013 14:44

Woo happens constant data is persistent to @reloadscript and I thought it wasn't, Fixed in [url="https://github.com/HerculesWS/Hercules/commit/70ee2e2545d150f21392fb7d7f47b5479307f29f"]https://github.com/HerculesWS/Hercules/commit/70ee2e2545d150f21392fb7d7f47b5479307f29f[/url]
Thank you both.[quote]
Why are the commits in Hercules always so big, with more than one fix/feature packed together ;_;[/quote]Usually its my fault for doing stuff related together D: in this case though over +20k lines are the resource files not actual code

shenhuyong - Jun 25, 2013 23:10

@reloaditemdb also exists this problem :D