Cart Problem

unable to produce the bug.
[img]http://s8.postimg.org/nh5u2l2b9/screen_Hercules003.jpg[/img][img]http://s8.postimg.org/sq0v0gkqd/screen_Hercules004.jpg[/img][img]http://s8.postimg.org/mswzjn3lh/screen_Hercules005.jpg[/img][img]http://s8.postimg.org/q9z1mm2np/screen_Hercules006.jpg[/img]

also for cart changing.
[img]http://s13.postimg.org/bq9mctzqf/screen_Hercules007.jpg[/img][img]http://s13.postimg.org/hfpux55wn/screen_Hercules008.jpg[/img]

weird, it only started when i updated this morning. it was fine before that. maybe git ignored a file because it had minor edits? i guess i'll just try with a clean copy and see what happens.

[quote]
Can't put items in cart, items previously in the cart disappear, can't remove cart[/quote]
I can confirm this
bgamez what is your rev?

Up~ :)

Oh, so kyeme you have the same problem? I can't figure out which commit gave me this issue, but I'm on the latest revision.

Yeah me too :)
Related: [url="http://herc.ws/board/tracker/issue-7482-cart-client-2013/"]http://herc.ws/board/tracker/issue-7482-cart-client-2013/[/url]

Up~ :)

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Confirming This on PRE -RE Mode[/size][/font][/color]

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]my Testserver running Latest Rev and got this bug[/size][/font][/color]

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]my Live Server runs on a commit from 06-28-2013 (Git Hash 7c479ad6027ccbce605ebb49c5e8900037772dd5 ) and dont got this bug[/size][/font][/color]

Fixed @ cf56f7c9142ae164d4e093807f1e7def3471afbd
:meow:

Not fixed yet :)

yeah, not fixed im still cannot change my cart using whitesmith character.

[quote name="unknown" timestamp="1373223263"]
yeah, not fixed im still cannot change my cart using whitesmith character.[/quote]
Try this [url="http://herc.ws/board/tracker/issue-7482-cart-client-2013/"]http://herc.ws/board/tracker/issue-7482-cart-client-2013/[/url]

ah I thought this is the problem[quote]
Can't put items in cart, items previously in the cart disappear, can't remove cart, when using the skill "Change Cart" it says... any work in progress (NPC dialog, manufacturing...) quit and try again.[/quote]

anyway let me check further..

ah..due to this [url="https://github.com/HerculesWS/Hercules/commit/ea5a413cdf7eec37141a7fe124cad38d66464ac4"]https://github.com/HerculesWS/Hercules/commit/ea5a413cdf7eec37141a7fe124cad38d66464ac4[/url]
:meow:

why i can't produce this bug?
[spoiler][img]http://s22.postimg.org/islshqhlt/screen_Hercules000.jpg[/img][img]http://s22.postimg.org/q3cpg48m9/screen_Hercules001.jpg[/img][img]http://s22.postimg.org/yo617aish/screen_Hercules002.jpg[/img][img]http://s22.postimg.org/51hbfiso1/screen_Hercules003.jpg[/img][img]http://s22.postimg.org/v5u1awhwh/screen_Hercules004.jpg[/img][img]http://s22.postimg.org/5cyrsa941/screen_Hercules005.jpg[/img][/spoiler]

also working on whitesmith class and blacksmith. maybe it depends on client version that we use?
[spoiler]
[img]http://s18.postimg.org/kntdk953d/screen_Hercules009.jpg[/img][img]http://s18.postimg.org/tzffh7hmx/screen_Hercules010.jpg[/img][img]http://s18.postimg.org/5hnbtbf2h/screen_Hercules011.jpg[/img]
[/spoiler]

@brynner
This is the prob @latest rev:[quote]
Can't put items in cart, items previously in the cart disappear, can't remove cart[/quote]

[quote name="kyeme" timestamp="1373225422"]
@brynner
This is the prob @latest rev:[quote]

Can't put items in cart, items previously in the cart disappear, can't remove cart[/quote][/quote]

i'm using the latest revision on my test server.
Git Hash: 'cf56f7c9142ae164d4e093807f1e7def3471afbd'
see screenshots #6.

It could also be a client-packet issue, but I don't see any recent commits that changes any files related to them. And the carts were working fine before my last update so the issue lies within the recent commits. I just updated this morning and Change Cart no longer gives me the odd message "[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3] any work in progress (NPC dialog, manufacturing...) quit and try again". But I still can't put items in the cart or change the way it looks. I think malufett is double checking it though, so I'll just wait for that.[/size][/font][/color]

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]edit: using 20120716 ragexe[/size][/font][/color]

[quote name="mofo" timestamp="1373240100"]
It could also be a client-packet issue, but I don't see any recent commits that changes any files related to them. And the carts were working fine before my last update so the issue lies within the recent commits. I just updated this morning and Change Cart no longer gives me the odd message "[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3] any work in progress (NPC dialog, manufacturing...) quit and try again". But I still can't put items in the cart or change the way it looks. I think malufett is double checking it though, so I'll just wait for that.[/size][/font][/color]

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]edit: using 20120716 ragexe[/size][/font][/color][/quote]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Try this (from rathena fix)[/size][/font][/color]
[url="http://trac.rathena.org/changeset/17407/rathena/trunk/src/common/socket.c"]trunk/src/common/socket.c[/url][quote]

[color=rgb(0,0,0)][font=monospace][size=2]#include "../common/showmsg.h"[/size][/font][/color]
[color=rgb(0,0,0)][font=monospace][size=2]#include "../common/strlib.h"[/size][/font][/color]
[font=monospace][size=2][background=rgb(221,255,221)]+ [/background][/size][/font][color=rgb(0,0,0)][font=monospace][size=2][background=rgb(221,255,221)]#include "../config/core.h"[/background][/size][/font][/color][/quote]
[url="http://trac.rathena.org/changeset/17407/rathena/trunk/src/common/socket.h"]trunk/src/common/socket.h[/url][quote]

[color=rgb(0,0,0)][font=monospace][size=2]#include "../common/cbasetypes.h"[/size][/font][/color]
[color=rgb(0,0,0)][font=monospace][size=2][background=rgb(255,221,221)]- #include "../config/core.h"[/background][/size][/font][/color][/quote]

That could work, but with hercules I always try not to edit anything out. This way I can confirm if an update fixed it and not just a work-around. But thanks for the fix. /no1

Fixed @ 713bc4da082e8b240ca6e0d9551c21c2931eece5
:meow:

its not yet fixed, when i rent a cart and try to use the change cart skill it will not change adn there is some message popping in my messagebar and i cant talk to any other npc anymore.

just updated today...still the message still occur and the cart did not change.

[quote name="xienne15" timestamp="1373336935"]
its not yet fixed, when i rent a cart and try to use the change cart skill it will not change adn there is some message popping in my messagebar and i cant talk to any other npc anymore.

just updated today...still the message still occur and the cart did not change.[/quote]
I'm not able to reproduce...all fixed in latest version

:meow:

[quote name="malufett" timestamp="1373364346"]
[quote name="xienne15" timestamp="1373336935"]

its not yet fixed, when i rent a cart and try to use the change cart skill it will not change adn there is some message popping in my messagebar and i cant talk to any other npc anymore.

just updated today...still the message still occur and the cart did not change.[/quote]I'm not able to reproduce...all fixed in latest version

:meow:[/quote]
Me too. No problem @latest rev