Issue information

Issue ID
#7486
Status
Fixed
Severity
None
Started
bgamez23
Jul 6, 2013 6:52
Last Post
Joseph
Jul 30, 2013 20:36
Confirmation
Yes (1)
No (0)

bgamez23 - Jul 6, 2013 6:52

how to produce?
change your job into a merchant or mechanic.
rent a cart and you can't move and you can't talk to the npc. same on mado.

[img]http://s23.postimg.org/pe88xdyd7/screen_Hercules009.jpg[/img]
[img]http://s23.postimg.org/ltcde5ttn/screen_Hercules010.jpg[/img]

xienne15 - Jul 6, 2013 9:41

not for me :(

bgamez23 - Jul 6, 2013 10:02

[quote name="xienne15" timestamp="1373103703"]
not for me :([/quote]

are you using the default breeder npc? i use the default one.

xienne15 - Jul 6, 2013 13:58

[url="https://raw.github.com/HerculesWS/Hercules/master/npc/custom/breeder.txt"]https://raw.github.com/HerculesWS/Hercules/master/npc/custom/breeder.txt[/url]

It happens during this line is executed in-game[code=auto:0] specialeffect2 EF_TEIHIT3; end; } [/code]

should be
[code=auto:0] specialeffect2 EF_TEIHIT3; close; } [/code]
Hope it works!~

This post has been edited by xienne15 on Jul 6, 2013 14:04

bgamez23 - Jul 7, 2013 19:53

[quote name="xienne15" timestamp="1373119102"]
[url="https://raw.github.com/HerculesWS/Hercules/master/npc/custom/breeder.txt"]https://raw.github.com/HerculesWS/Hercules/master/npc/custom/breeder.txt[/url]

It happens during this line is executed in-game[code=auto:0] specialeffect2 EF_TEIHIT3; end; } [/code]
should be
[code=auto:0] specialeffect2 EF_TEIHIT3; close; } [/code]Hope it works!~[/quote]

it is working on merchant class now up to whitesmith class on the latest version. but still not working on mechanic class. after you get cart you can't move.

unknown - Jul 8, 2013 17:28

mine working but i cant remove my cart

Nameless2you - Jul 8, 2013 18:54

[quote name="xienne15" timestamp="1373119102"]
[url="https://raw.github.com/HerculesWS/Hercules/master/npc/custom/breeder.txt"]https://raw.github.com/HerculesWS/Hercules/master/npc/custom/breeder.txt[/url]

It happens during this line is executed in-game[code=auto:0] specialeffect2 EF_TEIHIT3; end; } [/code]
should be
[code=auto:0] specialeffect2 EF_TEIHIT3; close; } [/code]Hope it works!~[/quote]

Since there's no usage of [code=auto:0]mes[/code] to display a message box it should use [code=auto:0]end;[/code]

bgamez23 - Jul 8, 2013 22:24

still waiting for official fix.

bgamez23 - Jul 10, 2013 14:42

[quote name="Nameless2you" timestamp="1373309663"][quote name="xienne15" timestamp="1373119102"]

[url="https://raw.github.com/HerculesWS/Hercules/master/npc/custom/breeder.txt"]https://raw.github.com/HerculesWS/Hercules/master/npc/custom/breeder.txt[/url]

It happens during this line is executed in-game[code=auto:0] specialeffect2 EF_TEIHIT3; end; } [/code]should be
[code=auto:0] specialeffect2 EF_TEIHIT3; close; } [/code]Hope it works!~
[/quote]
Since there's no usage of[code=auto:0] mes[/code]to display a message box it should use[code=auto:0] end;[/code][/quote]

this fix is working. but i'm still waiting for the official commit.

malufett - Jul 11, 2013 12:03

using 'select' command the button 'ok' is considered a continuation for 'mes' when pressed otherwise 'end' is invoke.
therefore after 'select' a 'close' must used.

:meow:

bgamez23 - Jul 17, 2013 7:36

bump

bgamez23 - Jul 20, 2013 7:54

up for this.

bgamez23 - Jul 21, 2013 8:05

up again.

bgamez23 - Jul 28, 2013 0:47

up for this. still not fix on the latest version.

Joseph - Jul 28, 2013 5:14

It appears that in any cases (with or without a menu) as long you have a 'close' then there will be no issues.

malufett - Jul 28, 2013 11:49

[quote name="Joseph" timestamp="1374988497"]
It appears that in any cases (with or without a menu) as long you have a 'close' then there will be no issues.[/quote]
nope only with 'menu' or 'select' command..

:meow:

This post has been edited by malufett on Jul 28, 2013 11:50

bgamez23 - Jul 29, 2013 9:24

up for this. still have no confirmation.

Joseph - Jul 30, 2013 20:36

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/4d6a69f0a44d3a0ce7bdf6c925f651014e47dcb3"]https://github.com/HerculesWS/Hercules/commit/4d6a69f0a44d3a0ce7bdf6c925f651014e47dcb3[/url].

Thanks!