Issue information

Issue ID
#7525
Status
Fixed
Severity
None
Started
Judas
Jul 14, 2013 13:21
Last Post
Judas
Jul 19, 2013 18:08
Confirmation
Yes (2)
No (0)

Judas - Jul 14, 2013 13:21

How to reproduce:

Use a healer script, (the one from custom/healer.txt will do nicely) set a price from 0 to some number
Use the healer and the character will lock up.
Only way to get out of this is relog.

mofo - Jul 14, 2013 13:49

This happens to me too, but only when the price is higher than the amount of zeny of the invoking char. If a player has enough zeny, he doesn't get stuck.

Judas - Jul 15, 2013 21:37

bump

shenhuyong - Jul 15, 2013 23:12

Your item_db must have an item's AegisName is Zeny, you can fix it after you change its AegisName.

Please note now the variable in your script can not same as any AegisName in your item_db.

This post has been edited by shenhuyong on Jul 16, 2013 0:47

Judas - Jul 16, 2013 1:27

I don't think its item_db related, I'm using the npc script in the custom folder that comes by default custom/healer.txt.

shenhuyong - Jul 16, 2013 2:47

I am sure your item_db must have an item's AegisName is Zeny.
Can you try change its AegisName? You will fix this problem.
Seems all of item's AegisName is a variable after item group system be updated.


I tested that:
1.Add this into item_db[code=auto:0]20000,Zeny,Zeny,3,100,,10,,,,,,,,,,,,,{},{},{}[/code]
2.Now any " set Zeny,xxxx;" in script will causing freezing,and players always has not enough zeny,because "if (Zeny<xxxxx)" in script is not working now.

This post has been edited by shenhuyong on Jul 16, 2013 3:00

Judas - Jul 16, 2013 10:32

alright ill give it a go

Gepard - Jul 16, 2013 10:58

Issue is caused by following code, which overwrites existing constants if they're redefined in item_db and related files.

[url="https://github.com/HerculesWS/Hercules/commit/fcba8a2161a392369db99ab9a516a24470c54796#src-map-script-c-P35"]https://github.com/HerculesWS/Hercules/commit/fcba8a2161a392369db99ab9a516a24470c54796#src-map-script-c-P35[/url]

Judas - Jul 16, 2013 21:13

thanks gepard, there was no warning of this, so thanks for bringing this up

Lelouch - Jul 18, 2013 6:34

Any development about this issue?

Ind - Jul 18, 2013 8:36

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/e26c9504e825abe8fe50eca28bf3b89de8e4bd9c"]https://github.com/HerculesWS/Hercules/commit/e26c9504e825abe8fe50eca28bf3b89de8e4bd9c[/url] no longer freezes and gives a warning during parse if a conflict exists (and if it exists it will prioritise the script variable over the item name constant)

Judas - Jul 19, 2013 18:08

thanks ind, much appreciated