Judas - Jul 20, 2013 13:22
[size=3][font=arial, helvetica, sans-serif][b]Problem :[/b][/font][/size]
[size=3][font=arial, helvetica, sans-serif]Increasing a level for a skill beyond 10 results in the skill being a close range attack.[/font][/size]
[size=3][font=arial, helvetica, sans-serif][b]How to reproduce: (Was able to produce on the latest git checkout)[/b][/font][/size]
[size=3][font=arial, helvetica, sans-serif]Increase a skill to a level beyond 10.[/font][/size]
[size=3][font=arial, helvetica, sans-serif]i.e: [/font][/size]
[size=3][font=arial, helvetica, sans-serif]1133,Fire_Brand,Fireblend,4,20,,500,100,,1,0,0x000654E2,7,2,2,4,40,1,2,{ bonus bAtkEle,Ele_Fire; skill "MG_FIREBOLT",15; bonus3 bAutoSpell,"MG_FIREBOLT",3,100; },{},{}[/font][/size]
[size=3][font=arial, helvetica, sans-serif]In src/map/skill.h[/font][/size]
[color=rgb(132,33,156)][font=Consolas][size=1][size=3][font=arial, helvetica, sans-serif][color=#0433ff]#define[/color][color=#000000] [/color]MAX_SKILL_LEVEL[color=#000000] 15 and recompile[/color][/font][/size][/size][/font][/color]
[color=rgb(132,33,156)][font=Consolas][size=1][size=3][font=arial, helvetica, sans-serif][color=#000000]In game, get the modified item, in this case @item 1133. You will see on level 10 the range is normal. When increasing the level beyond and more, the range will be a close range attack.[/color][/font][/size][/size][/font][/color]
[font=Consolas][size=1][size=3][font=arial, helvetica, sans-serif][b]There isn't a workaround for this, so hopefully this can be fixed.[/b][/font][/size][/size][/font]
[font=Consolas][size=1][size=3][font=arial, helvetica, sans-serif][b]Acceptance Criteria:[/b][/font][/size][/size][/font]
[size=3]Have Hercules be able to support skill level range beyond 10 and still function the same way in terms of range.[/size]
This post has been edited by
Judas
on Jul 20, 2013 13:22
malufett - Jul 20, 2013 14:49
I don't see any code that says that more than 10 then it will be considered as melee ranged..
[code=auto:0]
//Skill Range Criteria
int battle_range_type(struct block_list *src, struct block_list *target, uint16 skill_id, uint16 skill_lv) {
if (battle_config.skillrange_by_distance &&
(src->type&battle_config.skillrange_by_distance)
) { //based on distance between src/target [Skotlex]
if (check_distance_bl(src, target, 5))
return BF_SHORT;
return BF_LONG;
}
//based on used skill's range
if (skill->get_range2(src, skill_id, skill_lv) < 5)
return BF_SHORT;
return BF_LONG;
}
[/code]
:meow:
Judas - Jul 20, 2013 15:00
yeah I was checking the code as well, but increasing the skill level beyond it does indeed make it melee ranged
Judas - Jul 21, 2013 0:49
malu is there any way to tweak how its set in the src, to make sure any skill higher than 10 would operate as normal
Ind - Jul 21, 2013 12:26
[code=auto:0]
In game, get the modified item, in this case @item 1133. You will see on level 10 the range is normal. When increasing the level beyond and more, the range will be a close range attack.
[/code]how is this close range attack thing noticeable? (e.g. how can i know it is happening)
malufett - Jul 21, 2013 12:36
[quote name="Ind" timestamp="1374409600"][code=auto:0]
In game, get the modified item, in this case @item 1133. You will see on level 10 the range is normal. When increasing the level beyond and more, the range will be a close range attack.
[/code]how is this close range attack thing noticeable? (e.g. how can i know it is happening)[/quote]
me too I'm curious..:D
:meow:
Judas - Jul 21, 2013 15:06
because if you stand far a away and cast the fire bolt lvl 10, it will let you. If you increase the level to 15, and use the firebolt you will auto walk close to the enemy and then it will cast firebolt
Ind - Jul 21, 2013 18:23
Could it be the client fault? the server value is always 9, the client is usually the culprit when it comes to a skill walking to meet the range, does it still walk if you update the:[code=auto:0]
[SKID.MG_FIREBOLT] = {
"MG_FIREBOLT";
SkillName = "Fire Bolt",
MaxLv = 10,
SpAmount = { 12, 14, 16, 18, 20, 22, 24, 26, 28, 30 },
bSeperateLv = true,
AttackRange = { 9, 9, 9, 9, 9, 9, 9, 9, 9, 9 }
},
[/code]AttackRange field to support lv 15?
Judas - Jul 21, 2013 20:48
I'll try that, good idea, ill update this in a bit
Judas - Jul 21, 2013 20:57
works. Thanks Ind!
xathenx - Jul 26, 2013 18:05
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif]How about switching?[/font][/color]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif]Example if you change your weapon to no lv15 skill,, the lv15 skill will be removed to skill bar .. How to maintain the lv15 skill to your skillbar?[/font][/color]