*skill script command, invalid flag - Hercules bug tracker archive

Issue information

Issue ID

#7565

Status

Fixed

Severity

None

Started

Ind

Jul 22, 2013 14:36

Last Post

AnnieRuru

Mar 19, 2014 20:22

Confirmation

N/A

Ind - Jul 22, 2013 14:36

in documentation:[quote]
Flag 4 is the same as flag 1 in that it saves to the database. However,
these skills are ignored when any action is taken that adjusts the skill
tree (reset/job change).[/quote]but there is no flag 4.

jaBote - Jul 22, 2013 15:49

From doc/script_commands.txt in [url="https://github.com/HerculesWS/Hercules/commit/97296dc5dc848ab6aec12de1d2e9bb32dc5dc7d4"]97296dc5dc848ab6aec12de1d2e9bb32dc5dc7d4[/url] (2013-05-25). I think maybe Mysterious would have something for this.

Mysterious - Jul 23, 2013 13:37

I believe I left it as a place holder because I saw it in rAthena at the time: [url="http://trac.rathena.org/changeset/17256/rathena"]http://trac.rathena.org/changeset/17256/rathena[/url]

AnnieRuru - Mar 19, 2014 17:54

compare
[url="https://github.com/HerculesWS/Hercules/blob/master/src/map/pc.c#L3516"]https://github.com/HerculesWS/Hercules/blob/master/src/map/pc.c#L3516[/url]
[url="https://github.com/rathena/rathena/blob/master/src/map/pc.c#L3615"]https://github.com/rathena/rathena/blob/master/src/map/pc.c#L3615[/url]

their case 4 is exactly like our case 3
means if user change from rathena to hercules, they have to change flag 4 into flag 3

AnnieRuru - Mar 19, 2014 20:21

Fixed in
[url="https://github.com/HerculesWS/Hercules/commit/f7cd6b42179e2cdb5bbea3b9c060d0fc56d265b6"]https://github.com/HerculesWS/Hercules/commit/f7cd6b42179e2cdb5bbea3b9c060d0fc56d265b6[/url]

This post has been edited by AnnieRuru on Mar 19, 2014 20:21