Lassander - Jul 31, 2013 1:34
I found an issue where client versions from around 20091013 and earlier have errors compiling on windows.
The errors appear in clif.c, I'm not sure what causes them
Error 1 error C2039: 'objecttype' : is not a member of 'packet_idle_unit' d:\ragnarok\subversions\hercules\hercules\src\map\clif.c 928 1 map-server
Error 2 error C2039: 'objecttype' : is not a member of 'packet_spawn_unit' d:\ragnarok\subversions\hercules\hercules\src\map\clif.c 1168 1 map-server
Error 3 error C2039: 'objecttype' : is not a member of 'packet_unit_walking' d:\ragnarok\subversions\hercules\hercules\src\map\clif.c 1245 1 map-server
This probably isnt a very common issue, but someone I know wants to use a really old client and I'm giving them a hand with it.
This post has been edited by
Lassander
on Jul 31, 2013 1:36
Haru - Jul 31, 2013 3:12
Confirmed, the issue will happen with any PACKETVER between 20071106 and 20091103 because an inconsistency between clif.c and packets_struct.h (but I'm not sure which is the correct one)
Ind - Jul 31, 2013 14:46
Thank you both
[url="https://github.com/HerculesWS/Hercules/commit/298f02f380d4de88129f0a296456d461cbc6505e"]https://github.com/HerculesWS/Hercules/commit/298f02f380d4de88129f0a296456d461cbc6505e[/url]
Lassander - Aug 1, 2013 3:02
Thanks for being so quick! Not sure it is fixed. NPCs don't seem to be showing up. It may not be related though. I'm also getting some weird elastic banding.
More info, there are no packet errors showing up on the map server window, Warp portals work but don't show up, so I think it's just an issue with the packet that shows npcs.
I think the elastic banding is worse where there are supposed to be NPCs on screen. The specific client date I'm using is 20091013.
I've done some more searching, mobs seem to cause client errors.
Also, I have found one npc sprite that's actually poping up near the centre of Prontera.
[URL=http://imgur.com/IlhVDMo][img]http://i.imgur.com/IlhVDMo.png[/img][/URL]
This post has been edited by
Lassander
on Aug 1, 2013 5:14
Ind - Aug 1, 2013 12:25
can you send me your exe so I can further debug with it? (I don't have a working client that old)
Lassander - Aug 1, 2013 21:00
Sure thing I was going to ask, I'll also send you the xray files since yes it's that old. It's around the time xray shut down so I think that's why they wanted to use this client.
[url="http://www.mediafire.com/download/3gele6eh7d19j2u/client-required.zip"]http://www.mediafire.com/download/3gele6eh7d19j2u/client-required.zip[/url]
Ind - Aug 2, 2013 21:43
I've made and tested a fix for it but I'm unable to commit right now, its here: [attachment=507:7605-Fix.patch] hopefully another dev can commit it in my place
Lassander - Aug 2, 2013 22:16
Thanks! the patch seems to be working for me for now. Walking around a field seems to give me no end of gravity errors though. Not really sure what causes it. I've tested the client on eAthena and everything worked, so I'm assuming it's another packet issue. There is also an issue with gender confusion.
[URL=http://imgur.com/eXspbna][img]http://i.imgur.com/eXspbna.jpg[/img][/URL]
[URL=http://imgur.com/xH9VKU9][img]http://i.imgur.com/xH9VKU9.jpg[/img][/URL]
This post has been edited by
Lassander
on Aug 3, 2013 3:30
Ind - Aug 3, 2013 14:46
ooh I have an idea on what it could be, I'll run some tests
Ind - Aug 3, 2013 14:52
there is something i'd like to confirm to know whether I'm doing a faithful reproduction, your src/common/mmo.h is #packetver is set as 20091013 ?
Lassander - Aug 3, 2013 20:59
That is correct. The multiple characters thing might have been something else. I wasn't the one to run that test my friend was and she's not sure what she did.
Ind - Aug 4, 2013 16:32
Should be fixed in [url="https://github.com/HerculesWS/Hercules/commit/7b0361fb160a1126dc6f9873f87f8a02f704764e"]https://github.com/HerculesWS/Hercules/commit/7b0361fb160a1126dc6f9873f87f8a02f704764e[/url]