From login.c, preprocessor output (gcc-4.9 -E):[code=auto:0]
struct Login_Config {
uint32 login_ip;
uint16 login_port;
unsigned int ipban_cleanup_interval;
unsigned int ip_sync_interval;
_Bool log_login;
char date_format[32];
_Bool new_account_flag,new_acc_length_limit;
int start_limited_time;
_Bool use_md5_passwds;
int group_id_to_connect;
int min_group_id_to_connect;
_Bool check_client_version;
uint32 client_version_to_connect;
_Bool ipban;
_Bool dynamic_pass_failure_ban;
unsigned int dynamic_pass_failure_ban_interval;
unsigned int dynamic_pass_failure_ban_limit;
unsigned int dynamic_pass_failure_ban_duration;
_Bool use_dnsbl;
char dnsbl_servs[1024];
int client_hash_check;
struct client_hash_node *client_hash_nodes;
};
[/code]
From ipban_sql.c, preprocessor output:[code=auto:0]
struct Login_Config {
uint32 login_ip;
uint16 login_port;
unsigned int ipban_cleanup_interval;
unsigned int ip_sync_interval;
bool log_login;
char date_format[32];
bool new_account_flag,new_acc_length_limit;
int start_limited_time;
bool use_md5_passwds;
int group_id_to_connect;
int min_group_id_to_connect;
bool check_client_version;
uint32 client_version_to_connect;
bool ipban;
bool dynamic_pass_failure_ban;
unsigned int dynamic_pass_failure_ban_interval;
unsigned int dynamic_pass_failure_ban_limit;
unsigned int dynamic_pass_failure_ban_duration;
bool use_dnsbl;
char dnsbl_servs[1024];
int client_hash_check;
struct client_hash_node *client_hash_nodes;
};
[/code]
If you #include "../common/HPM.h" from ipban_sql.c, then the 'bool' in it will be '_Bool' as well.
If you comment out the #include <dlfcn.h> from HPM.h, all the '_Bool' will be 'bool' again. (code won't compile of course - I only checked the preprocessor's output)
The same happens with older gcc versions (i.e. i686-apple-darwin11-llvm-gcc-4.2), but they don't complain about it.
Ideas?
Edit: <dlfcn.h> includes <stdbool.h>, which typedefs bool as _Bool. If all supported compilers allow that, we should use it instead of typedeffing our own bool (it's part of C99 - did Microsoft comply yet?). At least on the platforms/compilers that support it.