Issue information

Issue ID
#7649
Status
New
Severity
None
Started
Mikado
Aug 12, 2013 15:52
Last Post
Mikado
Aug 13, 2013 17:00
Confirmation
N/A

Mikado - Aug 12, 2013 15:52

As in the source:[code=:0] // Epoque: // This code will compare the player's attack motion value which is influenced by ASPD before // allowing a skill to be cast. This is to prevent no-delay ACT files from spamming skills such as // AC_DOUBLE which do not have a skill delay and are not regarded in terms of attack motion. if( !sd->state.autocast && sd->skillitem != skill_id && sd->canskill_tick && DIFF_TICK(iTimer->gettick(), sd->canskill_tick) < (sd->battle_status.amotion * (battle_config.skill_amotion_leniency) / 100) ) {// attempted to cast a skill before the attack motion has finished return 1; } [/code]
As the default, 90, this operation: (sd->battle_status.amotion * (battle_config.skill_amotion_leniency) / 100) returns 90 at 190 aspd. Which let a Sniper (for example) cast 10 skills per second, and acordingly to the "Epoque", this code is to prevent nodelay, which fails with this calculation.

So to fix the sniper the calculation should be: (sd->battle_status.amotion * (100 + battle_config.skill_amotion_leniency) / 100) ), but it only works for Sniper, because Creator (for example) doesn't have after cast delay and this formula will ruin its skill spam.

So basically, this check is useless and doesn't work for anything else that is already implemented.

Tepoo - Aug 13, 2013 5:38

if only Sniper have this problem with the actual formula, why not just differ between Sniper and the rest?

or implementing a 3way handshake into hercules for checking if the grf files are the real one.

This post has been edited by Tepoo on Aug 13, 2013 5:39

Mikado - Aug 13, 2013 17:00

The Sniper is only an example, basicly with 190 aspd this setting is pointless (as it's 90 ms, while the min delay is setted at 100ms).

Other examples:
Soul linkers animations for Kaupe and Kaite lasts 500ms.
Acolyte blessing is about 580ms.
Swordman bash is 2 times amotion (as Sniper)
Land protector is 500~ ms too.
Etc