Issue information

Issue ID
#7671
Status
Fixed
Severity
Low
Started
bgamez23
Aug 25, 2013 8:51
Last Post
Wolf
Aug 29, 2013 15:16
Confirmation
Yes (1)
No (0)

bgamez23 - Aug 25, 2013 8:51

if you select to warp on the map that are not existed on Pre-re. you cannot move right after displaying "This map is not enabled in Pre-Renewal.

how to produce? talk to the npc warper.
select instance. and choose Octopus Cave or any other map that are not existed on Pre-re.
after you receive the "This map is not enabled in Pre-Renewal."
yoi can't move or talk to other npc.

[img]http://s11.postimg.org/vseivvcc3/screen_Synch_RO003.jpg[/img]
[img]http://s11.postimg.org/yl7qfwcoj/screen_Synch_RO004.jpg[/img]

bgamez23 - Aug 25, 2013 8:53

i think the issue there is the close to end. but after changing it to close. it works again normally.

KeiKun - Aug 26, 2013 1:31

[code=:0] npc/custom/warper.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/npc/custom/warper.txt b/npc/custom/warper.txt index e8f640d..68a9cb1 100644 --- a/npc/custom/warper.txt +++ b/npc/custom/warper.txt @@ -88,7 +88,7 @@ function Pick { } if (.@warp_block & (1<<.@select)) { message strcharinfo(0),"This map is not enabled in "+((checkre(0))?"":"Pre-")+"Renewal."; - end; + close; } warp .@map$,@c[.@i*2],@c[.@i*2+1]; getmapxy(lastwarp$,lastwarpx,lastwarpy,0); @@ -103,7 +103,7 @@ function Restrict { set @warp_block, @warp_block | (1<<getarg(.@i)); } else { message strcharinfo(0),"This map is not enabled in "+((checkre(0))?"":"Pre-")+"Renewal."; - end; + close; } } return; [/code]

bgamez23 - Aug 26, 2013 4:56

still waiting for official fix. :)

Wolf - Aug 28, 2013 18:33

The error was not really close by.

For a end, the script will terminate, but returns nothing, because there's nothing else to be returned, as with a close, the script closes and ends the above function.

I'll soon fix. ;)

This post has been edited by Wolf on Aug 28, 2013 18:33

Wolf - Aug 28, 2013 19:39

[url="https://github.com/HerculesWS/Hercules/commit/1ba8caf3b72da0501b3d3eb72294a3f25bdd31ed"]https://github.com/HerculesWS/Hercules/commit/1ba8caf3b72da0501b3d3eb72294a3f25bdd31ed[/url] fix.

[b]Thanks KeiKun! [/b]

This post has been edited by Wolf on Aug 28, 2013 19:49