New ranking List feature. - Hercules bug tracker archive

Issue information

Issue ID

#7705

Status

Confirmed

Severity

None

Started

Tepoo

Sep 12, 2013 18:08

Last Post

Haru

Sep 12, 2013 20:06

Confirmation

Yes (2)

No (0)

Tepoo - Sep 12, 2013 18:08

Hey,

as im not 100% perfect in working with your hercules source (still fitted to the rathena structure)
i would like to see you implementing this update from rathena about the new rankinglists in hercules.

[url="http://rathena.org/board/tracker/issue-7760-displaying-rank-system-crush-the-client-unknown-packet-for-2013/"]http://rathena.org/board/tracker/issue-7760-displaying-rank-system-crush-the-client-unknown-packet-for-2013/[/url]

they implemented it, and i tryed to get it working on hercules too, but stuck at many points. (still dont know why you changed so much in the logic of the files, compared to rathena)

Greetings
Tepoo

hemagx - Sep 12, 2013 18:23

i think it's better to report the problem and test if exist in Hercules or not than ask Hercules to merge rA update.
Simply Hercules will do better fix :P.
but your problem info and everything you can say about it :

Tepoo - Sep 12, 2013 18:43

in 5minutes my team and i will post a patch for hercules. we where able to implement this new feature into hercules.

Edit: okay mabye some more. listcheck is working, but update make some problems. but i think we can also fix this ^^

Edit2: fixed and working for all rankings. patch will be applyed here when we cleaned it.

This post has been edited by Tepoo on Sep 12, 2013 19:12

schwierig - Sep 12, 2013 19:20

[url="https://www.dropbox.com/s/lcvr1m0gmfctd7m/fixedRankingListPakets.patch"]https://www.dropbox.com/s/lcvr1m0gmfctd7m/fixedRankingListPakets.patch[/url]

This is the patch for the problem ;)

Pull request done.

This post has been edited by schwierig on Sep 12, 2013 20:11