quesoph - Sep 20, 2013 5:57
Tested on Latest Rev.
This happens when warping on a floating npc:[code=auto:0]
-<tab>script<tab>npcname<tab>-1,{
end;
}
[/code]
Core dumps ( from a modified src ):
[attachment=639:Untitled.png]
quesoph - Sep 20, 2013 6:00
[attachment=640:Untitled.png]
kyeme - Sep 20, 2013 6:12
How to reproduce? Can I try?
quesoph - Sep 20, 2013 6:16
make an npc[code=auto:0]
-<tab>script<tab>npcname<tab>-1,{
end;
}
[/code]
then ingame:
[code=auto:0]@tonpc npcname[/code]
kyeme - Sep 20, 2013 6:35
Aww not working using @tonpc[code=auto:0]
@tonpc failed.
[/code]
Console warning:
[attachment=641:waeeee.JPG]
Imusing windows
quesoph - Sep 20, 2013 6:42
fail. I'll test it again.
quesoph - Sep 20, 2013 6:54
I tested it again with a freshly checked out server.
and ingame
@tonpc Agit_Event
( from agit controller )
and it crashed.
the only edited part is this
mmo.h
[code=auto:0]#ifndef PACKETVER
#define PACKETVER 20120410
#endif[/code]
' cause I am using 20120410 obviously. :D
No core dumps because I am using windows..
This post has been edited by
quesoph
on Sep 20, 2013 6:55
Haru - Sep 20, 2013 23:55
In my case, I don't get a crash, but I see how this is very wrong. It's trying to access map[-1]. Depending on your compiler/system/architecture, it'll either read garbage data or crash. (and the second possibility is less scary than the first)
Haru - Sep 21, 2013 1:51
Fixed in [url="https://github.com/HerculesWS/Hercules/commit/51241f66ad6e78cf56b91c41e524c00a1d5abeb2"]https://github.com/HerculesWS/Hercules/commit/51241f66ad6e78cf56b91c41e524c00a1d5abeb2[/url]
quesoph - Sep 21, 2013 7:24
Thanks Haru..